Prevent history visible banner from displaying in threads.#31535
Merged
kaylendog merged 3 commits intoelement-hq:developfrom Dec 15, 2025
Merged
Prevent history visible banner from displaying in threads.#31535kaylendog merged 3 commits intoelement-hq:developfrom
kaylendog merged 3 commits intoelement-hq:developfrom
Conversation
t3chguy
approved these changes
Dec 12, 2025
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 15, 2025
* fix: Prevent history visible banner from displaying in threads. * tests: Verify banner is not visible in threads.
richvdh
reviewed
Dec 15, 2025
| return ( | ||
| <div className={classes} ref={this.ref} role="region" aria-label={_t("a11y|message_composer")}> | ||
| <HistoryVisibleBanner room={this.props.room} /> | ||
| <HistoryVisibleBanner room={this.props.room} threadId={threadId} /> |
Member
There was a problem hiding this comment.
[random question: would it not be easier to suppress the banner here, than having to thread threadId down into the viewmodel, and do the calculation there?]
Contributor
Author
There was a problem hiding this comment.
I'm inclined to agree; my excuse for not writing that way is that I'm not entirely sure where we want to draw the line on what should and should not be included in the MVVM logic as opposed to in the component itself.
I opted to do this in the MVVM logic since it's where the rest of the logic is, and even if suppression here is technically more React-esque, doing it in MVVM does keep the component logic in one place.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 27, 2026
* Revert "Update algorithm for history visible banner. (#31577)" This reverts commit ce9c66b. * Revert "Update prop type & documentation for HistoryVisibleBanner and VM. (#31545)" This reverts commit 4da149e. * Revert "Prevent history visible banner from displaying in threads. (#31535)" This reverts commit c7134e8. * Revert "Implement UI for history visibility acknowledgement. (#31156)" This reverts commit cff9119.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #31530
Checklist
public/exportedsymbols have accurate TSDoc documentation.