-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
Remove "history may be shared" banner. #31881
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
11b1fdb
Revert "Update algorithm for history visible banner. (#31577)"
kaylendog 7a717a2
Revert "Update prop type & documentation for HistoryVisibleBanner and…
kaylendog 96bac6f
Revert "Prevent history visible banner from displaying in threads. (#…
kaylendog 9eae11a
Revert "Implement UI for history visibility acknowledgement. (#31156)"
kaylendog File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
42 changes: 0 additions & 42 deletions
42
...red-components/src/composer/HistoryVisibleBannerView/HistoryVisibleBannerView.stories.tsx
This file was deleted.
Oops, something went wrong.
29 changes: 0 additions & 29 deletions
29
...shared-components/src/composer/HistoryVisibleBannerView/HistoryVisibleBannerView.test.tsx
This file was deleted.
Oops, something went wrong.
78 changes: 0 additions & 78 deletions
78
...ages/shared-components/src/composer/HistoryVisibleBannerView/HistoryVisibleBannerView.tsx
This file was deleted.
Oops, something went wrong.
62 changes: 0 additions & 62 deletions
62
...rc/composer/HistoryVisibleBannerView/__snapshots__/HistoryVisibleBannerView.test.tsx.snap
This file was deleted.
Oops, something went wrong.
8 changes: 0 additions & 8 deletions
8
packages/shared-components/src/composer/HistoryVisibleBannerView/index.ts
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file modified
BIN
-3.36 KB
(94%)
...apshots/crypto/history-sharing.spec.ts/shared-history-invite-accepted-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So what's the point of this screenshot?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have restored the screenshot to the expected result produced by the test introduced in #30948. I believe the intention is to make sure a message is decryptable in an E2E environment.