Upgrade EUI to 21.0.1 by chandlerprall · Pull Request #60282 · elastic/kibana

chandlerprall · 2020-03-16T16:38:45Z

Summary

Most changes fall under one of these reasons

Snapshot updates are from a new default prop on EuiAccordion, and a new aria id management in EuiFilePicker
A couple tests verified table th cell contents, and EUI now renders empty table cells as td for better accessibility support; these tests were updated to maintain the correct target to their th elements
EuiSearchBar was converted to typescript, which affected some existing Kibana types & implementations. I've focused on modifying only the types and not any runtime code

`21.0.1`

Bug Fixes

Made EuiDataGrid's schema.isSortable value optional (#2991)

`21.0.0`

Added EuiDataGrid's default sort order property (#2987)
Fixed EuiDataGrid's pagination visibility when changing rows per page (#2978)
Added highlightAll prop to EuiHighlight to highlight all matches (#2957)
Added showOnFocus prop to EuiScreenReaderOnly to force display on keyboard focus (#2976)
Added EuiSkipLink component (#2976)
Created EuiBadgeGroup component (#2921)
Added sections and position props to EuiHeader (#2928)
Added gutterSize prop to EuiListGroup (#2980)
Added color prop to EuiListGroupItem and updated size style (#2980)
Added enableAllColumns to EuiBasicTable component (#2906)

Bug Fixes

Fixed EuiDataGrid's sort popover to behave properly on mobile screens (#2979)
Fixed EuiButton and other textual components' disabled contrast (#2874)
Fixed z-index conflict with cell popovers in EuiDataGrid while in full screen mode (#2959)
Adjusted the header on EuiDataGrid to fix to the top within constrained containers and full screen mode (#2959)
Refactored EuiDescribedFormGroup to allow the content inside the EuiTitle to be accessible to screen reader users (#2989)

Breaking changes

Updated @types/react and @types/react-dom to utilize React.RefCallback type instead of custom implementation (#2929)

Theme: Amsterdam

Buttons have a new visual style (#2874)

`20.1.0`

Added theme prop to EuiCodeEditor in support of AceEditor themes (#2970)
EuiButton now has a single return statement (#2954)
Added isSortable props to EuiDataGridColumn and EuiDataGridSchemaDetector to mark them as un-sortable (#2952)
Converted EuiForm to TypeScript, added many missing /form Prop types (#2896)
Empty table th elements replaced with td in EuiTable. (#2934)
Added default prompt text to aria-describedby for EuiFilePicker (#2919)
Added SASS variables for text variants of the primary palette $euiColorPrimaryText, $euiColorSecondaryText, etc... Updated components to use these new variables. (#2873)
Updated SASS mixin makeHighContrastColor() to default $background: $euiPageBackgroundColor and $ratio: 4.5. Created makeGraphicContrastColor() for graphic specific contrast levels of 3.0. (#2873)
Added arrowDisplay prop to EuiAccordion for changing side or hiding completely (#2914)
Added prepend and append ability to EuiFieldSearch (#2914)
Added notification and notificationColor props to EuiHeaderSectionItemButton (#2914)
Added folderCheck, folderExclamation, push, quote, reporter and users icons (#2935)
Updated folderClosed and folderOpen to match new additions and sit better on the pixel grid (#2935)
Converted EuiSearchBar to Typescript (#2909)

Bug fixes

Fixed EuiDataGrid breaking if invalid schema passed (#2955)
Fixed EuiTitle not rendering child classes (#2925)
Extended div element in EuiFlyout type (#2914)
Fixed popover positioning service to be more lenient when positioning 0-width or 0-height content (#2948)

Theme: Amsterdam

Text sizes are now based on a 14px base font size. Headings are now bold. (#2936)
Altered secondary, accent colors to be more saturated (#2873)

spalger

@kbn/ui-shared-deps changes look good.

nreese

maps changes LGTM, code review

typings/@elastic/eui/index.d.ts

chrisronline

LGTM from stack monitoring

crob611

Canvas changes look good 👍

thompsongl

Snapshot changes and type updates LGTM

smith

APM changes look good!

chandlerprall · 2020-03-19T05:05:16Z

jenkins test this

kertal

KibanaApp changes LGTM

chandlerprall · 2020-03-19T19:42:39Z

jenkins test this

patrykkopycinski · 2020-03-20T10:10:40Z

[2020-03-19T19:51:55.180Z] window is not defined
[2020-03-19T19:51:55.180Z] at Object.getAceInstance (/dev/shm/workspace/kibana/node_modules/@elastic/eui/node_modules/react-ace/src/editorOptions.ts:51:3)

…nal test config imports

kibanamachine · 2020-03-20T18:12:19Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 797b2a5

History

💔 Build #34917 failed ee0c755
💔 Build #34873 failed df5af6e
💔 Build #34845 failed 2efcfa9
💔 Build #34826 failed 26d182f
💔 Build #34673 failed d53b6bf

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

stephmilovic

LGTM 🚀 🎸

* update to eui 21.0.1 * most changes needed for search bar ts changes * Passing types * snapshots * jest tests * Removed IQuery placeholder types * Updated functional test to only look at table headers with content * Moved 'filters' definition around in api docs * Update types * update snapshot * typo * Move DATA_FRAME_TASK_STATE enum to its own file to fix x-pack functional test config imports * merge public api 'changes' Co-authored-by: patrykkopycinski <patryk.kopycinski@elastic.co> Co-authored-by: Patryk Kopycinski <contact@patrykkopycinski.com>

* Upgrade EUI to 21.0.1 (#60282) * update to eui 21.0.1 * most changes needed for search bar ts changes * Passing types * snapshots * jest tests * Removed IQuery placeholder types * Updated functional test to only look at table headers with content * Moved 'filters' definition around in api docs * Update types * update snapshot * typo * Move DATA_FRAME_TASK_STATE enum to its own file to fix x-pack functional test config imports * merge public api 'changes' Co-authored-by: patrykkopycinski <patryk.kopycinski@elastic.co> Co-authored-by: Patryk Kopycinski <contact@patrykkopycinski.com> * unit test update Co-authored-by: patrykkopycinski <patryk.kopycinski@elastic.co> Co-authored-by: Patryk Kopycinski <contact@patrykkopycinski.com>

chandlerprall added 6 commits March 16, 2020 10:00

update to eui 21.0.1

750c6a8

most changes needed for search bar ts changes

e40ba52

Passing types

5aa2984

snapshots

d45024c

jest tests

f237831

Removed IQuery placeholder types

33e6296

chandlerprall added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.7.0 labels Mar 16, 2020

chandlerprall requested review from a team and thompsongl March 16, 2020 16:38

chandlerprall requested a review from a team as a code owner March 16, 2020 16:38

chandlerprall requested a review from a team March 16, 2020 16:38

chandlerprall requested review from a team as code owners March 16, 2020 16:38

chandlerprall requested a review from a team March 16, 2020 16:38

spalger approved these changes Mar 16, 2020

View reviewed changes

nreese approved these changes Mar 16, 2020

View reviewed changes

chandlerprall changed the title ~~Eui 21 0 1~~ Upgrade EUI to 21.0.1 Mar 16, 2020

myasonik reviewed Mar 16, 2020

View reviewed changes

typings/@elastic/eui/index.d.ts Show resolved Hide resolved

chrisronline approved these changes Mar 16, 2020

View reviewed changes

chandlerprall added 2 commits March 16, 2020 21:06

Updated functional test to only look at table headers with content

0519a25

Moved 'filters' definition around in api docs

2043904

chandlerprall requested a review from a team as a code owner March 17, 2020 04:19

lizozom approved these changes Mar 17, 2020

View reviewed changes

Merge branch 'master' into eui-21-0-1

21e9538

crob611 approved these changes Mar 17, 2020

View reviewed changes

thompsongl approved these changes Mar 17, 2020

View reviewed changes

smith approved these changes Mar 18, 2020

View reviewed changes

Merge branch 'master' into eui-21-0-1

4cd962b

kertal approved these changes Mar 19, 2020

View reviewed changes

Merge branch 'master' into eui-21-0-1

d53b6bf

oatkiller approved these changes Mar 19, 2020

View reviewed changes

patrykkopycinski and others added 8 commits March 20, 2020 11:11

Merge branch 'master' into eui-21-0-1

26d182f

Update types

2efcfa9

update snapshot

df5af6e

typo

ee0c755

Merge branch 'master' into eui-21-0-1

45eabd2

Move DATA_FRAME_TASK_STATE enum to its own file to fix x-pack functio…

a669181

…nal test config imports

Merge branch 'master' into eui-21-0-1

bf9f52a

merge public api 'changes'

797b2a5

chandlerprall requested a review from a team as a code owner March 20, 2020 16:26

stephmilovic approved these changes Mar 20, 2020

View reviewed changes

chandlerprall merged commit 0bf62cb into elastic:master Mar 20, 2020

chandlerprall deleted the eui-21-0-1 branch March 20, 2020 20:07

chandlerprall mentioned this pull request Mar 20, 2020

[7.x] Upgrade EUI to 21.0.1 (#60282) #60809

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Upgrade EUI to 21.0.1#60282

Upgrade EUI to 21.0.1#60282
chandlerprall merged 19 commits intoelastic:masterfrom
chandlerprall:eui-21-0-1

chandlerprall commented Mar 16, 2020

Uh oh!

spalger left a comment

Uh oh!

nreese left a comment

Uh oh!

Uh oh!

chrisronline left a comment

Uh oh!

crob611 left a comment

Uh oh!

thompsongl left a comment

Uh oh!

smith left a comment

Uh oh!

chandlerprall commented Mar 19, 2020

Uh oh!

kertal left a comment

Uh oh!

chandlerprall commented Mar 19, 2020

Uh oh!

patrykkopycinski commented Mar 20, 2020 •

edited

Loading

Uh oh!

kibanamachine commented Mar 20, 2020

Uh oh!

stephmilovic left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

14 participants

Conversation

chandlerprall commented Mar 16, 2020

Summary

21.0.1

21.0.0

20.1.0

Uh oh!

spalger left a comment

Choose a reason for hiding this comment

Uh oh!

nreese left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

chrisronline left a comment

Choose a reason for hiding this comment

Uh oh!

crob611 left a comment

Choose a reason for hiding this comment

Uh oh!

thompsongl left a comment

Choose a reason for hiding this comment

Uh oh!

smith left a comment

Choose a reason for hiding this comment

Uh oh!

chandlerprall commented Mar 19, 2020

Uh oh!

kertal left a comment

Choose a reason for hiding this comment

Uh oh!

chandlerprall commented Mar 19, 2020

Uh oh!

patrykkopycinski commented Mar 20, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kibanamachine commented Mar 20, 2020

💚 Build Succeeded

History

Uh oh!

stephmilovic left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

14 participants

`21.0.1`

`21.0.0`

`20.1.0`

patrykkopycinski commented Mar 20, 2020 •

edited

Loading