Adding more props to EuiHeaderSectionItemButton, EuiFieldSearch, and EuiAccordion#2914
Merged
cchaos merged 16 commits intoelastic:masterfrom Feb 28, 2020
Merged
Adding more props to EuiHeaderSectionItemButton, EuiFieldSearch, and EuiAccordion#2914cchaos merged 16 commits intoelastic:masterfrom
cchaos merged 16 commits intoelastic:masterfrom
Conversation
added 8 commits
February 21, 2020 16:48
Needs some doc something
…nItemButton to automatically add the correct positioning via CSS
This reverts commit 61a3103.
cchaos
added
the
deprecations
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_2914/ |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_2914/ |
thompsongl
approved these changes
Feb 25, 2020
Contributor
thompsongl
left a comment
thompsongl
left a comment
There was a problem hiding this comment.
LGTM; just a couple comment changes
src/components/header/header_section/header_section_item_button.tsx
Outdated
Show resolved
Hide resolved
39 tasks
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_2914/ |
elizabetdev
approved these changes
Feb 28, 2020
Contributor
elizabetdev
left a comment
elizabetdev
left a comment
There was a problem hiding this comment.
LGTM! 🎉
I looked at the code and tested the build.
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_2914/ |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_2914/ |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_2914/ |
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continuing preparation for the new nav drawer
1. Added
arrowDisplayprop to EuiAccordion for changing side or hiding completely2. Added
prependandappendability to EuiFieldSearch3. Added
notificationandnotificationColorprops to EuiHeaderSectionItemButton... to automatically add the correct positioning via CSS. Consumers used to have to supply the
<EuiNotificationBadge className="euiHeaderNotification" />manually as a child of theEuiHeaderSectionItemButton. Instead, I just made it an option ofEuiHeaderSectionItemButtondirectly to make it simpler.This will also then deprecate the need for the class
. euiHeaderNotificationwhich can only be applied manually.4. Extending
divelement in EuiFlyout typeThis is so
idcan properly be passed down without complaint by TS.Checklist