eui button now has a single return statement

[anishagg17]

Summary

Fixes : #2831

eui button now has a single return statement to rerturn button or anchor tag

Checklist

• Check against all themes for compatibility in both light and dark modes
• Checked in mobile
• Checked in IE11 and Firefox
• Props have proper autodocs
• Added documentation examples
• Added or updated jest tests
• Checked for breaking changes and labeled appropriately
• Checked for accessibility including keyboard-only and screenreader modes
• A changelog entry exists and is marked appropriately

[kibanamachine]

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

[chandlerprall]

jenkins test this

[kibanamachine]

Preview documentation changes for this PR: https://eui.elastic.co/pr_2954/

[chandlerprall]

Snapshot tests caught two more -

      <button
        class="euiButton euiButton--primary"
        disabled=""
    +   href="#"
        type="button"
      >

      <a
        class="euiButton euiButton--primary"
        href="#"
        rel="noopener noreferrer"
        target="_blank"
    +   type="button"
      >

Similar to rel, href should only be provided when Element is an a, and type should only be passed to buttons.

[anishagg17]

Changes have been made @chandlerprall

[anishagg17]

I have applied tests to target also

[chandlerprall]

Good catch, moving target as well.

Changes LGTM! Pulled & tested locally, including TypeScript error/feedback when trying to pass button attributes & a attributes at invalid times.