converts EuiForm (and family) to TypeScript#2896
converts EuiForm (and family) to TypeScript#2896chandlerprall merged 14 commits intoelastic:masterfrom
Conversation
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
src/components/form/form_control_layout/form_control_layout_delimited.tsx
Show resolved
Hide resolved
|
Thanks again for the PR. We'll mostly be silent over the weekend, but will give this a review on Monday. |
There was a problem hiding this comment.
Thanks for another detailed & thorough conversion!
src/components/form/form.test.tsz was renamed with an invalid file extension
Reviewed most of the changes; left the form vs. div prop stuff until that conversation & decision happens.
Have not thoroughly reviewed changes to exports, as there is a request to decrease the scope of some of those.
39c1833 to
114c272
Compare
|
fixed Otherwise, I think I've addressed all other feedback and just need some direction on what/how you want to be exported. I know with this kind of thing (since I've now exported everything it'll be literally just deleting single lines in the various |
chandlerprall
left a comment
There was a problem hiding this comment.
Everything's looking great! Please reset those extra exports and I'll do one last check of the build/eui.d.ts.
c27837e to
d04d8d5
Compare
form error text
1711df6 to
eae3242
Compare
|
@chandlerprall see #2896 (comment) and #2896 (comment), but otherwise I think we're all set here 😃! |
chandlerprall
left a comment
There was a problem hiding this comment.
Changes LGTM; pulled & tested locally, including impact to eui.d.ts which removes some previously exported values that were never exported on the JS side (bugfix).
closes: #2892