Conversation
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_2935/ |
|
I mentioned in slack that we'd like to not add more third-party logos if possible since EuiIcon can support custom SVG's. Also, I've checked these on a non-retina screen and while the new Other than that, the designs of the icons look great. My only other thought goes towards naming. I'd propose the following:
|
|
Thanks for the comments, @cchaos!
Ah, sorry about that. I've removed it and will notify my engineers to use a custom SVG.
Yeah, I noticed that when repurposing the older folder icons. I've updated both the new and old folder icons to sit better on the pixel grid.
All updated, per your recommendations. Thanks, again! |
cchaos
left a comment
There was a problem hiding this comment.
Thanks for making those changes! Just waiting for the build to test visually again. Found a quick issue with the CL
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_2935/ |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_2935/ |

Summary
Added new icons to EUI to support the needs of the upcoming SIEM case workflow integration feature. Including the following icons:
- logoServicenowIssue
Checklist
- [ ] Checked in mobile- [ ] Props have proper autodocs- [ ] Checked for breaking changes and labeled appropriately- [ ] Checked for accessibility including keyboard-only and screenreader modes