Convert EuiSearchBar to TypeScript by pugnascotia · Pull Request #2909 · elastic/eui

pugnascotia · 2020-02-24T17:22:13Z

Convert EuiSearchBar to TypeScript.

Also:

Add a .ignore file so that ripgrep ignores the docs bundle.
Fix type:whatever searches in the docs
Fix grammatical errors and an NPE in the docs

…h-bar-to-ts

kibanamachine · 2020-02-24T17:43:43Z

Preview documentation changes for this PR: https://eui.elastic.co/pr_2909/

…h-bar-to-ts

pugnascotia · 2020-02-28T15:00:30Z

I've merged in master. Any chance of a review?

kibanamachine · 2020-02-28T15:19:13Z

Preview documentation changes for this PR: https://eui.elastic.co/pr_2909/

chandlerprall

Thanks again for taking this on! ❤️

Some questions, couple definite suggestions.

src/components/basic_table/in_memory_table.tsx

src/components/search_bar/query/ast_to_es_query_dsl.ts

.ignore

src/components/search_bar/query/operators.ts

src/components/search_bar/search_bar.tsx

src/components/search_bar/search_box.tsx

…h-bar-to-ts

pugnascotia · 2020-03-01T11:47:54Z

@chandlerprall back to you for re-review.

kibanamachine · 2020-03-01T12:06:21Z

Preview documentation changes for this PR: https://eui.elastic.co/pr_2909/

chandlerprall

Thanks! Found two more, after which I'll test these all of this against the existing usages in Kibana.

src/components/search_bar/search_filters.tsx

src/components/search_bar/filters/field_value_selection_filter.tsx

pugnascotia · 2020-03-01T16:32:15Z

@chandlerprall back to you! 🏸

kibanamachine · 2020-03-01T16:59:35Z

Preview documentation changes for this PR: https://eui.elastic.co/pr_2909/

chandlerprall

Did a Kibana pass using these types which found a couple things around onChange

src/components/search_bar/search_bar.tsx

…h-bar-to-ts

kibanamachine · 2020-03-05T12:00:05Z

Preview documentation changes for this PR: https://eui.elastic.co/pr_2909/

chandlerprall

Couple more changes requested then this is great to go.

src/components/search_bar/query/query.ts

src/components/search_bar/index.ts

…h-bar-to-ts

pugnascotia · 2020-03-06T14:43:25Z

@chandlerprall back to you. I also defined a Syntax type.

kibanamachine · 2020-03-06T15:00:52Z

Preview documentation changes for this PR: https://eui.elastic.co/pr_2909/

chandlerprall

Good to go; Thanks @pugnascotia for taking this on!

pugnascotia added 6 commits February 24, 2020 13:26

First pass at TS conversion

bfe558a

Tweaks

0bab4d4

Revert table test fixes

5c22b45

Docs fixes

f0a0bba

Update changelog

cebb15f

Merge remote-tracking branch 'upstream/master' into convert-eui-searc…

3a0c2b3

…h-bar-to-ts

pugnascotia added the typescript label Feb 24, 2020

pugnascotia requested review from chandlerprall and thompsongl February 24, 2020 17:22

Merge remote-tracking branch 'upstream/master' into convert-eui-searc…

b81ed87

…h-bar-to-ts

chandlerprall suggested changes Feb 28, 2020

View reviewed changes

chandlerprall reviewed Feb 28, 2020

View reviewed changes

src/components/search_bar/search_box.tsx Outdated Show resolved Hide resolved

pugnascotia added 2 commits March 1, 2020 11:42

Address review feedback

a8a0f28

Merge remote-tracking branch 'upstream/master' into convert-eui-searc…

b39eea9

…h-bar-to-ts

Remove .ignore

5620510

chandlerprall suggested changes Mar 1, 2020

View reviewed changes

src/components/search_bar/search_filters.tsx Outdated Show resolved Hide resolved

src/components/search_bar/filters/field_value_selection_filter.tsx Outdated Show resolved Hide resolved

Make defaultProps types explicit

f9e1d5e

chandlerprall suggested changes Mar 4, 2020

View reviewed changes

src/components/search_bar/search_bar.tsx Outdated Show resolved Hide resolved

pugnascotia added 2 commits March 5, 2020 11:37

Use types to enforce onChange argument contract

3eae2da

Merge remote-tracking branch 'upstream/master' into convert-eui-searc…

70ec407

…h-bar-to-ts

chandlerprall suggested changes Mar 5, 2020

View reviewed changes

src/components/search_bar/query/query.ts Outdated Show resolved Hide resolved

chandlerprall suggested changes Mar 5, 2020

View reviewed changes

src/components/search_bar/index.ts Outdated Show resolved Hide resolved

pugnascotia added 2 commits March 6, 2020 14:40

Make _AST public, define Syntax type, export EuiSearchBarProps

f2f4853

Merge remote-tracking branch 'upstream/master' into convert-eui-searc…

053bdf5

…h-bar-to-ts

chandlerprall approved these changes Mar 6, 2020

View reviewed changes

pugnascotia merged commit 63739a6 into elastic:master Mar 6, 2020

pugnascotia deleted the convert-eui-search-bar-to-ts branch March 6, 2020 15:37

thompsongl mentioned this pull request Mar 12, 2020

EuiSearchBar needs to be converted to TypeScript #2753

Closed

chandlerprall mentioned this pull request Mar 16, 2020

Upgrade EUI to 21.0.1 elastic/kibana#60282

Merged

Conversation

pugnascotia commented Feb 24, 2020

Uh oh!

kibanamachine commented Feb 24, 2020

Uh oh!

pugnascotia commented Feb 28, 2020

Uh oh!

kibanamachine commented Feb 28, 2020

Uh oh!

chandlerprall left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

pugnascotia commented Mar 1, 2020

Uh oh!

kibanamachine commented Mar 1, 2020

Uh oh!

chandlerprall left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

pugnascotia commented Mar 1, 2020

Uh oh!

kibanamachine commented Mar 1, 2020

Uh oh!

chandlerprall left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

kibanamachine commented Mar 5, 2020

Uh oh!

chandlerprall left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

pugnascotia commented Mar 6, 2020

Uh oh!

kibanamachine commented Mar 6, 2020

Uh oh!

chandlerprall left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

chandlerprall left a comment •

edited

Loading