Better guarantee that a popover position can be found#2948
Merged
chandlerprall merged 2 commits intoelastic:masterfrom Feb 28, 2020
Merged
Better guarantee that a popover position can be found#2948chandlerprall merged 2 commits intoelastic:masterfrom
chandlerprall merged 2 commits intoelastic:masterfrom
Conversation
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_2948/ |
snide
approved these changes
Feb 28, 2020
Contributor
snide
left a comment
snide
left a comment
There was a problem hiding this comment.
Confirmed this by checking popovers that were causing problems and by making sure our other popovers still work as expected. Functionally LGTM.
cchaos
approved these changes
Feb 28, 2020
Contributor
cchaos
left a comment
cchaos
left a comment
There was a problem hiding this comment.
💯 Works for me. I tested locally in Chrome and in all the themes (0 border panels) and even removed all content from the context menu and it still rendered. Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a bug described in #2874 (comment)
The context menu's first render pass does not include any content, only the wrapping DOM. With a border, that DOM's height is 2*borderWidth and no border means no height. No height means the content isn't displayable, and the popover service errors out. This PR changes the service to be more lenient in these cases.
Checklist
- [ ] Check against all themes for compatibility in both light and dark modes- [ ] Checked in mobile- [ ] Checked in IE11 and Firefox- [ ] Props have proper autodocs- [ ] Added documentation examples- [ ] Added or updated jest tests- [ ] Checked for accessibility including keyboard-only and screenreader modes