Fixed data grid break on invalid schema#2955
Merged
chandlerprall merged 3 commits intoelastic:masterfrom Mar 2, 2020
Merged
Conversation
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
chandlerprall
suggested changes
Mar 1, 2020
Contributor
chandlerprall
left a comment
chandlerprall
left a comment
There was a problem hiding this comment.
Everything looks good, though I've requested a fix for the isSortable logic that I got wrong.
Contributor
Author
|
@chandlerprall Changes updated. Can you please review it? |
chandlerprall
approved these changes
Mar 2, 2020
Contributor
chandlerprall
left a comment
chandlerprall
left a comment
There was a problem hiding this comment.
Changes LGTM! Pulled & tested locally
Thanks again @ashikmeerankutty
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2949
Fixed Data grid break on invalid schema
Checklist