Added isSortable to Datagrid columns

[ashikmeerankutty]

Summary

Fixes #2950

Checklist

• Check against all themes for compatibility in both light and dark modes
• Checked in mobile
• Checked in IE11 and Firefox
• Props have proper autodocs
• Added documentation examples
• Added or updated jest tests
• Checked for breaking changes and labeled appropriately
• Checked for accessibility including keyboard-only and screenreader modes
• A changelog entry exists and is marked appropriately

[kibanamachine]

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

[chandlerprall]

Thanks for this! Two things:

• needs to have an entry added to the top of CHANGELOG.md describing the additional feature and linking to this PR
• please add the same optional isSortable flag to EuiDataGridSchemaDetector and also check for its presence in column_sorting - if either is set to false then the column should not be sortable. Similar logic to

  eui/src/components/datagrid/column_sorting.tsx

  Lines 217 to 225 in 76d4435

  	iconType={
  	schema.hasOwnProperty(id) &&
  	schema[id].columnType != null
  	? getDetailsForSchema(
  	schemaDetectors,
  	schema[id].columnType
  	).icon
  	: 'tokenString'
  	}

Currently, most of these settings come from the schema detector definition, but that can be cumbersome to work with and we are going to move to columns overriding individual settings like isSortable.

[ashikmeerankutty]

@chandlerprall I have updated the changes you have suggested. Can you please review the changes.

[chandlerprall]

Changes look good, just one thing to clean up

eui/src/components/datagrid/column_sorting.tsx

Line 168 in 95c090c

{inactiveColumns.length > 0 && (

needs to be updated to consider the length of sortable columns, otherwise the Pick fields to sort by UI can end up as an empty drop down instead of removed from the window.

To help consolidate the new logic, it's probably best to create a new array (e.g. inactiveSortableColumns or similar) based on the isSortable props, and use that array when rendering choices and showing/hiding selection popover.

[ashikmeerankutty]

@chandlerprall Changes updated. Can you please review?

[chandlerprall]

jenkins test this

[chandlerprall]

Schema detector test at

eui/src/components/datagrid/data_grid.test.tsx

Lines 907 to 920 in 9bc89c0

	schemaDetectors={[
	{
	type: 'ipaddress',
	detector(value: string) {
	return value.match(/\d{1,3}\.\d{1,3}\.\d{1,3}\.\d{1,3}/)
	? 1
	: 0;
	},
	icon: 'alert',
	color: 'primary',
	sortTextAsc: 'a-z',
	sortTextDesc: 'z-a',
	},
	]}

needs isSortable: true

[chandlerprall]

Sorry for the back-and-forth - should be the last 2 items, then I'll merge this in.

[ashikmeerankutty]

@chandlerprall No problem. Can you please review it?

[chandlerprall]

jenkins test this

[kibanamachine]

Preview documentation changes for this PR: https://eui.elastic.co/pr_2952/

[chandlerprall]

LGTM! Pulled & tested locally.