Workflow v3 transitions #66
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # administrator/language/en-GB/en-GB.xml # administrator/language/en-GB/install.xml # administrator/manifests/files/joomla.xml # administrator/manifests/packages/pkg_en-GB.xml # installation/language/en-GB/en-GB.xml # language/en-GB/en-GB.xml # language/en-GB/install.xml # libraries/src/Version.php
Adds file extension check to prevent issues when logo is not SVG.
These two menu items - Compact list of all tags - Tagged items have an option to select the content type. This is a multiselect field so should be using the fancy-select layout for the list and not the regular list
removes reference to a description
3.9.16 merge
* Remove workflow from com_content frontend * Remove workflow from content helper * Remove workflow from modules * Remove workflow from plugin pagenavigation
… PostgreSQL (PDO) (joomla#28338) * Fix new database installation for MySQL (PDO) When using MySQL (PDO) and having a user who has privileges to create a database, skip checks which will later be done in the database model. * Fix new database installation for PostgreSQL (PDO) Use the "postgres" database for the alternative driver and check for the right exception messages when using PostgreSQL (PDO). * Fix comment and remove obsolete postgresql driver handling
* Fixing tests in media manager * Fixing more media tests * Changing selector... * Adding delays * And further tweaking... * Changing selector and wait times * Extending wait times * Change method to close the system message * And the next test...
* Upgrade composer versions. Last framework packages to 2.0 * Add back property removed * More version updates * Fix php versions * webdriver, phpbrowser and db codeception modules * Fix html filter arguments * Change expected failure exception
* Remove more conditions Load transition field if component uses WorkflowModelTrait * Revert publish method to Joomla! 3 version and add workflow plugin group * Fix spelling error * Execute transition if selected in the item Add before/after item save for workflow
# Conflicts: # administrator/components/com_content/tmpl/articles/default.php # administrator/components/com_content/tmpl/featured/default.php
The category select is a multiple so it should be using the correct layout
If you look at the readmore link of an article in a blog view you will see it has an aria label of "read more: articletitle" But when you add a custom readmore text you only get an aria label of "articletitle" instead of the expected "customreadmore: articletitle"
Removes the duplicated classes and the erroneous border 0 which prevents the spacer hr being displayed
* Fix workflow batch
# Conflicts: # modules/mod_stats/src/Helper/StatsHelper.php
* Remove condition from workflow component * Load Workflow plugins on transition generation * First commit for the publishing plugin * Prevent saving of publishing state if workflow + plugin is active and the function is supported * Only enhance transition form, if plugin is supported * Add options field for transition plugins Fix support check for workflow publishing plugin * Set transition default values when creating a new workflow * Make publishing plugin support name generic * Allow to kill transition execution * Add missing variable assignment to kill transitions * Prevent state change on publish events * Implement finished version of the publishing plugin which now changes states of items Fix wrong contexts * Update the workflow model interface to respect all methods Secure controller execution for runTransition * Implement frontend transition with the new plugin method
Make transition execution more generic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue # .
Summary of Changes
Testing Instructions
Expected result
Actual result
Documentation Changes Required