-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[4.0][api][com_users] - Add filter options #28451
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
send a 400 response if date filter value is unsupported
silly me cause is doubled Co-Authored-By: Quy <[email protected]>
thx Co-Authored-By: Quy <[email protected]>
|
I have tested this item ✅ successfully on 893d051 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28451. |
|
I have tested this item 🔴 unsuccessfully on 893d051 return the same list of users
returns a list of users who have the registration date Same list of 3 users is given from This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28451. |
|
The example is incorrect. |
|
See comment in testing instructions:
|
|
thanks @Quy updated the Testing Instructions |
This too please. |
Should be integer. |
|
I have tested this item ✅ successfully on 893d051 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28451. |
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28451. |
Refactor to use full date searches
|
this needs to be retested
|
|
I have tested this item 🔴 unsuccessfully on c11fd11 This example output the users: This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28451. |
|
I have tested this item 🔴 unsuccessfully on c11fd11 JROOT_URL/api/index.php/v1/users?filter[lastVisitDateStart]=2020-01-29T20:36:01Z work if JROOT_URL/api/index.php/v1/users?filter[lastVisitStartDate]=2020-01-29T20:36:01Z idem for This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28451. |
|
we have had a live debug sesion with the help of @Razzo1987 |
|
I have tested this item ✅ successfully on 8e1c0e5 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28451. |
|
I have tested this item ✅ successfully on 8e1c0e5 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28451. |
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28451. |
|
Thanks! |

Summary of Changes
added the option to filter users by:
Testing Instructions
call
JROOT_URL/api/index.php/v1/users?filter[groupid]=8call
JROOT_URL/api/index.php/v1/users?filter[lastVisitDateStart]=2020-01-29T20:36:01Zcall
JROOT_URL/api/index.php/v1/users?filter[search]=myNamecall
JROOT_URL/api/index.php/v1/users?filter[state]=0call
JROOT_URL/api/index.php/v1/users?filter[active]=1call
JROOT_URL/api/index.php/v1/users?filter[registrationDateStart]=2018-01-29T20:36:01Zcall
JROOT_URL/api/index.php/v1/users?filter[registrationDateEnd]=2020-01-29T20:36:01Zor any combination like :
JROOT_URL/api/index.php/v1/users?filter[groupid]=8&filter[state]=0etc
Expected values for registrationDateStart , registrationDateEnd and lastVisitDateStart,lastVisitDateEnd are:
2020-03-29T20:36:01Z
2020-03-29T20:36:01+00:00
Expected result
the api response is filtered
Actual result
N/A
Documentation Changes Required
yes