Skip to content

Conversation

@alikon
Copy link
Contributor

@alikon alikon commented Apr 18, 2020

Pull Request for Issue #28717 .

Summary of Changes

removed join with the workflows table

Testing Instructions

#28717

Expected result

works as admin module

Actual result

don't work

@richard67
Copy link
Member

I have tested this item ✅ successfully on 60f1572


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28723.

1 similar comment
@jwaisner
Copy link
Member

I have tested this item ✅ successfully on 60f1572


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28723.

@jwaisner
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28723.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Apr 18, 2020
@infograf768 infograf768 merged commit 871fe58 into joomla:4.0-dev Apr 19, 2020
@joomla-cms-bot joomla-cms-bot added PR-4.0-dev and removed RTC This Pull Request is Ready To Commit labels Apr 19, 2020
@infograf768
Copy link
Member

tks

@infograf768 infograf768 added this to the Joomla 4.0 milestone Apr 19, 2020
@alikon alikon deleted the patch-109 branch April 19, 2020 08:09
@brianteeman
Copy link
Contributor

I am not convinced simply removing the workflow stuff is correct - it must have been put there for a reason

@richard67
Copy link
Member

@brianteeman As far as I remember the workflow stuff here was the remainder of an intermediate phase of development which was later rolled back so that state column of the #__content table was used again, but I might be wrong, so it would be cool if @bembelimen could have a look and comment.

@bembelimen
Copy link
Contributor

The state column is still there for B/C reasons, but is general ignored. I don't care, if the clean version (join over WF) or the state-version is used. I guess the state field will never disappear, so it doesn't matter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants