Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #28226.
Summary of Changes
Adds file extension check to prevent issues when logo is not SVG.
Testing Instructions
node build.js --compile-jsrequired.Edit Atum template style.
Select a logo.
Inspect browser console.
Expected result
No errors.
Actual result
Documentation Changes Required
No.
Additional Comments
I've picked what I think is the cleanest approach as it avoids unnecessary request when image is not SVG. It's somewhat limiting (the file doesn't need to have an extension) but works for our case. Alternatively, we could make the request but wrap it in try/catch or try to figure out the response some other way.