Skip to content

Conversation

@ciar4n
Copy link
Contributor

@ciar4n ciar4n commented Apr 11, 2020

Pull Request for Issue #28648, #28461, #23451.

Summary of Changes

Rewrites choices CSS

  • Reduced CSS
  • Simplifies styling
  • Removes 'Press to Select' text
  • Matches style with non choices select fields
  • Removes placholder text if 1+ item selected.

Testing Instructions

Apply this patch and run node build.js --compile-css for updating the changed SCSS. Check choices select fields (searchtools / new article -> category)

Before

image
image

After

image
image

@alikon
Copy link
Contributor

alikon commented Apr 11, 2020

not sure if my test cover what you have fixed here anyway
i'm in com_modules
selecting some of those and then click on batch and then look at Set Position
Screenshot from 2020-04-11 22-08-42

@ciar4n
Copy link
Contributor Author

ciar4n commented Apr 11, 2020

@alikon I believe that issue always existed. The same modal before this PR...

image

Possibly related to #28196

@richard67
Copy link
Member

I have tested this item ✅ successfully on e8a0de7


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28658.

@richard67
Copy link
Member

I've tested also RTL ... I hope I haven't missed anything. Maybe @infograf768 could test, too, so we can be sure it is ok for RTL?

@brianteeman
Copy link
Contributor

The things I tried to fix in #28461 are not fixed/included

  1. The radius of the corners is different
  2. the color of the text is different

image

  1. The focus ring is different

image

Is this intended
image

@richard67
Copy link
Member

Seems I need glasses.

@richard67
Copy link
Member

I have not tested this item.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28658.

@ciar4n
Copy link
Contributor Author

ciar4n commented Apr 11, 2020

@brianteeman Should be fine now (267c7fa).

@brianteeman
Copy link
Contributor

border radius and focus all good now.

The text color is still different
for choices it is the placeholder that needs to be changed
image

@ciar4n
Copy link
Contributor Author

ciar4n commented Apr 11, 2020

What browser are you using?.. color is the same but browser style applying opacity. Thought i reset it but obviously not.

@brianteeman
Copy link
Contributor

chrome on windows

@ciar4n
Copy link
Contributor Author

ciar4n commented Apr 11, 2020

Thx. I'll check again in the morn.

@infograf768
Copy link
Member

I guess should also be tested with Cassiopea

@ciar4n
Copy link
Contributor Author

ciar4n commented Apr 12, 2020

Placeholder color should be now correct.

All current changes are only made in Atum

@brianteeman
Copy link
Contributor

awesome sauce - i can confirm the placeholder is correct now

@wilsonge wilsonge merged commit 8e8a7f0 into joomla:4.0-dev Apr 12, 2020
@wilsonge
Copy link
Contributor

Thankyou very much @ciar4n !!

@wilsonge wilsonge added this to the Joomla 4.0 milestone Apr 12, 2020
@ciar4n ciar4n deleted the choices-style branch April 12, 2020 19:38
@infograf768
Copy link
Member

@ciar4n
See glip chat for RTL correction.

@ciar4n
Copy link
Contributor Author

ciar4n commented Apr 13, 2020

@infograf768 PR created... #28676

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants