-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[4.0][Atum] Choices CSS rewrite #28658
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I have tested this item ✅ successfully on e8a0de7 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28658. |
|
I've tested also RTL ... I hope I haven't missed anything. Maybe @infograf768 could test, too, so we can be sure it is ok for RTL? |
|
The things I tried to fix in #28461 are not fixed/included
|
|
Seems I need glasses. |
|
I have not tested this item. This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28658. |
|
@brianteeman Should be fine now (267c7fa). |
|
What browser are you using?.. color is the same but browser style applying opacity. Thought i reset it but obviously not. |
|
chrome on windows |
|
Thx. I'll check again in the morn. |
|
I guess should also be tested with Cassiopea |
|
Placeholder color should be now correct. All current changes are only made in Atum |
|
awesome sauce - i can confirm the placeholder is correct now |
|
Thankyou very much @ciar4n !! |
|
@ciar4n |
|
@infograf768 PR created... #28676 |






Pull Request for Issue #28648, #28461, #23451.
Summary of Changes
Rewrites choices CSS
Removes placholder text if 1+ item selected.Testing Instructions
Apply this patch and run
node build.js --compile-cssfor updating the changed SCSS. Check choices select fields (searchtools / new article -> category)Before
After