Skip to content

Conversation

@Quy
Copy link
Contributor

@Quy Quy commented Nov 26, 2019

Pull Request for Issue #26705.

Summary of Changes

When changing the article state, fix dropdown icon from disappearing.

Testing Instructions

  • Go to Articles.
  • Click on Published icon, then open the dropdown icon disappears.

Expected result

67145869-d4c7d300-f2a2-11e9-9b0e-2168ba23f5cd

Actual result

67145892-18224180-f2a3-11e9-8e60-f22ac79ff4bd

@infograf768
Copy link
Member

As far as I can see there is no difference here concerning the icon.
The icon always display before clicking on it, whatever the class change, and then disappears because the dropdown is displayed over it.
The wrong aspect of this PR is that it is creating a vertical scrollbar as paddings are lost.

@Quy
Copy link
Contributor Author

Quy commented Nov 29, 2019

See screenshots. They look the same. I don't see where paddings are lost.

27164-before

27164-after

@brianteeman
Copy link
Contributor

@Quy the form.control class ??

@Quy
Copy link
Contributor Author

Quy commented Nov 29, 2019

These classes are overriden.

27164

@infograf768
Copy link
Member

One can see the scrollbar issue when clicking on the arrow and the drodown displays

@Quy
Copy link
Contributor Author

Quy commented Nov 29, 2019

Sorry I must be blind as I don't see what you are seeing.

27164

@infograf768
Copy link
Member

Firefox Macintosh

before your patch
dropdownbefore

After your patch
dropdown

Browser issue?

@Quy
Copy link
Contributor Author

Quy commented Dec 6, 2019

Notice in your Before screenshot that the dropdown with yellow highlight in the After screenshot is also in the Before screenshot before the grey drop down displays over it. It could be a browser issue. Do you have another browser to test?

@infograf768
Copy link
Member

Got same behavior on Chrome and Safari here on Macintosh except no scrollbar after your patch.
Screen Shot 2019-12-06 at 07 54 18

@Quy
Copy link
Contributor Author

Quy commented Jan 26, 2020

It is correct to have no scroll bar. Do you get the yellow highlight in other drop downs like the language dropdown on the first installation page?

@Quy
Copy link
Contributor Author

Quy commented Mar 12, 2020

@infograf768 Can you please test again to see if it ok now with the new template? Does it behave the same as the other dropdowns on this page?

@infograf768
Copy link
Member

will test tomorrow

@N6REJ
Copy link
Contributor

N6REJ commented Mar 12, 2020

I don't even see the issue using this morning's pull

image

@Quy
Copy link
Contributor Author

Quy commented Mar 12, 2020

You should see the blue background.

27164

@richard67
Copy link
Member

richard67 commented Mar 12, 2020

I can reproduce the issue and confirm the PR solves it.

@infograf768 I don't have the scrollbar issue, neither with LTR nor with RTL.

@richard67
Copy link
Member

I have tested this item ✅ successfully on 5691021

I can reproduce the issue, PR solves it for me with both LTR and RTL. If it's right or wrong I can't judge.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27164.

@brianteeman
Copy link
Contributor

issue replicated and patch resolves


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27164.

@brianteeman
Copy link
Contributor

I have tested this item ✅ successfully on 5691021


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27164.

@richard67
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27164.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Mar 12, 2020
@infograf768
Copy link
Member

Sorry to say, but on Macintosh clean install I still have the wrong behavior...
here with Firefox, after patch.
arrow

@richard67
Copy link
Member

@inograf768 I used latest version of Firefox, but on Windows. So what shall we do now? Remove RTC?

@brianteeman
Copy link
Contributor

That is a native browser display you are seeing. Nothing can be done about that.

@infograf768
Copy link
Member

I have a similar behavior for safari and chrome on Macintosh as I stated before.

@infograf768
Copy link
Member

It may be of interest to see the behavior for other fields:

arrow2

As one can see, the arrow and dropdown works perfectly for ordering and limit

@Quy
Copy link
Contributor Author

Quy commented Mar 13, 2020

You have the same issue with - Select Condition - which has nothing to do with this PR.

@infograf768
Copy link
Member

You have the same issue with - Select Condition - which has nothing to do with this PR.

Indeed. Do you keep the arrow for this field on your settings?

@Quy
Copy link
Contributor Author

Quy commented Mar 13, 2020

It displays fine on Windows. I will have to test on Mac later today and see if anything can be done unless you want to give it a shot first.

@infograf768
Copy link
Member

@Quy
Copy link
Contributor Author

Quy commented Mar 13, 2020

Can you give it a try in a separate PR as I have to ask a friend to get access to a Mac?

@Quy
Copy link
Contributor Author

Quy commented Mar 13, 2020

@wilsonge Please merge. The issue mentioned by JM is a separate issue and OSX specific. Thanks.

@wilsonge wilsonge merged commit bc7976e into joomla:4.0-dev Mar 13, 2020
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Mar 13, 2020
@wilsonge
Copy link
Contributor

But I use a macbook too :P clearly a high priority issue :P

Thankyou!

@wilsonge wilsonge added this to the Joomla 4.0 milestone Mar 13, 2020
@Quy Quy deleted the 26705-dropdown branch March 13, 2020 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants