Skip to content

Conversation

@wilsonge
Copy link
Contributor

@wilsonge wilsonge commented Mar 15, 2020

Partial Pull Request for Issue #25490 .

Summary of Changes

  • Adds the class form-validate to various forms so that they are correctly used by the validator.
  • Adds the formvalidator javascript to the installer where we had the classes but not the JS
  • Removes the data-cancel-task attribute from com_config where we now no longer use core mvc and it follows the "normal" task pattern

Basically every form using the formvalidator behaviour is now associated with a form containing the form-validate class. (The password field additionally includes the behaviour without the class but that is outside the scope of the PR as the JS has a hard dependency)

Testing Instructions

Ensure form validation in forms continues to work especially in the forms affected in this PR

Documentation Changes Required

None

@wilsonge wilsonge changed the title Cleanup formvalidation behaviour [4.0] Cleanup formvalidation uses Mar 15, 2020
@chmst
Copy link
Contributor

chmst commented Mar 16, 2020

I have tested this item ✅ successfully on 9d3b8f5

All forms work as before, so it is successful test.
Validation itself does not work for numbers but this is not in scope of this PR.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28352.

@jwaisner
Copy link
Member

I have tested this item ✅ successfully on 9d3b8f5


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28352.

@jwaisner
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28352.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Mar 16, 2020
@wilsonge wilsonge merged commit 8cf9908 into joomla:4.0-dev Mar 16, 2020
@wilsonge
Copy link
Contributor Author

Cheers guys

@wilsonge wilsonge deleted the fix/javascript-validation-cleanup branch March 16, 2020 14:13
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Mar 16, 2020
@wilsonge wilsonge added this to the Joomla 4.0 milestone Mar 16, 2020
@brianteeman brianteeman mentioned this pull request Apr 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants