Skip to content

Conversation

@Hackwar
Copy link
Member

@Hackwar Hackwar commented Apr 14, 2020

The acceptance tests currently fail on the media manager tests, because a system message is overlapping the toolbar buttons, which Codeception is counting as a failure. This change adds an additional method that not only reads the system message, but also closes the dialog afterwards.

@Hackwar
Copy link
Member Author

Hackwar commented Apr 14, 2020

So just 9 commits later, this finally works. Please test and then lets get the tests working again for those other PRs...

@Hackwar Hackwar marked this pull request as ready for review April 14, 2020 20:17
@richard67
Copy link
Member

I have tested this item ✅ successfully on d1326ab

Logs of system tests in drone look complete, i.e. no tests missing compared to the past when tests were successful.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28681.

@HLeithner HLeithner merged commit c32276a into joomla:4.0-dev Apr 14, 2020
@HLeithner
Copy link
Member

Thanks

@HLeithner HLeithner added this to the Joomla! 3.9.17 milestone Apr 14, 2020
@Quy Quy modified the milestones: Joomla! 3.9.17, Joomla 4.0 Apr 14, 2020
@Hackwar Hackwar deleted the j4mediatests branch October 23, 2020 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants