Skip to content

Conversation

@zero-24
Copy link
Contributor

@zero-24 zero-24 commented Mar 11, 2020

Summary of Changes

fix notice in httpheaders plugin cc @wilsonge should be obvious on code review.

@Quy
Copy link
Contributor

Quy commented Mar 11, 2020

I get the following in the back end:

Warning: hash() expects parameter 2 to be string, array given in \plugins\system\httpheaders\httpheaders.php on line 165

@zero-24
Copy link
Contributor Author

zero-24 commented Mar 11, 2020

hmm it seams something different is happening here:

https://github.com/joomla/joomla-cms/blob/4.0-dev/plugins/system/httpheaders/httpheaders.php#L154-L178

That results into $scriptContent or $styleContent to be an array but i would like to keep that of for now. Can you please create an issue for that?

An fix could be to check that $scriptContent is an array and than do a loop over them to generate the hashes.

@Quy
Copy link
Contributor

Quy commented Mar 11, 2020

I have tested this item ✅ successfully on 7ea1950


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28318.

1 similar comment
@ChristineWk
Copy link

I have tested this item ✅ successfully on 7ea1950


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28318.

@Quy
Copy link
Contributor

Quy commented Mar 11, 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28318.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Mar 11, 2020
@Quy Quy added the PR-4.0-dev label Mar 11, 2020
@wilsonge wilsonge merged commit 01bd98a into joomla:4.0-dev Mar 11, 2020
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Mar 11, 2020
@wilsonge
Copy link
Contributor

Thanks!

@wilsonge wilsonge added this to the Joomla 4.0 milestone Mar 11, 2020
@zero-24 zero-24 deleted the notice branch March 15, 2020 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants