Skip to content

Conversation

@chmst
Copy link
Contributor

@chmst chmst commented Apr 17, 2020

Pull Request for Issue #28674 .

Summary of Changes

Remove position sidebar frmom com_config.

Testing Instructions

See issue #28674. Make a update from 3.10 to 4.0
In J4 this PR may not change anything in the backend.

Expected result

The updated site looks like a fresh installation of a J4 in com_config.
In J4.0 every view of com_config looks as before

Actual result

See issue #28674.

Documentation Changes Required

no

@brianteeman
Copy link
Contributor

I have tested this item ✅ successfully on 43f905e


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28699.

@Quy
Copy link
Contributor

Quy commented Apr 17, 2020

Please delete lines 12 & 16.

@Quy
Copy link
Contributor

Quy commented Apr 17, 2020

I have tested this item ✅ successfully on eace22a


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28699.

@Quy
Copy link
Contributor

Quy commented Apr 17, 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28699.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Apr 17, 2020
@wilsonge wilsonge merged commit ad74804 into joomla:4.0-dev Apr 17, 2020
@wilsonge
Copy link
Contributor

Thanks!

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Apr 17, 2020
@wilsonge wilsonge added this to the Joomla 4.0 milestone Apr 17, 2020
@chmst chmst deleted the sidebar-config-module branch April 19, 2020 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants