#257 - Merge Release v1.15.0 into main #3940
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### The following are achieved in this hotfix: - SIN Validation - Gender Field Limit (#3839) - SINF restriction bridge mapping and rename to SINR (#3846) - Virus Scanning - Not functioning PROD (#3854) - Modify process that reads SIN & CRA verification response files (#3835) - Hotfix: Bulk uploads: Unexpected error while uploading the file displays when "Validate" or "Create now" are selected for valid bulk upload - Virus Scanning - Empty File Check - Hotfix: Change file naming convention of the SIN validation request file - Hotfix: Fix for withdraw upload - Hotfix: Name change for CRA Response file - Parse the last 2 characters in NEB as decimal places - Update PTMSFAA File Name --------- Co-authored-by: Ashish <[email protected]> Co-authored-by: Andre Pestana <[email protected]> Co-authored-by: Lewis Chen <[email protected]> Co-authored-by: Andrew Boni Signori <[email protected]> Co-authored-by: Dheepak Ramanathan <[email protected]>
## Main PR Goal - Increase the log level at the `SFTPIntegrationBase` without disrupting the consumer's methods and try to limit the amount of refactoring. - Deploy to PROD in the next possible release to allow troubleshooting of current intermittent issues while archiving files. ### Changes - Adapted the `LoggerService.error` to receive a friendly error and log the error itself, keeping it compatible with the existing methods. - Added log messages to all base SFTP operations in the `SFTPIntegrationBase`. The errors are reshown keeping the current behavior for current method consumers. - Adjusted the API `mais.ts` that was using the log context. - Adjusted the global error handler to generate only one log entry instead of three. - Even though the `SFTPIntegrationBase` method is now generating more logs, the archive operation error handling was adjusted to ensure the exception details are logged. - Small refactor to stop passing the `SFTP_ARCHIVE_DIRECTORY` for every archive method.
) Fix issues from the previous PR for better logging. The main log from the SFTP base would still work but ensuring the logs are added to the Job in some way makes it easier for troubleshooting. The goal is to have all the methods following similar archive catch handling doing something closet to each other. See the example below of a sample that will display errors and `causes`. 
…#3903) - Upgrade the [ssh2-sftp-client to version 11.0.0](https://www.npmjs.com/package/ssh2-sftp-client). - Minor changes for the logging.
…rttime (#3913) **As a part of this PR, the scheduler `DisbursementReceiptsFileIntegration` is being enabled for Parttime.**
- Update the gender to have a white space as a default option. - Adjusted and created some E2E tests for e-Certs. - Adjusted MSFAA E2E that was already using "preferNotToAnswer". - SIN is using the same method from e-Cert and MSFAA.
Adjusted the CSL balance imported to have 2 decimals places.
- Masked the `totalFamilyIncome` following the same approach used to mask the MSFAA. - Masked only for public institutions. - The method used to format the money in the NOA UI when it is a number has no issues with the "masked" string.  ### Sample UI with the masked value 
|
Backend Unit Tests Coverage Report
|
E2E Workflow Workers Coverage Report
|
E2E Queue Consumers Coverage Report
|
E2E SIMS API Coverage Report
|
andrewsignori-aot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge Release v1.15 to Main
#260 - Merge Hotfix v1.14.1 into Release v1.15.0 (https://github.com/bcgov/SIMS/pull/3885[)]
#3889 - Increase Logging for SFTP and file handling (https://github.com/bcgov/SIMS/pull/3897[)]
#3889 - Increase Logging for SFTP and file handling - (Catch fix)
#3889 - Increase Logging for SFTP and file handling - SSH Lib Upgrade
#3912 [- Allow Disbursement Receipts File Integration Scheduler For Pa…]
#3924 [- Ecert Creation - "Prefer not to answer" Gender (]
#3922 [- PT Monthly Loan Balance - Update Balance (]
#3896 - Mask Institution User Income View (https://github.com/bcgov/SIMS/pull/3932[)]