Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#3831 - SINF restriction bridge mapping and rename to SINR #3846

Merged
merged 2 commits into from
Oct 30, 2024

Conversation

lewischen-aot
Copy link
Collaborator

@lewischen-aot lewischen-aot commented Oct 28, 2024

  • Changed restriction code SINF to SINR
  • Updated the activity page accordion code to SINR
  • Created a DB migration to change the code of the SINF to SINR.
  • Renamed SINF to SINR in the existing RestrictionCode enum.
  • Changed an existing E2E to ensure SINF will be mapped to LGCY.
    • Replaced "TREE" with "SINF" in file "SFAS-TO-SIMS-2024MAR07-LEGACY-RESTRICTIONS.txt" to ensure SINF mapping to LGCY for this PR.

Rollback evidence screenshot

image

Screenshot of the SINR code on the activity page accordion
image

Screenshot of the sfas_student table having two records after restrictions are imported
image

Screenshot of the student_restrictions table having only one record with restriction_id = 72 (LGCY)
image

Screenshot of the completed job for processing the SINR record on Bull Dashboard
image

@lewischen-aot lewischen-aot self-assigned this Oct 28, 2024
@lewischen-aot lewischen-aot added DB DB migration involved Web portal Form.io Form IO definitions changed. labels Oct 29, 2024
@lewischen-aot lewischen-aot marked this pull request as ready for review October 29, 2024 19:48
@dheepak-aot dheepak-aot self-requested a review October 29, 2024 20:26
@dheepak-aot
Copy link
Collaborator

Nice work @lewischen-aot. Please take a look at the comments.

Copy link
Collaborator

@andrepestana-aot andrepestana-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there was a misunderstanding about the SINF if imported will be treated as LGCY as any other unknown restriction. Please check it.

Copy link

Copy link

Backend Unit Tests Coverage Report

Totals Coverage
Statements: 22.35% ( 3692 / 16516 )
Methods: 10.33% ( 212 / 2053 )
Lines: 25.67% ( 3202 / 12475 )
Branches: 13.98% ( 278 / 1988 )

Copy link

E2E Workflow Workers Coverage Report

Totals Coverage
Statements: 65.43% ( 583 / 891 )
Methods: 59.26% ( 64 / 108 )
Lines: 68.54% ( 464 / 677 )
Branches: 51.89% ( 55 / 106 )

Copy link

E2E Queue Consumers Coverage Report

Totals Coverage
Statements: 84.53% ( 1197 / 1416 )
Methods: 85% ( 119 / 140 )
Lines: 85.53% ( 1017 / 1189 )
Branches: 70.11% ( 61 / 87 )

Copy link

E2E SIMS API Coverage Report

Totals Coverage
Statements: 66.01% ( 5571 / 8439 )
Methods: 63.3% ( 683 / 1079 )
Lines: 70.12% ( 4401 / 6276 )
Branches: 44.93% ( 487 / 1084 )

Copy link
Collaborator

@andrepestana-aot andrepestana-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for doing the changes.

Copy link
Collaborator

@dheepak-aot dheepak-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing the changes. Looks good 👍

@lewischen-aot lewischen-aot added this pull request to the merge queue Oct 30, 2024
Merged via the queue into main with commit 3ed8c2e Oct 30, 2024
20 checks passed
@lewischen-aot lewischen-aot deleted the feature/#3831-sinf-restriction-to-sinr branch October 30, 2024 19:18
dheepak-aot pushed a commit that referenced this pull request Oct 30, 2024
- Changed restriction code `SINF` to `SINR`
- Updated the activity page accordion code to `SINR`
- Created a DB migration to change the code of the `SINF` to `SINR`.
- Renamed `SINF` to `SINR` in the existing `RestrictionCode` enum.
- Changed an existing E2E to ensure `SINF` will be mapped to `LGCY`. 
- Replaced "TREE" with "SINF" in file
"SFAS-TO-SIMS-2024MAR07-LEGACY-RESTRICTIONS.txt" to ensure `SINF`
mapping to `LGCY` for this PR.

### Rollback evidence screenshot

![image](https://github.com/user-attachments/assets/2002ad83-4af3-4ab5-9b9c-3226e02b28e8)

Screenshot of the SINR code on the activity page accordion

![image](https://github.com/user-attachments/assets/c1b4028c-c92b-447a-b417-a10fc8c75f04)

Screenshot of the `sfas_student` table having two records after
restrictions are imported

![image](https://github.com/user-attachments/assets/1b0d2812-3944-4a15-9641-fabe894cbcf4)

Screenshot of the `student_restrictions` table having only one record
with restriction_id = 72 (LGCY)

![image](https://github.com/user-attachments/assets/20e3396d-96db-4190-941a-9e597f945ba8)

Screenshot of the completed job for processing the SINR record on Bull
Dashboard

![image](https://github.com/user-attachments/assets/50db6edd-3070-4e25-80c3-db1ff1a60be0)
sh16011993 added a commit that referenced this pull request Nov 5, 2024
### The following are achieved in this hotfix:

- SIN Validation - Gender Field Limit
(#3839)
- SINF restriction bridge mapping and rename to SINR
(#3846)
- Virus Scanning - Not functioning PROD
(#3854)
- Modify process that reads SIN & CRA verification response files
(#3835)
- Hotfix: Bulk uploads: Unexpected error while uploading the file
displays when "Validate" or "Create now" are selected for valid bulk
upload
- Virus Scanning - Empty File Check
- Hotfix: Change file naming convention of the SIN validation request
file
- Hotfix: Fix for withdraw upload
- Hotfix: Name change for CRA Response file
- Parse the last 2 characters in NEB as decimal places
- Update PTMSFAA File Name

---------

Co-authored-by: Ashish <[email protected]>
Co-authored-by: Andre Pestana <[email protected]>
Co-authored-by: Lewis Chen <[email protected]>
Co-authored-by: Andrew Boni Signori <[email protected]>
Co-authored-by: Dheepak Ramanathan <[email protected]>
github-merge-queue bot pushed a commit that referenced this pull request Nov 5, 2024
### The following are the achieved in this hotfix:

- SIN Validation - Gender Field Limit
(#3839)
- SINF restriction bridge mapping and rename to SINR
(#3846)
- Virus Scanning - Not functioning PROD
(#3854)
- Modify process that reads SIN & CRA verification response files
(#3835)
- Hotfix: Bulk uploads: Unexpected error while uploading the file
displays when "Validate" or "Create now" are selected for valid bulk
upload
- Virus Scanning - Empty File Check
- Hotfix: Change file naming convention of the SIN validation request
file
- Hotfix: Fix for withdraw upload
- Hotfix: Name change for CRA Response file
- Parse the last 2 characters in NEB as decimal places
- Update PTMSFAA File Name

---------

Co-authored-by: Ashish <[email protected]>
Co-authored-by: Andre Pestana <[email protected]>
Co-authored-by: Lewis Chen <[email protected]>
Co-authored-by: Andrew Boni Signori <[email protected]>
Co-authored-by: Dheepak Ramanathan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants