-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#3831 - SINF restriction bridge mapping and rename to SINR #3846
Conversation
sources/packages/backend/apps/db-migrations/src/sql/Restrictions/Update-sin-restriction.sql
Outdated
Show resolved
Hide resolved
...ces/packages/backend/libs/src-sql/sfas-restrictions/Bulk-insert-sfas-mapped-restrictions.sql
Outdated
Show resolved
Hide resolved
...chedulers/sfas-integration/_tests_/sfas-files/SFAS-TO-SIMS-2024MAR07-LEGACY-RESTRICTIONS.txt
Outdated
Show resolved
Hide resolved
Nice work @lewischen-aot. Please take a look at the comments. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there was a misunderstanding about the SINF if imported will be treated as LGCY as any other unknown restriction. Please check it.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thanks for doing the changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing the changes. Looks good 👍
- Changed restriction code `SINF` to `SINR` - Updated the activity page accordion code to `SINR` - Created a DB migration to change the code of the `SINF` to `SINR`. - Renamed `SINF` to `SINR` in the existing `RestrictionCode` enum. - Changed an existing E2E to ensure `SINF` will be mapped to `LGCY`. - Replaced "TREE" with "SINF" in file "SFAS-TO-SIMS-2024MAR07-LEGACY-RESTRICTIONS.txt" to ensure `SINF` mapping to `LGCY` for this PR. ### Rollback evidence screenshot  Screenshot of the SINR code on the activity page accordion  Screenshot of the `sfas_student` table having two records after restrictions are imported  Screenshot of the `student_restrictions` table having only one record with restriction_id = 72 (LGCY)  Screenshot of the completed job for processing the SINR record on Bull Dashboard 
### The following are achieved in this hotfix: - SIN Validation - Gender Field Limit (#3839) - SINF restriction bridge mapping and rename to SINR (#3846) - Virus Scanning - Not functioning PROD (#3854) - Modify process that reads SIN & CRA verification response files (#3835) - Hotfix: Bulk uploads: Unexpected error while uploading the file displays when "Validate" or "Create now" are selected for valid bulk upload - Virus Scanning - Empty File Check - Hotfix: Change file naming convention of the SIN validation request file - Hotfix: Fix for withdraw upload - Hotfix: Name change for CRA Response file - Parse the last 2 characters in NEB as decimal places - Update PTMSFAA File Name --------- Co-authored-by: Ashish <[email protected]> Co-authored-by: Andre Pestana <[email protected]> Co-authored-by: Lewis Chen <[email protected]> Co-authored-by: Andrew Boni Signori <[email protected]> Co-authored-by: Dheepak Ramanathan <[email protected]>
### The following are the achieved in this hotfix: - SIN Validation - Gender Field Limit (#3839) - SINF restriction bridge mapping and rename to SINR (#3846) - Virus Scanning - Not functioning PROD (#3854) - Modify process that reads SIN & CRA verification response files (#3835) - Hotfix: Bulk uploads: Unexpected error while uploading the file displays when "Validate" or "Create now" are selected for valid bulk upload - Virus Scanning - Empty File Check - Hotfix: Change file naming convention of the SIN validation request file - Hotfix: Fix for withdraw upload - Hotfix: Name change for CRA Response file - Parse the last 2 characters in NEB as decimal places - Update PTMSFAA File Name --------- Co-authored-by: Ashish <[email protected]> Co-authored-by: Andre Pestana <[email protected]> Co-authored-by: Lewis Chen <[email protected]> Co-authored-by: Andrew Boni Signori <[email protected]> Co-authored-by: Dheepak Ramanathan <[email protected]>
SINF
toSINR
SINR
SINF
toSINR
.SINF
toSINR
in the existingRestrictionCode
enum.SINF
will be mapped toLGCY
.SINF
mapping toLGCY
for this PR.Rollback evidence screenshot
Screenshot of the SINR code on the activity page accordion

Screenshot of the

sfas_student
table having two records after restrictions are importedScreenshot of the

student_restrictions
table having only one record with restriction_id = 72 (LGCY)Screenshot of the completed job for processing the SINR record on Bull Dashboard
