#3831 - SINF restriction bridge mapping and rename to SINR #3846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lewischen-aot
added
DB
dheepak-aot
reviewed
Oct 29, 2024
sources/packages/backend/apps/db-migrations/src/sql/Restrictions/Update-sin-restriction.sql
Outdated
Show resolved
Hide resolved
dheepak-aot
reviewed
Oct 29, 2024
...ces/packages/backend/libs/src-sql/sfas-restrictions/Bulk-insert-sfas-mapped-restrictions.sql
Outdated
Show resolved
Hide resolved
dheepak-aot
reviewed
Oct 29, 2024
...chedulers/sfas-integration/_tests_/sfas-files/SFAS-TO-SIMS-2024MAR07-LEGACY-RESTRICTIONS.txt
Outdated
Show resolved
Hide resolved
|
Nice work @lewischen-aot. Please take a look at the comments. |
|
Backend Unit Tests Coverage Report
|
E2E Workflow Workers Coverage Report
|
E2E Queue Consumers Coverage Report
|
E2E SIMS API Coverage Report
|
andrepestana-aot
approved these changes
Oct 30, 2024
dheepak-aot
approved these changes
Oct 30, 2024
dheepak-aot
pushed a commit
that referenced
this pull request
Oct 30, 2024
- Changed restriction code `SINF` to `SINR` - Updated the activity page accordion code to `SINR` - Created a DB migration to change the code of the `SINF` to `SINR`. - Renamed `SINF` to `SINR` in the existing `RestrictionCode` enum. - Changed an existing E2E to ensure `SINF` will be mapped to `LGCY`. - Replaced "TREE" with "SINF" in file "SFAS-TO-SIMS-2024MAR07-LEGACY-RESTRICTIONS.txt" to ensure `SINF` mapping to `LGCY` for this PR. ### Rollback evidence screenshot  Screenshot of the SINR code on the activity page accordion  Screenshot of the `sfas_student` table having two records after restrictions are imported  Screenshot of the `student_restrictions` table having only one record with restriction_id = 72 (LGCY)  Screenshot of the completed job for processing the SINR record on Bull Dashboard 
This was referenced Nov 5, 2024
sh16011993
added a commit
that referenced
this pull request
Nov 5, 2024
### The following are achieved in this hotfix: - SIN Validation - Gender Field Limit (#3839) - SINF restriction bridge mapping and rename to SINR (#3846) - Virus Scanning - Not functioning PROD (#3854) - Modify process that reads SIN & CRA verification response files (#3835) - Hotfix: Bulk uploads: Unexpected error while uploading the file displays when "Validate" or "Create now" are selected for valid bulk upload - Virus Scanning - Empty File Check - Hotfix: Change file naming convention of the SIN validation request file - Hotfix: Fix for withdraw upload - Hotfix: Name change for CRA Response file - Parse the last 2 characters in NEB as decimal places - Update PTMSFAA File Name --------- Co-authored-by: Ashish <[email protected]> Co-authored-by: Andre Pestana <[email protected]> Co-authored-by: Lewis Chen <[email protected]> Co-authored-by: Andrew Boni Signori <[email protected]> Co-authored-by: Dheepak Ramanathan <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 5, 2024
### The following are the achieved in this hotfix: - SIN Validation - Gender Field Limit (#3839) - SINF restriction bridge mapping and rename to SINR (#3846) - Virus Scanning - Not functioning PROD (#3854) - Modify process that reads SIN & CRA verification response files (#3835) - Hotfix: Bulk uploads: Unexpected error while uploading the file displays when "Validate" or "Create now" are selected for valid bulk upload - Virus Scanning - Empty File Check - Hotfix: Change file naming convention of the SIN validation request file - Hotfix: Fix for withdraw upload - Hotfix: Name change for CRA Response file - Parse the last 2 characters in NEB as decimal places - Update PTMSFAA File Name --------- Co-authored-by: Ashish <[email protected]> Co-authored-by: Andre Pestana <[email protected]> Co-authored-by: Lewis Chen <[email protected]> Co-authored-by: Andrew Boni Signori <[email protected]> Co-authored-by: Dheepak Ramanathan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SINFtoSINRSINRSINFtoSINR.SINFtoSINRin the existingRestrictionCodeenum.SINFwill be mapped toLGCY.SINFmapping toLGCYfor this PR.Rollback evidence screenshot
Screenshot of the SINR code on the activity page accordion
Screenshot of the
sfas_studenttable having two records after restrictions are importedScreenshot of the
student_restrictionstable having only one record with restriction_id = 72 (LGCY)Screenshot of the completed job for processing the SINR record on Bull Dashboard
