#3924 - Ecert Creation - "Prefer not to answer" Gender #3927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
andrewsignori-aot
commented
Nov 13, 2024
•
andrewsignori-aot
commented
- Update the gender to have a white space as a default option.
- Adjusted and created some E2E tests for e-Certs.
- Adjusted MSFAA E2E that was already using "preferNotToAnswer".
- SIN is using the same method from e-Cert and MSFAA.
andrewsignori-aot
changed the title
|
Backend Unit Tests Coverage Report
|
E2E Workflow Workers Coverage Report
|
E2E Queue Consumers Coverage Report
|
E2E SIMS API Coverage Report
|
dheepak-aot
reviewed
Nov 13, 2024
| // Gender should have at least one character code. | ||
| // The default option as an empty space would represent | ||
| // the "Prefer not to answer"(preferNotToAnswer) option. | ||
| return " "; |
dheepak-aot
reviewed
Nov 13, 2024
| const recordParsed = new PartTimeCertRecordParser(record); | ||
| expect(recordParsed.recordType).toBe("02"); | ||
| expect(recordParsed.hasUser(student.user)).toBe(true); | ||
| expect(recordParsed.gender).toBe(" "); |
dheepak-aot
approved these changes
Nov 13, 2024
guru-aot
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.