#3833 - SIN Validation - Gender Field Limit #3839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guru-aot
approved these changes
Oct 25, 2024
dheepak-aot
reviewed
Oct 25, 2024
Comment on lines
3
to
6
| SET | ||
| gender_sent = NULL | ||
| WHERE | ||
| LENGTH(gender_sent) > 10; |
There was a problem hiding this comment.
Is it desired for rollback ? IMO, we must just do the alter statement.
If at all there is any need to rollback and there is data we need to handle, we can handle it manually.
There was a problem hiding this comment.
I would agree with @dheepak-aot. No values greater than 10 will be expected in any DB since they are not supported. The rollback script, if executed, should be executed at release time.
|
Backend Unit Tests Coverage Report
|
E2E Workflow Workers Coverage Report
|
E2E Queue Consumers Coverage Report
|
E2E SIMS API Coverage Report
|
dheepak-aot
approved these changes
Oct 25, 2024
dheepak-aot
pushed a commit
that referenced
this pull request
Oct 30, 2024
Altered sims.sin_validations.gender_sent to be VARCHAR(50). Tested with a pending SIN Validation:  After running sin-validation-process-integration:  Revert: 
This was referenced Nov 5, 2024
sh16011993
added a commit
that referenced
this pull request
Nov 5, 2024
### The following are achieved in this hotfix: - SIN Validation - Gender Field Limit (#3839) - SINF restriction bridge mapping and rename to SINR (#3846) - Virus Scanning - Not functioning PROD (#3854) - Modify process that reads SIN & CRA verification response files (#3835) - Hotfix: Bulk uploads: Unexpected error while uploading the file displays when "Validate" or "Create now" are selected for valid bulk upload - Virus Scanning - Empty File Check - Hotfix: Change file naming convention of the SIN validation request file - Hotfix: Fix for withdraw upload - Hotfix: Name change for CRA Response file - Parse the last 2 characters in NEB as decimal places - Update PTMSFAA File Name --------- Co-authored-by: Ashish <[email protected]> Co-authored-by: Andre Pestana <[email protected]> Co-authored-by: Lewis Chen <[email protected]> Co-authored-by: Andrew Boni Signori <[email protected]> Co-authored-by: Dheepak Ramanathan <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 5, 2024
### The following are the achieved in this hotfix: - SIN Validation - Gender Field Limit (#3839) - SINF restriction bridge mapping and rename to SINR (#3846) - Virus Scanning - Not functioning PROD (#3854) - Modify process that reads SIN & CRA verification response files (#3835) - Hotfix: Bulk uploads: Unexpected error while uploading the file displays when "Validate" or "Create now" are selected for valid bulk upload - Virus Scanning - Empty File Check - Hotfix: Change file naming convention of the SIN validation request file - Hotfix: Fix for withdraw upload - Hotfix: Name change for CRA Response file - Parse the last 2 characters in NEB as decimal places - Update PTMSFAA File Name --------- Co-authored-by: Ashish <[email protected]> Co-authored-by: Andre Pestana <[email protected]> Co-authored-by: Lewis Chen <[email protected]> Co-authored-by: Andrew Boni Signori <[email protected]> Co-authored-by: Dheepak Ramanathan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Altered sims.sin_validations.gender_sent to be VARCHAR(50).
Tested with a pending SIN Validation:
After running sin-validation-process-integration:
Revert:
