#3896 - Mask Institution User Income View #3932
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dheepak-aot
reviewed
Nov 13, 2024
| @@ -88,8 +94,13 @@ export class AssessmentControllerService { | |||
| ); | |||
| } | |||
|
|
|||
| const assessmentDTO = assessment.assessmentData as AssessmentAPIOutDTO; | |||
There was a problem hiding this comment.
Suggestion. we can do it like this without force casting.
const assessmentDTO: AssessmentAPIOutDTO = assessment.assessmentData;
if (maskTotalFamilyIncome) {
assessmentDTO.totalFamilyIncome = MASKED_MONEY_AMOUNT;
}There was a problem hiding this comment.
The cast is necessary to allow it to accept a string.
There was a problem hiding this comment.
Changed as suggested.
dheepak-aot
approved these changes
Nov 13, 2024
guru-aot
reviewed
Nov 13, 2024
| @@ -66,6 +66,7 @@ export class AssessmentStudentsController extends BaseController { | |||
| return this.assessmentControllerService.getAssessmentNOA(assessmentId, { | |||
| studentId: userToken.studentId, | |||
| maskMSFAA: false, | |||
| maskTotalFamilyIncome: false, | |||
guru-aot
approved these changes
Nov 13, 2024
|
Backend Unit Tests Coverage Report
|
E2E Workflow Workers Coverage Report
|
E2E Queue Consumers Coverage Report
|
E2E SIMS API Coverage Report
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
totalFamilyIncomefollowing the same approach used to mask the MSFAA.Sample UI with the masked value