Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#3922 - PT Monthly Loan Balance - Update Balance #3928

Merged
merged 2 commits into from
Nov 13, 2024

Conversation

andrewsignori-aot
Copy link
Collaborator

@andrewsignori-aot andrewsignori-aot commented Nov 13, 2024

Adjusted the CSL balance imported to have 2 decimals places.

@andrewsignori-aot andrewsignori-aot self-assigned this Nov 13, 2024
@andrewsignori-aot andrewsignori-aot changed the title #3922 - Monthly loan balance #3922 - PT Monthly Loan Balance - Update Balance Nov 13, 2024
@andrewsignori-aot andrewsignori-aot marked this pull request as ready for review November 13, 2024 21:41
Copy link
Collaborator

@guru-aot guru-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice work @andrewsignori-aot

Copy link

E2E SIMS API Coverage Report

Totals Coverage
Statements: 66.01% ( 5571 / 8439 )
Methods: 63.3% ( 683 / 1079 )
Lines: 70.12% ( 4401 / 6276 )
Branches: 44.93% ( 487 / 1084 )

*/
get cslBalance(): number {
return +this.line.substring(13, 20);
// Divide by 100 to convert to 2 decimal places.
return +this.line.substring(13, 20) / 100;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we please add a TODO here to centralize this parse decimal logic ?. (It is already in sfas utils. we could move it to common place when refactoring).

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I saw it on SFAS but did not felt worth enough to have a util method.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added TODO to move on.

Copy link
Collaborator

@dheepak-aot dheepak-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. 👍Minor observation.

Copy link

Copy link

Backend Unit Tests Coverage Report

Totals Coverage
Statements: 22.3% ( 3692 / 16557 )
Methods: 10.32% ( 212 / 2055 )
Lines: 25.6% ( 3202 / 12508 )
Branches: 13.94% ( 278 / 1994 )

Copy link

E2E Workflow Workers Coverage Report

Totals Coverage
Statements: 65.43% ( 583 / 891 )
Methods: 59.26% ( 64 / 108 )
Lines: 68.54% ( 464 / 677 )
Branches: 51.89% ( 55 / 106 )

Copy link

E2E Queue Consumers Coverage Report

Totals Coverage
Statements: 85.92% ( 1220 / 1420 )
Methods: 87.86% ( 123 / 140 )
Lines: 86.83% ( 1035 / 1192 )
Branches: 70.45% ( 62 / 88 )

@andrewsignori-aot andrewsignori-aot merged commit 2c1d1f2 into release/v1.15.0 Nov 13, 2024
18 of 19 checks passed
@andrewsignori-aot andrewsignori-aot deleted the fix/#3922-monthly-loan-balance branch November 14, 2024 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants