#3922 - PT Monthly Loan Balance - Update Balance #3928
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewsignori-aot
changed the title
guru-aot
approved these changes
Nov 13, 2024
E2E SIMS API Coverage Report
|
dheepak-aot
reviewed
Nov 13, 2024
| */ | ||
| get cslBalance(): number { | ||
| return +this.line.substring(13, 20); | ||
| // Divide by 100 to convert to 2 decimal places. | ||
| return +this.line.substring(13, 20) / 100; |
There was a problem hiding this comment.
Can we please add a TODO here to centralize this parse decimal logic ?. (It is already in sfas utils. we could move it to common place when refactoring).
There was a problem hiding this comment.
I saw it on SFAS but did not felt worth enough to have a util method.
There was a problem hiding this comment.
Added TODO to move on.
dheepak-aot
approved these changes
Nov 13, 2024
|
Backend Unit Tests Coverage Report
|
E2E Workflow Workers Coverage Report
|
E2E Queue Consumers Coverage Report
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjusted the CSL balance imported to have 2 decimals places.