#3745 - Modify process that reads SIN & CRA verification response files #3835
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bidyashish
changed the title
...processors/schedulers/cra-integration/_tests_/cra-response-integration.scheduler.e2e-spec.ts
Outdated
Show resolved
Hide resolved
...processors/schedulers/cra-integration/_tests_/cra-response-integration.scheduler.e2e-spec.ts
Outdated
Show resolved
Hide resolved
...processors/schedulers/cra-integration/_tests_/cra-response-integration.scheduler.e2e-spec.ts
Outdated
Show resolved
Hide resolved
...processors/schedulers/cra-integration/_tests_/cra-response-integration.scheduler.e2e-spec.ts
Show resolved
Hide resolved
...processors/schedulers/cra-integration/_tests_/cra-response-integration.scheduler.e2e-spec.ts
Outdated
Show resolved
Hide resolved
...processors/schedulers/cra-integration/_tests_/cra-response-integration.scheduler.e2e-spec.ts
Outdated
Show resolved
Hide resolved
...s/src/processors/schedulers/cra-integration/_tests_/cra-receive-files/CRA_200_PBCSA00000.TXT
Outdated
Show resolved
Hide resolved
...processors/schedulers/cra-integration/_tests_/cra-response-integration.scheduler.e2e-spec.ts
Outdated
Show resolved
Hide resolved
...dation-integration/_tests_/sin-validation-process-response-integration.scheduler.e2e-spec.ts
Outdated
Show resolved
Hide resolved
| @@ -47,7 +47,7 @@ export class SINValidation extends RecordDataModel { | |||
| type: "timestamptz", | |||
| nullable: true, | |||
| }) | |||
| dateReceived?: Date; | |||
| dateReceived?: Date | null; | |||
There was a problem hiding this comment.
The dateReceived is already marked as nullable and declared as "dateReceived?". Please revert this change.
andrewsignori-aot
approved these changes
Oct 30, 2024
|
Backend Unit Tests Coverage Report
|
E2E Workflow Workers Coverage Report
|
E2E Queue Consumers Coverage Report
|
E2E SIMS API Coverage Report
|
andrepestana-aot
approved these changes
Oct 30, 2024
dheepak-aot
pushed a commit
that referenced
this pull request
Oct 30, 2024
…es (#3835) ***Acceptance Criteria*** - [x] Jobs must continue processing remaining records in a file after it fails to process a record. - [x] SIN and CRA response files will need to be archived after processing even where there are failed records. (IMB staff will need to monitor the jobs to confirm if errors occur processing SIMS response files and address them accordingly) - [x] Disable error reporting when SIMS Reference_IDX fails to match. - [x] If records are identified as SIMS records (based on the project area information being present), errors will be generated as usual. - [x] If records are identified as SFAS records (based on the project area information NOT being present), records should be skipped. - [x] For the SIN validation ([source reference](https://github.com/bcgov/SIMS/blob/8864eaa8a5f62360f5e3c91c6de06f319e008250/sources/packages/backend/libs/integrations/src/services/sin-validation/sin-validation.service.ts#L119)), if the `referenceIndex` is not found on SIMS, assume the record is from SFAS and do not log as an error. - [x] For income verifications, the records should already be skipped. Execute a manual test to ensure that a file with records that do not contain the `VERIFICATION_ID` in the free project area is skipped. Consider creating an E2E to execute the test. - [x] Demo for both cases with a sample file.
This was referenced Nov 5, 2024
sh16011993
added a commit
that referenced
this pull request
Nov 5, 2024
### The following are achieved in this hotfix: - SIN Validation - Gender Field Limit (#3839) - SINF restriction bridge mapping and rename to SINR (#3846) - Virus Scanning - Not functioning PROD (#3854) - Modify process that reads SIN & CRA verification response files (#3835) - Hotfix: Bulk uploads: Unexpected error while uploading the file displays when "Validate" or "Create now" are selected for valid bulk upload - Virus Scanning - Empty File Check - Hotfix: Change file naming convention of the SIN validation request file - Hotfix: Fix for withdraw upload - Hotfix: Name change for CRA Response file - Parse the last 2 characters in NEB as decimal places - Update PTMSFAA File Name --------- Co-authored-by: Ashish <[email protected]> Co-authored-by: Andre Pestana <[email protected]> Co-authored-by: Lewis Chen <[email protected]> Co-authored-by: Andrew Boni Signori <[email protected]> Co-authored-by: Dheepak Ramanathan <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 5, 2024
### The following are the achieved in this hotfix: - SIN Validation - Gender Field Limit (#3839) - SINF restriction bridge mapping and rename to SINR (#3846) - Virus Scanning - Not functioning PROD (#3854) - Modify process that reads SIN & CRA verification response files (#3835) - Hotfix: Bulk uploads: Unexpected error while uploading the file displays when "Validate" or "Create now" are selected for valid bulk upload - Virus Scanning - Empty File Check - Hotfix: Change file naming convention of the SIN validation request file - Hotfix: Fix for withdraw upload - Hotfix: Name change for CRA Response file - Parse the last 2 characters in NEB as decimal places - Update PTMSFAA File Name --------- Co-authored-by: Ashish <[email protected]> Co-authored-by: Andre Pestana <[email protected]> Co-authored-by: Lewis Chen <[email protected]> Co-authored-by: Andrew Boni Signori <[email protected]> Co-authored-by: Dheepak Ramanathan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Acceptance Criteria
referenceIndexis not found on SIMS, assume the record is from SFAS and do not log as an error.VERIFICATION_IDin the free project area is skipped. Consider creating an E2E to execute the test.