Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mask Institution User Income View #3896

Closed
1 task
ninosamson opened this issue Nov 5, 2024 · 4 comments
Closed
1 task

Mask Institution User Income View #3896

ninosamson opened this issue Nov 5, 2024 · 4 comments
Assignees
@ninosamson @andrewsignori-aot
Labels
Business Items under Business Consideration Waiting Waiting for other activity, requirement or deliverable before it can be actioned.
Milestone
Post Part-Time Pr...

Comments

@ninosamson
Copy link
Collaborator

ninosamson commented Nov 5, 2024 •
edited by michesmith
Loading

User Story
As a ministry, we need to comply with our CRA MOU and not present perceived CRA Verified data

Acceptance Criteria
Options:

  • Mask the Total income used for assessment purposes on the assessment with X's for BC Public Institutions (see screen shots below)

image.png

image.png

image.png
@ninosamson ninosamson added the Business Items under Business Consideration label Nov 5, 2024
@Joshua-Lakusta
Copy link
Collaborator

Can we make this configurable and have a toggle so when it inevitably get reversed or changed in the future its easy to turn back on?

@ninosamson
Copy link
Collaborator Author

Now you're talking @Joshua-Lakusta

@ninosamson ninosamson added the Waiting Waiting for other activity, requirement or deliverable before it can be actioned. label Nov 6, 2024
@ninosamson ninosamson changed the title Remove NOA Page for Institution Users NEEDS DECISION: Remove NOA Page for Institution Users Nov 6, 2024
@ninosamson ninosamson changed the title NEEDS DECISION: Remove NOA Page for Institution Users NEEDS DECISION: Remove Institution User Income View Nov 12, 2024
@ninosamson ninosamson changed the title NEEDS DECISION: Remove Institution User Income View Mask Institution User Income View Nov 13, 2024
andrewsignori-aot added a commit that referenced this issue Nov 13, 2024
@andrewsignori-aot
#3896 - Mask Institution User Income View (#3932)
ec1c635 
- Masked the `totalFamilyIncome` following the same approach used to
mask the MSFAA.
- Masked only for public institutions.
- The method used to format the money in the NOA UI when it is a number
has no issues with the "masked" string.

![image](https://github.com/user-attachments/assets/9ae48b52-d619-442a-82cf-65db7a9c20c1)

### Sample UI with the masked value


![image](https://github.com/user-attachments/assets/d6eaf9c7-c568-44a2-b7ce-0c1cbeb58781)
@andrewsignori-aot
Copy link
Collaborator

@CarlyCotton @ninosamson I am not planning to demo this one since it is part of the 1.15 release to be validated by QA.

@ninosamson
Copy link
Collaborator Author

Understood @andrewsignori-aot

@bidyashish bidyashish mentioned this issue Nov 14, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Nov 14, 2024
@bidyashish @sh16011993
@andrepestana-aot @lewischen-aot @andrewsignori-aot @dheepak-aot
#257 - Merge Release v1.15.0 into main (#3940)
6a27866 
Merge Release v1.15 to Main

#260 [- Merge Hotfix v1.14.1 into
Release v1.15.0
(](https://github.com/bcgov/SIMS/pull/3940/commits/a94ebcebe3869618244a23d6da5edee887ceeac9)https://github.com/bcgov/SIMS/pull/3885[)]

#3889 [- Increase Logging for SFTP
and file handling
(](https://github.com/bcgov/SIMS/pull/3940/commits/ba81ad5fc894521463837bdcc704c2b8ef64afd3)https://github.com/bcgov/SIMS/pull/3897[)]

#3889 [- Increase Logging for SFTP
and file handling - (Catch
fix)](c791b9e)

#3889 - Increase Logging for SFTP
and file handling - SSH Lib Upgrade

#3912 [- Allow Disbursement Receipts
File Integration Scheduler For Pa…]

#3924 [- Ecert Creation - "Prefer
not to answer" Gender (]

#3922 [- PT Monthly Loan Balance -
Update Balance (]

#3896 [- Mask Institution User
Income View
(](https://github.com/bcgov/SIMS/pull/3940/commits/ec1c63516c55b557d3a76018c0390f0ff9c3ab9a)https://github.com/bcgov/SIMS/pull/3932[)]

---------

Co-authored-by: Shashank Shekhar <[email protected]>
Co-authored-by: Andre Pestana <[email protected]>
Co-authored-by: Lewis Chen <[email protected]>
Co-authored-by: Andrew Boni Signori <[email protected]>
Co-authored-by: Dheepak Ramanathan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ninosamson ninosamson

@andrewsignori-aot andrewsignori-aot

Labels
Business Items under Business Consideration Waiting Waiting for other activity, requirement or deliverable before it can be actioned.
Projects
None yet
Milestone
Post Part-Time Primera Importante Mucho
Development

No branches or pull requests
4 participants
@ninosamson @andrewsignori-aot @Joshua-Lakusta @michesmith