#3889 - Increase Logging for SFTP and file handling - SSH Lib Upgrade #3903
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
andrewsignori-aot
commented
Nov 6, 2024
andrewsignori-aot
commented
- Upgrade the ssh2-sftp-client to version 11.0.0.
- Minor changes for the logging.
|
Backend Unit Tests Coverage Report
|
E2E Workflow Workers Coverage Report
|
E2E Queue Consumers Coverage Report
|
E2E SIMS API Coverage Report
|
dheepak-aot
reviewed
Nov 6, 2024
| @@ -249,6 +251,7 @@ export abstract class SFTPIntegrationBase<DownloadType> { | |||
| this.logger.log(`Finalizing SFTP client. Context: ${context}.`); | |||
| await SshService.closeQuietly(client); | |||
| this.logger.log(`SFTP client finalized. Context: ${context}.`); | |||
| return; | |||
sh16011993
reviewed
Nov 6, 2024
| @@ -249,6 +251,7 @@ export abstract class SFTPIntegrationBase<DownloadType> { | |||
| this.logger.log(`Finalizing SFTP client. Context: ${context}.`); | |||
| await SshService.closeQuietly(client); | |||
| this.logger.log(`SFTP client finalized. Context: ${context}.`); | |||
| return; | |||
dheepak-aot
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.