-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#3889 - Increase Logging for SFTP and file handling - (Catch fix) #3901
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, nice work @andrewsignori-aot
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍
Fix issues from the previous PR for better logging. The main log from the SFTP base would still work but ensuring the logs are added to the Job in some way makes it easier for troubleshooting.
The goal is to have all the methods following similar archive catch handling doing something closet to each other.
See the example below of a sample that will display errors and
![image](https://private-user-images.githubusercontent.com/61259237/383735162-dbb7e668-38d0-4f04-95a0-6c09720f308b.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzg5MjkyMDgsIm5iZiI6MTczODkyODkwOCwicGF0aCI6Ii82MTI1OTIzNy8zODM3MzUxNjItZGJiN2U2NjgtMzhkMC00ZjA0LTk1YTAtNmMwOTcyMGYzMDhiLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMDclMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjA3VDExNDgyOFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWVmYTU3NTczYjJmNWYwNGEwNzg3ZDAzMDM0ZTRlZGY5MjhmNWU3MTRiNDJkNGNmZTQzMTFkYjA3NjA1YmFlNGQmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.Ab5A4C0VjPe84Fpoh1S-tw4rkiRW4uMGmgRlo2xlnWs)
causes
.