Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#3889 - Increase Logging for SFTP and file handling - (Catch fix) #3901

Merged
merged 1 commit into from
Nov 6, 2024

Conversation

andrewsignori-aot
Copy link
Collaborator

@andrewsignori-aot andrewsignori-aot commented Nov 6, 2024

Fix issues from the previous PR for better logging. The main log from the SFTP base would still work but ensuring the logs are added to the Job in some way makes it easier for troubleshooting.
The goal is to have all the methods following similar archive catch handling doing something closet to each other.

See the example below of a sample that will display errors and causes.
image

Copy link

sonarqubecloud bot commented Nov 6, 2024

@andrewsignori-aot andrewsignori-aot self-assigned this Nov 6, 2024
Copy link

github-actions bot commented Nov 6, 2024

Backend Unit Tests Coverage Report

Totals Coverage
Statements: 22.3% ( 3692 / 16556 )
Methods: 10.32% ( 212 / 2055 )
Lines: 25.6% ( 3202 / 12507 )
Branches: 13.94% ( 278 / 1994 )

@andrewsignori-aot andrewsignori-aot added Bug Something isn't working Queue Consumers Prod Required Strongly recommended for production. labels Nov 6, 2024
Copy link

github-actions bot commented Nov 6, 2024

E2E Workflow Workers Coverage Report

Totals Coverage
Statements: 65.43% ( 583 / 891 )
Methods: 59.26% ( 64 / 108 )
Lines: 68.54% ( 464 / 677 )
Branches: 51.89% ( 55 / 106 )

Copy link

github-actions bot commented Nov 6, 2024

E2E Queue Consumers Coverage Report

Totals Coverage
Statements: 85.92% ( 1220 / 1420 )
Methods: 87.86% ( 123 / 140 )
Lines: 86.83% ( 1035 / 1192 )
Branches: 70.45% ( 62 / 88 )

@andrewsignori-aot andrewsignori-aot marked this pull request as ready for review November 6, 2024 21:44
@andrewsignori-aot andrewsignori-aot changed the title #3889 - Fixed SFTP archive logs #3889 - Increase Logging for SFTP and file handling - Fix Catch Nov 6, 2024
@andrewsignori-aot andrewsignori-aot changed the title #3889 - Increase Logging for SFTP and file handling - Fix Catch #3889 - Increase Logging for SFTP and file handling - (Catch fix) Nov 6, 2024
Copy link

github-actions bot commented Nov 6, 2024

E2E SIMS API Coverage Report

Totals Coverage
Statements: 66.01% ( 5571 / 8439 )
Methods: 63.3% ( 683 / 1079 )
Lines: 70.12% ( 4401 / 6276 )
Branches: 44.93% ( 487 / 1084 )

Copy link
Collaborator

@sh16011993 sh16011993 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Collaborator

@guru-aot guru-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice work @andrewsignori-aot

Copy link
Collaborator

@dheepak-aot dheepak-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@andrewsignori-aot andrewsignori-aot merged commit c791b9e into release/v1.15.0 Nov 6, 2024
20 checks passed
@andrewsignori-aot andrewsignori-aot deleted the fix/#3889-sftp-logs branch November 6, 2024 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Prod Required Strongly recommended for production. Queue Consumers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants