ZEPPELIN-385 Read-only mode for zeppelin notebooks, for analysis sharing

[babokim]

This PR is for read-only mode.

[felixcheung]

warning?

[r-kamath]

@babokim Thanks for the update. Looks good to me.

[Xrixcis]

I think this condition should be in runParagraph(...) too

[Leemoonsoo]

@Xrixcis I think it is intended to make Zeppelin readonly(blocks notebook/paragraph CRUD), but let user still able to run.

[Xrixcis]

Hi, great feature, thanks!
One little bug I came across, isReadOnly function seems to be missing in paragraph.controller.js.

[Leemoonsoo]

Setting button in 'disabled' class doesn't look different much.

I think it's better hide the button.

[Leemoonsoo]

Tested and working nicely.
Thanks @babokim for contributing really useful feature.

Looks good to me

[jongyoul]

I think we avoid this style kind of *. Could you please change this to separate libraries?

[Leemoonsoo]

Merging if there're no more discussions.

[jongyoul]

@Leemoonsoo I think we should take a care of a style of import *. What do you think of it? This looks minor for now but it needs to keep it.

[corneadoug]

Duplicate with Line 33

[corneadoug]

I'm a bit late for the party,
However I would prefer the isReadOnly() part in zeppelin-web to be handled as a DataFactory instead of storing it in the $rootScope and copy pasting the same function in every controllers.

There is a good example here:
https://github.com/apache/incubator-zeppelin/blob/master/zeppelin-web/src/components/notebookListDataFactory/notebookList.datafactory.js

And you can see it in action here:
https://github.com/apache/incubator-zeppelin/blob/master/zeppelin-web/src/components/navbar/navbar.controller.js

[babokim]

@corneadoug Thank you for your advise. I tried storing system config values in a DataFactory. That way also has similar duplication. To set the data in that DataFactory after receiving from the Websocket, each controller should have receiver function like the following code. That function code also is duplicated in every controllers.

angular.module('zeppelinWebApp').factory('websocketEvents', function ( ... ) {
  websocketCalls.ws.onMessage(function(event) {
    ...
    } else if (op === 'GET_SYSTEM_CONF') {
      $rootScope.$broadcast('setSystemConf', data.conf);
    }
  }
}

angular.module('zeppelinWebApp').controller('NotebookCtrl'..., function(...)  {
  $scope.$on('setSystemConf', function(event, systemConf  {
    systemConfigDataFactory.setSystemConf(systemConf);
  });

If there is another way to set system config data, please let me know. Thanks.

[corneadoug]

@babokim
That's not exactly how it should be used, the goal is to use it as a data storage.
Let's say you have a similar DataFactory as the one I gave in example:

angular.module('zeppelinWebApp').factory('systemConfDataFactory', function() {
  var vm = {};

  vm.conf = {};

  vm.setSystemConf = function(systemConf) {
    vm.conf = angular.copy(systemConf);
  };
  return vm;
});

Then you just have to call setSystemConf in your websocketEvents like this:

angular.module('zeppelinWebApp').factory('websocketEvents', function ( ...,  systemConfDataFactory) {
  websocketCalls.ws.onMessage(function(event) {
    ...
    } else if (op === 'GET_SYSTEM_CONF') {
      systemConfDataFactory.setSystemConf(data.conf);
    }
  }
}

And when you need to do some ng-if or ng-hide, you can do like this:
home.controller

 angular.module('zeppelinWebApp').controller('HomeCtrl', function(..., systemConfDataFactory) {
   vm.systemConfDataFactory = systemConfDataFactory;

home.html

<h5 ng-hide="home.systemConfDataFactory.conf.readonly">
  <a href="" data-toggle="modal" data-target="#noteNameModal" style="text-decoration: none;">
    <i style="font-size: 15px;" class="icon-notebook"></i> Create new note</a>
</h5>

[babokim]

@corneadoug Thank you for your kindness. I will try as your way.

[Leemoonsoo]

@babokim Do you mind rebase or merge master to resolve the conflicts?

[rishitesh]

@babokim , Can you please merge this feature ?

[rishitesh]

Its really a useful feature for demo , where multiple users might try their hands.

[felixcheung]

@babokim - would you be able to update this PR? It looks like the community would appreciate your contributor to make this possible ;)

[corneadoug]

I can also make a PR to this one to fix the zeppelin-web part if you don't have the time

[dusenberrymw]

Agree with @rishitesh that this would be really great for live demos!

[felixcheung]

@babokim haven't heard from you - would you be able to continue this work?

[FRosner]

Thumbs up also from my side if we can resolve conflicts, finish discussions and merge if appropriate 👍

[nolangrace]

I would love to take advantage of this feature is there anything I can do help move this pull request forward?

[meniluca]

Ditto! :) 👍

[corneadoug]

@babokim
Going around old PRs,
Is it still needed considering the efforts for user authentication, and notebook acl restrictions?