Skip to content

Conversation

@Madhuka
Copy link
Contributor

@Madhuka Madhuka commented Aug 11, 2015

Documentation on

  • How to add new chart libraries for zeppelin
  • How add new data validation schema
  • Tutorial with Map Visualization

@Madhuka
Copy link
Contributor Author

Madhuka commented Aug 11, 2015

Documents are under Development

screenshot from 2015-08-11 21 28 04

Data Validation

screenshot from 2015-08-11 21 27 38

Introducing New Chart Library

screenshot from 2015-08-11 21 27 50

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo: Zeppelin

@Leemoonsoo
Copy link
Member

Thanks for good documentation. LGTM!

@elbamos
Copy link
Contributor

elbamos commented Aug 16, 2015

I don't mean to be a naysayer, and I agree that documentation on these topics would be very helpful. I also agree that this is a good starting point. I find both pages, though, very difficult to understand. Are these directions for implementing new interpreters? For users? For developing applications on top of Zeppelin?

On Aug 16, 2015, at 12:36 PM, Lee moon soo [email protected] wrote:

Thanks for good documentation. LGTM!


Reply to this email directly or view it on GitHub.

@corneadoug
Copy link
Contributor

The Data Validation documentation is too complicated and not complete I think.

I think the description should be reworked to emphasized where it is used in Zeppelin and for what purpose.

There should also have a part explaining exactly what it is doing (How the validation is done).
Some link to example, and/or an use case explanation.

Also the part about beyond data type validation is pretty obscure, it should be made so its easier to understand and apply. If you want to say that you can extend the schema, then a simple example would be helpful too.

Seems like this branch also need to be rebased (merge conflicts)

@Madhuka
Copy link
Contributor Author

Madhuka commented Aug 17, 2015

@elbamos Thanks for the feedback. A validator is important to determine the data maps to the schema without any errors beforehand. Yes it is complicated but I will write more simpler manner so that everybody can understand. It's not an interpreter. It's useful for users as well as for developers. Users can use the validator before visualization to check if the data is in accordance with the data model. It will not break and the user can take the right decision. For zeppelin developers when they introduce a new chart library they can add a validator for it so that users can validate the data before they visualize it.

@Madhuka
Copy link
Contributor Author

Madhuka commented Aug 17, 2015

@corneadoug
Yes I will write more descriptive documentation and add few sample code for it.

@Madhuka
Copy link
Contributor Author

Madhuka commented Aug 20, 2015

Data Validation Document is Updated with below sub titles.

  • Where the data validator is used in zeppelin?
  • Why the data validator is used?
  • Why the data validator is important?
  • How Data Validation is done?
  • Adding new Data Range Validation

@Madhuka
Copy link
Contributor Author

Madhuka commented Aug 20, 2015

Documentation updated with Tutorial with Map Visualization. Added screenshots for docs.
screenshot from 2015-08-20 23 43 28

Tutorial with Map Visualization
screenshot from 2015-08-21 00 02 44

@elbamos
Copy link
Contributor

elbamos commented Aug 20, 2015

This looks really helpful! I withdraw my prior objection.

On Aug 17, 2015, at 4:37 AM, madhuka [email protected] wrote:

@elbamos Thanks for the feedback. A validator is important to determine the data maps to the schema without any errors beforehand. Yes it is complicated but I will write more simpler manner so that everybody can understand. It's not an interpreter. It's useful for users as well as for developers. Users can use the validator before visualization to check if the data is in accordance with the data model. It will not break and the user can take the right decision. For zeppelin developers when they introduce a new chart library they can add a validator for it so that users can validate the data before they visualize it.


Reply to this email directly or view it on GitHub.

lelou6666 pushed a commit to lelou6666/incubator-zeppelin that referenced this pull request Mar 25, 2016
@asfgit asfgit closed this in c38a0a0 May 9, 2018
asfgit pushed a commit that referenced this pull request May 9, 2018
close #83
close #86
close #125
close #133
close #139
close #146
close #193
close #203
close #246
close #262
close #264
close #273
close #291
close #299
close #320
close #347
close #389
close #413
close #423
close #543
close #560
close #658
close #670
close #728
close #765
close #777
close #782
close #783
close #812
close #822
close #841
close #843
close #878
close #884
close #918
close #989
close #1076
close #1135
close #1187
close #1231
close #1304
close #1316
close #1361
close #1385
close #1390
close #1414
close #1422
close #1425
close #1447
close #1458
close #1466
close #1485
close #1492
close #1495
close #1497
close #1536
close #1545
close #1561
close #1577
close #1600
close #1603
close #1678
close #1695
close #1739
close #1748
close #1765
close #1767
close #1776
close #1783
close #1799
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants