-
Notifications
You must be signed in to change notification settings - Fork 2.8k
ZEPPELIN-217 : Adding documentation on adding new chart types and Data validation serivce #203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo: Zeppelin
|
Thanks for good documentation. LGTM! |
|
I don't mean to be a naysayer, and I agree that documentation on these topics would be very helpful. I also agree that this is a good starting point. I find both pages, though, very difficult to understand. Are these directions for implementing new interpreters? For users? For developing applications on top of Zeppelin?
|
|
The Data Validation documentation is too complicated and not complete I think. I think the description should be reworked to emphasized where it is used in Zeppelin and for what purpose. There should also have a part explaining exactly what it is doing (How the validation is done). Also the part about Seems like this branch also need to be rebased (merge conflicts) |
|
@elbamos Thanks for the feedback. A validator is important to determine the data maps to the schema without any errors beforehand. Yes it is complicated but I will write more simpler manner so that everybody can understand. It's not an interpreter. It's useful for users as well as for developers. Users can use the validator before visualization to check if the data is in accordance with the data model. It will not break and the user can take the right decision. For zeppelin developers when they introduce a new chart library they can add a validator for it so that users can validate the data before they visualize it. |
|
@corneadoug |
|
Data Validation Document is Updated with below sub titles.
|
|
This looks really helpful! I withdraw my prior objection.
|
Adjustable paragraph height
close #83 close #86 close #125 close #133 close #139 close #146 close #193 close #203 close #246 close #262 close #264 close #273 close #291 close #299 close #320 close #347 close #389 close #413 close #423 close #543 close #560 close #658 close #670 close #728 close #765 close #777 close #782 close #783 close #812 close #822 close #841 close #843 close #878 close #884 close #918 close #989 close #1076 close #1135 close #1187 close #1231 close #1304 close #1316 close #1361 close #1385 close #1390 close #1414 close #1422 close #1425 close #1447 close #1458 close #1466 close #1485 close #1492 close #1495 close #1497 close #1536 close #1545 close #1561 close #1577 close #1600 close #1603 close #1678 close #1695 close #1739 close #1748 close #1765 close #1767 close #1776 close #1783 close #1799





Documentation on