Fix/fix notebook settings

[corneadoug]

Setting Window used to be shown inside the notebook and therefore would scroll with notebook content.
In this PR, we are fixing it on top with the NotebookAction bar.

We also have a scrollbar in the settings in case the window height is too small

[corneadoug]

Ready To merge
(CI fails on flink, and I would rebase before merge)

I'd love to have a few feedbacks or review

[Leemoonsoo]

I have tested. and working nicely.
One suggestion. How about limit the max-height of setting panel to about 3/4 - 4/5 size of the browser window height? That would clearly indicate user that setting panel is above the notebook.

[corneadoug]

I guess 4/5 in that case would work nicely. I will try and post a screenshot

[corneadoug]

@Leemoonsoo Like this?

If it's good I will push that new commit.
However we might want to rethink the layout of those settings later.

[Leemoonsoo]

Yes, that's what i thought.

[Leemoonsoo]

one small detail is

Isn't it make more sense to move shadow to the bottom of the setting panel, when it is expanded?

[corneadoug]

I'm trying to play with flexbox to get this result

But it's not working on IE with max-height... so I'm trying to find a way

[bzz]

Looks great.
@corneadoug did you manage to find a way to do it?

[corneadoug]

I'm still stuck with IE and wasn't able to work on it since.
Since its an improvement its not urgent

[Leemoonsoo]

Any update on it?