Skip to content

Conversation

@eraffenne
Copy link
Contributor

Fix data order for x axis.

@corneadoug
Copy link
Contributor

Hi,
After trying this branch, my understanding is that the data is now ordered accordingly to the query, is that right?

@eraffenne
Copy link
Contributor Author

Yes, the data is ordered accordingly to the query.

@corneadoug
Copy link
Contributor

Hi,
I'm not really for merging this PR for multiple reasons:

  • Auto ordering can sometimes be helpful at the moment (even if being able to order we want is the goal)
  • There is no replacement for ordering outside of the query order
  • We are working as part of the Spring Cleaning PR and GSOC into replacing the pivot and ultimately integrating ordering inside of it. (Pivot refactoring coming soon at least), so it would add more cleaning/possible conflicts for us

If however others were inclined to merge:

  • Need to remove the commented console.log

This could be eventually merged, and it would be squashed in 3-4weeks maybe. The decision is more about, if people are okay with losing the auto ordering during that time.

@galleon
Copy link
Contributor

galleon commented Jun 3, 2015

Hi,

You mentioned changes in the pivot through GSOC, is there any PR presenting that work? My interest is looking into new visualization (maps especially) so there is obviously a link ;-)

@corneadoug
Copy link
Contributor

@galleon It's early stage for GSOC so no direct PR to Zeppelin repository yet.
In a couple of weeks there should be somewhere I could point you to.

You could also check the angular interpreter which allow you to include any type of view, the documentation was not made yet, but it was merged and you can find examples in the PR itself: #27

Otherwise #56 is changing the code structure and optimizing the code for Zeppelin-web hopefully it will be done soon

@galleon
Copy link
Contributor

galleon commented Jun 3, 2015

@corneadoug I have noticed #56 and I will wait for it to be pushed before contributing.
#27 is impressive and I played a bit with the concept today. Would that allow me to create maps based on D3?

@lucarosellini
Copy link
Contributor

@corneadoug now that #56 has finally been merged we're still experiencing the data order issue fixed by this PR. Is there a chance this will be merged into master?

@corneadoug
Copy link
Contributor

@lucarosellini #56 scope was shortened because of all the changes it was bringing to the project.
So in the end, there was no clear separation of paragraph.js or modification of the pivot, which means the issue still exist.

So far, my feeling was that it was just moving the ordering problem to other cases. (post pivot)
I can run a few test on this PR again, to double check.

@lucarosellini lucarosellini deleted the feature/x-axis-orderby branch October 21, 2015 12:09
@jjmleiro jjmleiro restored the feature/x-axis-orderby branch October 29, 2015 14:45
@asfgit asfgit closed this in c38a0a0 May 9, 2018
asfgit pushed a commit that referenced this pull request May 9, 2018
close #83
close #86
close #125
close #133
close #139
close #146
close #193
close #203
close #246
close #262
close #264
close #273
close #291
close #299
close #320
close #347
close #389
close #413
close #423
close #543
close #560
close #658
close #670
close #728
close #765
close #777
close #782
close #783
close #812
close #822
close #841
close #843
close #878
close #884
close #918
close #989
close #1076
close #1135
close #1187
close #1231
close #1304
close #1316
close #1361
close #1385
close #1390
close #1414
close #1422
close #1425
close #1447
close #1458
close #1466
close #1485
close #1492
close #1495
close #1497
close #1536
close #1545
close #1561
close #1577
close #1600
close #1603
close #1678
close #1695
close #1739
close #1748
close #1765
close #1767
close #1776
close #1783
close #1799
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants