Skip to content

Conversation

@leonardofoderaro
Copy link

Hi all, I tried to implement my first Zeppelin Interpreter for Javascript. I filled a Jira ticket. Please let me know if I did something wrong (it's my first PR!) - thanks!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might want to write the exception out to logger.error()

@felixcheung
Copy link
Member

Could you please reference the JIRA ticket here?

@bzz
Copy link
Member

bzz commented Sep 12, 2015

Great contribution, thank you!
Could you explain a bit what's it for and how user will benefit from it?

Also, all new interpreter PRs should include some docs, so could you please add it to /docs/, more details on how to do that you can find here http://zeppelin.incubator.apache.org/docs/development/howtocontributewebsite.html

@leonardofoderaro
Copy link
Author

Thank you all for the feedback. Today I'm a bit busy, I'll work on both the code and the docs in these days. The Jira ticket is this: https://issues.apache.org/jira/browse/ZEPPELIN-300

@bzz
Copy link
Member

bzz commented Sep 12, 2015

@leonardofoderaro thank you for prompt response and do not worry, please take your time!
Also it's good practice to put issue number in the name of the PR, like 'ZEPPELIN-300: add Js Intepreter, based on Nashorn', to simplify things for the reviewers.

@corneadoug
Copy link
Contributor

@leonardofoderaro
I'm going around old PRs,
Any plan on finishing this one?

@asfgit asfgit closed this in c38a0a0 May 9, 2018
asfgit pushed a commit that referenced this pull request May 9, 2018
close #83
close #86
close #125
close #133
close #139
close #146
close #193
close #203
close #246
close #262
close #264
close #273
close #291
close #299
close #320
close #347
close #389
close #413
close #423
close #543
close #560
close #658
close #670
close #728
close #765
close #777
close #782
close #783
close #812
close #822
close #841
close #843
close #878
close #884
close #918
close #989
close #1076
close #1135
close #1187
close #1231
close #1304
close #1316
close #1361
close #1385
close #1390
close #1414
close #1422
close #1425
close #1447
close #1458
close #1466
close #1485
close #1492
close #1495
close #1497
close #1536
close #1545
close #1561
close #1577
close #1600
close #1603
close #1678
close #1695
close #1739
close #1748
close #1765
close #1767
close #1776
close #1783
close #1799
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants