Pool pluggable rebase #843
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Attempt to deal with github showing commits as part of this branch despite the fact that they were already in master. Remake of this pull request: |
Contributor
Author
|
...There are no changes that would make it work on one spark version and not on another. Closing and reopening to trigger rebuild. |
Member
|
@Leemoonsoo @felixcheung Ping. |
| Properties prop = interpreterGroup.getProperty(); | ||
| //Happens during tests. | ||
| if (prop == null) | ||
| prop = new Properties(); |
Member
There was a problem hiding this comment.
I know we don't have style check for this official but could we put single line into bracket too? It would help readability and prevent possible merge mistakes.
(same for L143)
http://embeddedgurus.com/barr-code/2014/03/apples-gotofail-ssl-security-bug-was-easily-preventable/
| } | ||
|
|
||
| } catch (IOException e) { | ||
| } |
Member
There was a problem hiding this comment.
logger.error("", e) if we are swallowing an exception?
asfgit
pushed a commit
that referenced
this pull request
May 9, 2018
close #83 close #86 close #125 close #133 close #139 close #146 close #193 close #203 close #246 close #262 close #264 close #273 close #291 close #299 close #320 close #347 close #389 close #413 close #423 close #543 close #560 close #658 close #670 close #728 close #765 close #777 close #782 close #783 close #812 close #822 close #841 close #843 close #878 close #884 close #918 close #989 close #1076 close #1135 close #1187 close #1231 close #1304 close #1316 close #1361 close #1385 close #1390 close #1414 close #1422 close #1425 close #1447 close #1458 close #1466 close #1485 close #1492 close #1495 close #1497 close #1536 close #1545 close #1561 close #1577 close #1600 close #1603 close #1678 close #1695 close #1739 close #1748 close #1765 close #1767 close #1776 close #1783 close #1799
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
This is a step towards creating a REST endpoint from resource pools https://issues.apache.org/jira/browse/ZEPPELIN-699
It allows resources to be saved to disk so that they can be reloaded.
What type of PR is it?
Improvement
Todos
What is the Jira issue?
Partially implements this: https://issues.apache.org/jira/browse/ZEPPELIN-699
Note, that this pull request is dependent upon this one:
#782
How should this be tested?
You should see new resource files created in notebook/zeppelin_resources
Screenshots (if appropriate)
Questions: