Skip to content

Conversation

@khalidhuseynov
Copy link
Member

@khalidhuseynov khalidhuseynov commented Jun 29, 2016

What is this PR for?

This PR is to address so called offline view (view only + offline) mode. In this mode you open notebook in only view mode meaning can't do any editions + notebook and paragraph bars are disabled. Further, it's called offline, in case someone else does any changes in the notebook while you have it open, the changes will not be rendered in your screen until you reload it. There was initial work under #389, however some notable differences exist. For example, same functionality here available from frontend menu without need to restart Zeppelin. Also it provides offline view which was absent in initial PR.

What type of PR is it?

Feature

Todos

  • - basic frontend implementation
  • - address comments + green CI

What is the Jira issue?

related to ZEPPELIN-385

How should this be tested?

  1. open any notebook
  2. click offline view from the dropdown menu of notebook looknfeel bar on the top right
  3. try to edit note or do any changes

Screenshots (if appropriate)

view only
offlineview

offline view
offline4

Questions:

  • Does the licenses files need update? No
  • Is there breaking changes for older versions? No
  • Does this needs documentation? Possibly

@r-kamath
Copy link
Member

@khalidhuseynov may be we should consider enabling show/hide editor and output buttons

@corneadoug
Copy link
Contributor

I'm not sure what the usage of this feature as if would be.
#389 was aiming at having a view only experience at a time when auth was not implemented.
In our case it would make more sense to link this feature to the notebook user access settings, especially since only changing the url would still allow to access it in edit mode

@bzz
Copy link
Member

bzz commented Jun 30, 2016

@khalidhuseynov one thing: as soon as this changes the URL - you might want to double-check and make sure that URLs to each separate paragraph (+IFrame ones) and a Search work with new URL.

@khalidhuseynov
Copy link
Member Author

@r-kamath that's good point, but that differs according to use cases (also as a workaround, possible to set those before switching to offline link). from point of view having offline view, no changes on notebook should be displayed and basically any paragraph updates are blocked to render in here, which includes updates from show/hide editor and output forms. However it can be reconsidered depending on more feedback on use cases.

@corneadoug it makes some sense, however view only isn't the only feature. i updated the description with second screenshot on offline view. anyways, I'll look more into how it goes along with the authentication and get back here.

@bzz thanks for feedback, i'll look into that.

@dceashish
Copy link

Copying from Zeppelin Dev List:

It's not clear to me if offline mode would allow changing input controls (dropdowns/input box etc) and view the new result. Our requirement is for a dashboard mode, where multiple users can play with the data using the input controls but don't interfere with each other's work. This is a very basic requirement for making Dashboards using Zeppelin.

I think isolating a notebook copy in a web socket/user session (in Dashboard mode), can achieve the desired results.

@bzz
Copy link
Member

bzz commented Aug 3, 2016

@khalidhuseynov do you think we can close this one now, until you look into it more again? Or is it WIP?

@bzz
Copy link
Member

bzz commented Aug 11, 2016

@khalidhuseynov 1 week ping

@khalidhuseynov
Copy link
Member Author

@bzz thanks for ping, i'm closing it for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants