Skip to content

Conversation

@Madhuka
Copy link
Contributor

@Madhuka Madhuka commented Aug 28, 2015

Data Validation

More details can be found in Docs or here[1]

[1] http://madhukaudantha.blogspot.com/2015/08/zeppelin-data-validation-service.html
[2] #203

@Madhuka
Copy link
Contributor Author

Madhuka commented Sep 1, 2015

Since PR #152 have CI issue this PR is coming with data validation feature which was PR #152

@bzz, @corneadoug : PR contains data validation feature with covering all the zeppelin charts data models.
@Leemoonsoo : Ready for Merge

@corneadoug
Copy link
Contributor

@Madhuka I'm currently testing this branch:

  • - Running a few cases
  • - Checking the code
  • - Verifying the tests
  • - Double Checking the docs

During that time, could you bring #203 into this branch/PR? The docs moved from gh-pages to the zeppelin repository (/docs folder), so it allows us to group the docs in the same PR as the feature.

@Madhuka
Copy link
Contributor Author

Madhuka commented Sep 15, 2015

@corneadoug , I will add the docs here.

@corneadoug
Copy link
Contributor

My main concern with this PR is performances:

  • We are parsing the full data to make sure it fit the graph format
  • The validate function is launched a lot of times, even when not needed (COMMIT_PARAGRAPH after updated the width of the paragraph for example)

We are already limited in term of memory in the web browser. Inspection with ng-stats or batarang didn't really help me getting a better idea on that.

@galleon
Copy link
Contributor

galleon commented Dec 11, 2015

@corneadoug have we measured the overhead in terms of memory/time? If that is a real issue and you believe this will damage the user experience then either we can make it optional or simply disregard it.

@corneadoug
Copy link
Contributor

Haven't really be able to measure the overhead.
But parsing the full query response, can be expensive if the data returned is big.

One thing that could be an alternative however, would be to have some kind of informations tooltip (to show what type is accepted), and maybe improve the error message on the graph when it fails.

lelou6666 pushed a commit to lelou6666/incubator-zeppelin that referenced this pull request Mar 25, 2016
Fix d3 data formmating for chart drawing
@corneadoug
Copy link
Contributor

@Madhuka Should we close this PR?

@Madhuka
Copy link
Contributor Author

Madhuka commented Oct 3, 2016

@corneadoug This PR can be useful when we have some different charts models (presenting different data models) This PR need some changes as @galleon says...
This need to optional to execute as user preferred. This will be useful to detected error, missing, etc in data model in Big data analysis.

@asfgit asfgit closed this in c38a0a0 May 9, 2018
asfgit pushed a commit that referenced this pull request May 9, 2018
close #83
close #86
close #125
close #133
close #139
close #146
close #193
close #203
close #246
close #262
close #264
close #273
close #291
close #299
close #320
close #347
close #389
close #413
close #423
close #543
close #560
close #658
close #670
close #728
close #765
close #777
close #782
close #783
close #812
close #822
close #841
close #843
close #878
close #884
close #918
close #989
close #1076
close #1135
close #1187
close #1231
close #1304
close #1316
close #1361
close #1385
close #1390
close #1414
close #1422
close #1425
close #1447
close #1458
close #1466
close #1485
close #1492
close #1495
close #1497
close #1536
close #1545
close #1561
close #1577
close #1600
close #1603
close #1678
close #1695
close #1739
close #1748
close #1765
close #1767
close #1776
close #1783
close #1799
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants