Skip to content

Conversation

@PetroKostyuk
Copy link

@PetroKostyuk PetroKostyuk commented Dec 19, 2016

What is this PR for?

This PR adds button that allows user to copy link to paragraph in context. Then if user follows this link, it will load note and scroll to selected paragraph

What type of PR is it?

Feature

What is the Jira issue?

https://issues.apache.org/jira/browse/ZEPPELIN-727

How should this be tested?

  1. Open note, choose one paragraph and click on 'Link to paragrapgh in context'.
    screenshot from 2016-12-19 19-29-22

  2. Copy link that is prompted to you.
    screenshot from 2016-12-19 19-30-17

  3. Open link in new tab or window.
    screenshot from 2016-12-19 19-33-43

  4. Your notebook should load and scroll to linked paragraph.

Petro Kostyuk added 2 commits December 19, 2016 19:19
@AhyoungRyu
Copy link
Contributor

@PetroKostyuk Thanks for your contribution! It's really useful feature indeed.
For the quick review, it would be better to edit PR title to sth like "[ZEPPELIN-727] Enable to jump to specific paragraph using anchor" instead of just "ZEPPELIN 727". Then other ppl can recognize what this PR implemented at a glance.

I tested and it works well as you described. Here are some my thoughts

  1. In my case, couldn't get the difference between screen shot 2016-12-20 at 11 54 50 am
    and screen shot 2016-12-20 at 11 54 16 am at the first time. Probably some users will be same with me. I know "Link this paragraph" is existed one, but "Publish this paragraph with iframe" instead of "Link this paragraph" would be more precise to prevent any confusion.

  2. With this PR, we need to
    Click gear icon -> Click "Link to paragraph in context" menu -> Ctrl+C and enter to copy the paragraph url -> Open new tab -> Paste the url

IMPO using anchor has to be simple. Let's say we need specific paragraph url to give this location to someone. e.g. in Zeppelin official docs site,
anchor

The icon is exposed in the outside(need mouse hovering) and we can instinctively recognize what it is.

So i think it would be better the anchor icon can be exposed in the outside not in the dropdown menu. And after we click that icon, the url will be exposed in the top header bar like I posted in the above, or maybe automatically copied right after we click it (please refer to #1750 ).

It's just my opinion in my head. So please take with grain of salt and feel free to share your thought! :D

@FireArrow
Copy link
Contributor

I agree with @AhyoungRyu. What she describes is the common way to link to paragraphs, so it seems reasonable to assume that is what users are used to.

@PetroKostyuk
Copy link
Author

Thank you for your replays!
I'll try to implement what you suggested, it will indeed make this feature more user friendly.

@aurely06
Copy link

Hi,

Any update about this request ? The link to paragraph in context is available or not yet ?
Thank you !

@PetroKostyuk
Copy link
Author

As it seems, this pull request is still open, so this feature is not in added to application. I no longer work on zeppelin project, so I don't know whether this feature will get published in future or no.

@aurely06
Copy link

ok, thank you for your answser

@asfgit asfgit closed this in c38a0a0 May 9, 2018
asfgit pushed a commit that referenced this pull request May 9, 2018
close #83
close #86
close #125
close #133
close #139
close #146
close #193
close #203
close #246
close #262
close #264
close #273
close #291
close #299
close #320
close #347
close #389
close #413
close #423
close #543
close #560
close #658
close #670
close #728
close #765
close #777
close #782
close #783
close #812
close #822
close #841
close #843
close #878
close #884
close #918
close #989
close #1076
close #1135
close #1187
close #1231
close #1304
close #1316
close #1361
close #1385
close #1390
close #1414
close #1422
close #1425
close #1447
close #1458
close #1466
close #1485
close #1492
close #1495
close #1497
close #1536
close #1545
close #1561
close #1577
close #1600
close #1603
close #1678
close #1695
close #1739
close #1748
close #1765
close #1767
close #1776
close #1783
close #1799
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants