-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Zeppelin 727 #1783
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Zeppelin 727 #1783
Conversation
|
@PetroKostyuk Thanks for your contribution! It's really useful feature indeed. I tested and it works well as you described. Here are some my thoughts
IMPO using anchor has to be simple. Let's say we need specific paragraph url to give this location to someone. e.g. in Zeppelin official docs site, The icon is exposed in the outside(need mouse hovering) and we can instinctively recognize what it is. So i think it would be better the anchor icon can be exposed in the outside not in the dropdown menu. And after we click that icon, the url will be exposed in the top header bar like I posted in the above, or maybe automatically copied right after we click it (please refer to #1750 ). It's just my opinion in my head. So please take with grain of salt and feel free to share your thought! :D |
|
I agree with @AhyoungRyu. What she describes is the common way to link to paragraphs, so it seems reasonable to assume that is what users are used to. |
|
Thank you for your replays! |
|
Hi, Any update about this request ? The link to paragraph in context is available or not yet ? |
|
As it seems, this pull request is still open, so this feature is not in added to application. I no longer work on zeppelin project, so I don't know whether this feature will get published in future or no. |
|
ok, thank you for your answser |
close #83 close #86 close #125 close #133 close #139 close #146 close #193 close #203 close #246 close #262 close #264 close #273 close #291 close #299 close #320 close #347 close #389 close #413 close #423 close #543 close #560 close #658 close #670 close #728 close #765 close #777 close #782 close #783 close #812 close #822 close #841 close #843 close #878 close #884 close #918 close #989 close #1076 close #1135 close #1187 close #1231 close #1304 close #1316 close #1361 close #1385 close #1390 close #1414 close #1422 close #1425 close #1447 close #1458 close #1466 close #1485 close #1492 close #1495 close #1497 close #1536 close #1545 close #1561 close #1577 close #1600 close #1603 close #1678 close #1695 close #1739 close #1748 close #1765 close #1767 close #1776 close #1783 close #1799



What is this PR for?
This PR adds button that allows user to copy link to paragraph in context. Then if user follows this link, it will load note and scroll to selected paragraph
What type of PR is it?
Feature
What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-727
How should this be tested?
Open note, choose one paragraph and click on 'Link to paragrapgh in context'.

Copy link that is prompted to you.

Open link in new tab or window.

Your notebook should load and scroll to linked paragraph.