[ZEPPELIN-1163] Change some parameter name properly in NotebookRestApi #1187

zak-hassan · 2016-07-15T01:59:13Z

What is this PR for?

Fix for ZEPPELIN-1163.

What type of PR is it?

Task

Todos

- change all web service parameters from notebookId to noteId. Per description provided in jira issue: "Some parameter from rest api are proper to set noteId rather than notebookId"

What is the Jira issue?

Open an issue on Jira https://issues.apache.org/jira/browse/ZEPPELIN-1163

How should this be tested?

Execute on the web services or via the ui which is communicating with webservice. Delete note, etc.

Screenshots (if appropriate)

Questions:

Does the licenses files need update? no
Is there breaking changes for older versions? no
Does this needs documentation? no

AhyoungRyu · 2016-07-15T07:46:21Z

Is this PR WIP? I think rest-notebook.md file needs to be updated as well.
docs/rest-api/rest-notebook.md

And there are still many notebookId in other files.

zak-hassan · 2016-07-15T13:15:38Z

Thank you. I'll make some more updates and push fix's to these as well.

jongyoul · 2016-07-15T13:21:57Z

@zmhassan Hi zmhassan. As I mentioned in a JIRA issue, this is in progress by @zjffdu. Could you concede? @zjffdu already contacted me for a few days ago for this issue and I asked for him to work it after I merge ZEPPELIN-1012. I hope he already worked and is waiting for merging ZEPPELIN-1012. Sorry for late reply, and duplicated works.

zak-hassan · 2016-07-15T13:38:08Z

@jongyoul
Sounds good. From what I understand we have to let ZEPPELIN-1012 PR get merged before merging this one, is that correct?

@zjffdu
Is it okay if I complete this work as I've already started? As when I started no one was assigned.

jongyoul · 2016-07-15T13:46:45Z

@zmhassan Thanks for understanding. ZEPPELIN-1012 makes a conflict and this is for beginner thus I don't want for him/her to resolve conflict. @zjffdu Thanks for understanding it.

zak-hassan · 2016-07-16T21:57:32Z

@AhyoungRyu I've made those fix's pending in the ui and docs as well. Just wondering if its possible to trigger travis CI to run the build again as I know my last commit was WIP

AhyoungRyu · 2016-07-17T06:07:07Z

@zmhassan Thanks for your effort! Since ZEPPELIN-1012 was merged, you need to resolve the conflict first. If you need help regarding rebase, please refer to this page. See number 11, 12, 13. It will be helpful to you :)

And most of notebookId that i told were updated but there are more notebookId in jobmanager.controller.js.

https://github.com/apache/zeppelin/blob/master/zeppelin-web/src/app/jobmanager/jobmanager.controller.js#L34

zak-hassan · 2016-07-17T17:06:54Z

Thank you @AhyoungRyu I'm going to fix the rest of jobmanager.controller.js and then rebase.

zak-hassan · 2016-07-17T20:11:06Z

@AhyoungRyu I've fixed the merge conflict and all changed are now in. Let me know if there is anything else left as I think this task is complete.

jongyoul · 2016-07-18T08:53:19Z

zeppelin-server/src/main/java/org/apache/zeppelin/rest/NotebookRestApi.java

-      @PathParam("paragraphId") String paragraphId) throws IOException {
-    LOG.info("get paragraph {} {}", notebookId, paragraphId);
+  public Response getParagraph(@PathParam("noteId") String noteId,
+                               @PathParam("paragraphId") String paragraphId) throws IOException {


Vertical align is not recommended. Could you please revert them including the below?

@zmhassan It's not fixed here.

Thank you @jongyoul ! Let's make sure this and all other style issues are addressed before merging

@bzz Yes, I think it's time to enforce style. :-)

jongyoul · 2016-07-18T08:57:05Z

@zmhassan Hi, could you please check the style? Zeppelin doesn't have any strict style for now, but basically follows google's guide. Could you please check it?

zak-hassan · 2016-07-18T22:56:33Z

Okay all done. I've committed the fix's for this issue. If there is nothing else then I think this task is complete. @jongyoul Thank you so much

jongyoul · 2016-07-19T07:46:54Z

zeppelin-server/src/main/java/org/apache/zeppelin/rest/NotebookRestApi.java

-      throws IOException, CloneNotSupportedException, IllegalArgumentException {
-    LOG.info("clone notebook by JSON {}", message);
-    NewNotebookRequest request = gson.fromJson(message, NewNotebookRequest.class);
+  public Response cloneNote(@PathParam("noteId") String noteId, String message) throws


It's not fixed here. throws would be located in a next line.

jongyoul · 2016-07-19T07:50:43Z

@zmhassan You look like that you don't use formatter in your IDE. Could you please change the formatter setting fit in google style and reformat whole of files you changed?

jongyoul · 2016-08-03T17:53:24Z

@zmhassan Can you handle it soon?

zak-hassan · 2016-08-03T20:26:52Z

@jongyoul Yes. Sorry I got a bit busy.

jongyoul · 2016-08-04T06:00:39Z

@zmhassan Sounds great.

corneadoug · 2016-09-01T07:00:25Z

Hi @zmhassan do you think you will have some time to rebase this PR and fix the indent?

close #83 close #86 close #125 close #133 close #139 close #146 close #193 close #203 close #246 close #262 close #264 close #273 close #291 close #299 close #320 close #347 close #389 close #413 close #423 close #543 close #560 close #658 close #670 close #728 close #765 close #777 close #782 close #783 close #812 close #822 close #841 close #843 close #878 close #884 close #918 close #989 close #1076 close #1135 close #1187 close #1231 close #1304 close #1316 close #1361 close #1385 close #1390 close #1414 close #1422 close #1425 close #1447 close #1458 close #1466 close #1485 close #1492 close #1495 close #1497 close #1536 close #1545 close #1561 close #1577 close #1600 close #1603 close #1678 close #1695 close #1739 close #1748 close #1765 close #1767 close #1776 close #1783 close #1799

Zak Hassan added 2 commits July 17, 2016 15:32

[ZEPPELIN-1163] Change some parameter name properly in NotebookRestApi

5585d44

fixed docs and zeppelin api test and javascript/html files.

519135c

zak-hassan force-pushed the ZEPPELIN-1163 branch from d0ef576 to 519135c Compare July 17, 2016 19:33

fixing pending work in progress and fixing angularjs code.

9e8222d

jongyoul reviewed Jul 18, 2016
View reviewed changes

Fixing check style errors

ea8a346

jongyoul reviewed Jul 19, 2016
View reviewed changes

asfgit closed this in c38a0a0 May 9, 2018

[ZEPPELIN-1163] Change some parameter name properly in NotebookRestApi #1187

[ZEPPELIN-1163] Change some parameter name properly in NotebookRestApi #1187

Uh oh!

Conversation

zak-hassan commented Jul 15, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What is this PR for?

What type of PR is it?

Todos

What is the Jira issue?

How should this be tested?

Screenshots (if appropriate)

Questions:

Uh oh!

AhyoungRyu commented Jul 15, 2016

Uh oh!

zak-hassan commented Jul 15, 2016

Uh oh!

jongyoul commented Jul 15, 2016

Uh oh!

zak-hassan commented Jul 15, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jongyoul commented Jul 15, 2016

Uh oh!

zak-hassan commented Jul 16, 2016

Uh oh!

AhyoungRyu commented Jul 17, 2016

Uh oh!

zak-hassan commented Jul 17, 2016

Uh oh!

zak-hassan commented Jul 17, 2016

Uh oh!

jongyoul Jul 18, 2016

Choose a reason for hiding this comment

Uh oh!

jongyoul Jul 19, 2016

Choose a reason for hiding this comment

Uh oh!

bzz Jul 28, 2016

Choose a reason for hiding this comment

Uh oh!

jongyoul Jul 28, 2016

Choose a reason for hiding this comment

Uh oh!

jongyoul commented Jul 18, 2016

Uh oh!

zak-hassan commented Jul 18, 2016

Uh oh!

jongyoul Jul 19, 2016

Choose a reason for hiding this comment

Uh oh!

jongyoul commented Jul 19, 2016

Uh oh!

jongyoul commented Aug 3, 2016

Uh oh!

zak-hassan commented Aug 3, 2016

Uh oh!

jongyoul commented Aug 4, 2016

Uh oh!

corneadoug commented Sep 1, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

zak-hassan commented Jul 15, 2016 •

edited

Loading

zak-hassan commented Jul 15, 2016 •

edited

Loading