-
Notifications
You must be signed in to change notification settings - Fork 2.8k
[ZEPPELIN-1796] Add 'copy to clipboard' next to the paragraph id #1750
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
zeppelin-web/src/app/app.js
Outdated
| }); | ||
|
|
||
| uiZeroclipConfigProvider.setZcConf({ | ||
| swfPath: '../bower_components/zeroclipboard/dist/ZeroClipboard.swf' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i thought we had a PR with this long time back. is this loading Flash?
|
@felixcheung So I fixed it in here: 616b743. There won't be |
|
Great but the concerns are with dependencies on Flash with this approach
|
|
@felixcheung Yeah you're right. So I changed the library from
And I checked it works well in |
3f6c5af to
8ea78e0
Compare
|
CI has passed now. Ready to review again :) |
|
LGTM! |
|
@felixcheung Yeah that's my plan :D |
|
Will merge into master if there are no more comments then |


What is this PR for?
There are lots of use cases that need to know each
Paragraph Idin Zeppelin.e.g. run paragraph using rest api /
z.angularBind/ export paragraphs using iframe ...So I added
Copy to clipboardbtn next the eachParagraph Idunder paragraph setting menu using angular-zeroclipboard.It'll be useful even if it's small feature :)
What type of PR is it?
Improvement | Feature
What is the Jira issue?
ZEPPELIN-1796
How should this be tested?
npm run buildunderzeppelin-web/npm run startto start dev mode and browsehttp://localhost:9000Screenshots (if appropriate)
Questions: