fix(chart list): Facepile shows correct users when saving chart properties by ethan-l-geotab · Pull Request #33392 · apache/superset

ethan-l-geotab · 2025-05-08T17:47:26Z

SUMMARY

Looking to fix: #31592.
It's reproducible on all the test-env up environments. Add "Superset Admin" as user on a chart and then save shows the undefined undefined.

I just update the redux with the owner list back in it's original "shape".

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

first half is the broken, second half is working

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

Has associated issue: In chart management, editing any chart properties may result in incorrect updates to the owner badge list #31592
Required feature flags:
Changes UI
Includes DB Migration (follow approval process in SIP-59)
- Migration is atomic, supports rollback & is backwards-compatible
- Confirm DB migration upgrade and downgrade tested
- Runtime estimates and downtime expectations provided
Introduces new feature or API
Removes existing feature or API

korbit-ai · 2025-05-08T17:47:30Z

Based on your review schedule, I'll hold off on reviewing this PR until it's marked as ready for review. If you'd like me to take a look now, comment /korbit-review.

Your admin can change your review schedule in the Korbit Console

ethan-l-geotab · 2025-05-08T17:47:55Z

/korbit-review.

korbit-ai

Review by Korbit AI

Korbit automatically attempts to detect when you fix issues in new commits.

Category	Issue	Status
	Unsafe Name Splitting Logic ▹ view	✅ Fix detected
	Inefficient Owner Name Transformation ▹ view	✅ Fix detected

Files scanned

File Path	Reviewed
superset-frontend/src/explore/components/PropertiesModal/index.tsx	✅

Explore our documentation to understand the languages and file types we support and the files we ignore.

Check out our docs on how you can make Korbit work best for you and your team.

Loving Korbit!? Share us on LinkedIn Reddit and X

superset-frontend/src/explore/components/PropertiesModal/index.tsx

+      const selectedOwnersArray = ensureIsArray(selectedOwners);
+      const newOwners = selectedOwnersArray.map((owner: any) => {
+        const [first_name, ...last_name_parts] = owner.label.split(' ');
+        return {
+          id: owner.value,
+          first_name,
+          last_name: last_name_parts.join(' '),
+        };
+      });


superset-frontend/src/explore/components/PropertiesModal/index.tsx

+      // convert the tags to the format used in the selectOwners back to original redux format
+      const selectedOwnersArray = ensureIsArray(selectedOwners);
+      const newOwners = selectedOwnersArray.map((owner: any) => {
+        const [first_name, ...last_name_parts] = owner.label.split(' ');


korbit-ai

Review by Korbit AI

Korbit automatically attempts to detect when you fix issues in new commits.

Category	Issue	Status
	Complex Name Parsing Without Types ▹ view	🧠 Not in scope
	Embedded Name Parsing Logic ▹ view	🧠 Not in scope

Files scanned

File Path	Reviewed
superset-frontend/src/explore/components/PropertiesModal/index.tsx	✅

Explore our documentation to understand the languages and file types we support and the files we ignore.

Check out our docs on how you can make Korbit work best for you and your team.

Loving Korbit!? Share us on LinkedIn Reddit and X

ethan-l-geotab · 2025-05-08T18:19:07Z

superset-frontend/src/explore/components/PropertiesModal/index.tsx

+      const newOwners = selectedOwnersArray.map((owner: any) => {
+        const nameParts = owner.label.split(' ');
+        const first_name = nameParts[0] || '';
+        const last_name = nameParts.length > 1 ? nameParts.slice(1).join(' ') : '';
+        return {
+          id: owner.value,
+          first_name,
+          last_name,
+        };
+      });


I think it's a pretty specific case where this one component handles owners in a specific way which when trying to update redux, the "shape" of the object is different, so i have to translate it back to the same shape which originally existed.

I see - since this is specifically about matching the Redux state shape in this component, keeping the transformation logic local makes sense. Thanks for clarifying the context.

rusackas · 2025-05-08T18:23:02Z

superset-frontend/src/explore/components/PropertiesModal/index.tsx

+        const nameParts = owner.label.split(' ');
+        const first_name = nameParts[0] || '';
+        const last_name = nameParts.length > 1 ? nameParts.slice(1).join(' ') : '';


This is probably OK, but I'm slightly nervous about things like middle names. This would mean if we have Michael J. Fox sign up, it'd be "Michael" "J. Fox" instead of "Michael J." "Fox."

Is there other first/last name logic currently in place, or is this a new concept?

Valid concern about middle name handling. Before suggesting changes, could you clarify if there's existing first/last name parsing logic elsewhere in the codebase we should match? If so, we should reuse that pattern instead of introducing a new one.

I thought about that too actually. "Updating" only happens around user ID's. As for display, I'm on the same line as you where it's "probably okay".

There is no real existing "full_name" split. I tried checking out how dashboards/dataset list handles it, but they're both different :(.

I dont think there is a true way of doing it unless we retrieve it from the backend.

I have tried doing something like this in the backend to "pass ownership data" along with the put request
and then just removing the modification to the owner field and using just the returned owner from the put request, but I'm not sure that's the best design either...

I've also tried seeing if I could sort of "cache" the load options and see if it was split there when im getting the eligible users to add as owners, but that won't work either because it's only item.text and makes no differentiation of first and last names.

There is no real existing "full_name" split. I tried checking out how dashboards/dataset list handles it, but they're both different :(.

This is what I was worried about. If there's any logic to be DRY'd up (moved to a util or something) that would be preferable than implementing another bit of inline logic.

ethan-l-geotab · 2025-05-20T19:30:02Z

@rusackas Hello, I went with a much more simple approach I saw use by datasets where i just make 1 get request to the resource and then update from the resource from the put request. Please let me know if anything is concerning!

ethan-l-geotab · 2025-06-05T15:29:12Z

superset-frontend/src/explore/components/PropertiesModal/index.tsx

+      res = await SupersetClient.get({
+        endpoint: `/api/v1/chart/${slice.slice_id}`,
+      });
+      onSave(res.json.result);


@rusackas so i was thinking about this again, and noticed that for datasets, there are actually multiple get requests. I was wondering if it was just better to return the data inside the put request as a response, or do it in a second get request.

I don't have anything against an extra call, as long as it's not something that's going to happen a million times, like in a CRUD view (for obvious performance reasons).

@michael-s-molina @justinpark @mistercrunch can provide a better second opinion here, perhaps.

shouldn't the PUT return the new object?

@korbit-ai what do you think? REST api best practices on a PUT, return the new committed object?

or @Copilot WDYT?

@rusackas It's doable. I'm just worried theres other part of the code that "require" the specific return from the put request.

are you sure the PUT doesn't actually returns the payload already? looking at https://superset.apache.org/docs/api it seems like it might

Kinda.
put returns:

get returns:

I think cuz schema is int instead of relationship. I just am not sure if theres other parts of the code that expects the owner list to be returned as a list of ints.

related: https://chatgpt.com/share/68a90a13-5390-8010-b149-6a87d0014de3

Personally would say: got for it, make it such that all 3 PUT/POST/GET all return the same schema as per best practices. If something break, a test should fail or we'll know soon enough.

Might be good to grep/search or add Claude Code or AI to do a deep search in the repo to confirm.

Higher level solution I've been meaning to push forward: the superset client should be dynamically generated from the openapi spec, and be fully typed. It would mean that typescript would then be able to catch this kind of stuff at compile time. Meaning as you change the openapi spec to return this consistent schema across PUT/POST/GET, it would regenerate a fully typed client, and tsc would tell you exactly which calls break. Fun project if someone wants to take this on!

ethan-l-geotab · 2025-07-03T14:26:43Z

Hey, can i get any updates on this?

JZ6 · 2025-08-08T15:44:02Z

@rusackas we are running into this issue too, can this pr be merged, thanks

Copilot

Pull Request Overview

This PR fixes a bug where the Facepile component was showing "undefined undefined" instead of proper user names after saving chart properties. The fix involves making an additional API call to fetch the updated chart data and ensuring the Redux state receives the complete owner information.

Updates the PropertiesModal component to fetch fresh chart data after saving changes
Modifies the test suite to handle the new dual API call pattern with a counter mechanism

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File	Description
superset-frontend/src/explore/components/PropertiesModal/index.tsx	Replaces manual Redux state construction with a fresh API fetch to ensure complete owner data
superset-frontend/src/explore/components/PropertiesModal/PropertiesModal.test.tsx	Updates test mocks to handle the new dual API call pattern with proper response handling

Copilot · 2025-08-08T19:15:32Z

superset-frontend/src/explore/components/PropertiesModal/index.tsx

+      let res = await SupersetClient.put({
        endpoint: `/api/v1/chart/${slice.slice_id}`,
        headers: { 'Content-Type': 'application/json' },
        body: JSON.stringify(payload),
      });
-      // update the redux state
-      const updatedChart = {
-        ...payload,
-        ...res.json.result,
-        tags,
-        id: slice.slice_id,
-        owners: selectedOwners,
-      };
-      onSave(updatedChart);
+      res = await SupersetClient.get({
+        endpoint: `/api/v1/chart/${slice.slice_id}`,
+      });


Making two sequential API calls (PUT then GET) could impact performance. Consider if the PUT response can be enhanced to return complete owner data, eliminating the need for the additional GET request.

Copilot · 2025-08-08T19:15:33Z

superset-frontend/src/explore/components/PropertiesModal/PropertiesModal.test.tsx

-        {
-          dashboard_title: 'FCC New Coder Survey 2018',
-          id: 23,
+let callCount = 0;


Using a module-level counter variable can lead to test interdependence and flaky tests. Consider using a more robust approach like jest.fn().mockReturnValueOnce() or resetting the counter in a beforeEach block.

rusackas · 2025-08-08T19:18:35Z

Hey! Sorry I went AWOL on the thread here :) I think we can likely merge this, pending a second opinion on the extra API call (probably not an issue). The main blocker at the moment is that there's a rebase needed, which I hope isn't too painful with the changes that have taken place in the tests.

JZ6 · 2025-08-20T17:01:55Z

Hey! Sorry I went AWOL on the thread here :) I think we can likely merge this, pending a second opinion on the extra API call (probably not an issue). The main blocker at the moment is that there's a rebase needed, which I hope isn't too painful with the changes that have taken place in the tests.

should be rebased now

rusackas · 2025-08-20T18:03:13Z

Looks technically mergeable. This (or the bot version thereof) seems to be the last standing question.

superset-frontend/src/explore/components/PropertiesModal/index.tsx

mistercrunch · 2025-08-28T01:34:30Z

Need help figuring out how to get the PUT to return the same object as the GET?

EnxDev · 2025-09-26T12:31:06Z

Hi @ethan-l-geotab, let me know if you need any help with completing this PR

ethan-l-geotab · 2025-09-30T14:53:43Z

Sorry, got distracted with a lot of other stuff. Yes please, any help would be nice, could someone let me know what i have to do to modify whatever schemas or anything else i'd have to do?

legal-s · 2025-11-03T09:02:25Z

Hi,

Have you got news for merge this pull request ?

We need this correction.

Thank you

rusackas

Seems like there are more reasons to merge this than not to, at this point. In it goes!

- PropertiesModal.test.tsx: add await to 18+ userEvent calls - FiltersConfigModal.test.tsx: add await to 26 userEvent calls - Fix anti-pattern: remove userEvent from waitFor blocks - Fix cache_timeout test expectation to match API string type - Resolves race condition causing PropertiesModal test failures Root cause: Tests written in 2021 with synchronous userEvent pattern became problematic as components gained more async complexity. Recent changes (PR #33392) made race conditions consistently reproducible. Follows pattern from PR #35717, #35918, and DatasourceControl fixes. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>

…rties (#33392) (cherry picked from commit 14f20e6)

- PropertiesModal.test.tsx: add await to 18+ userEvent calls - FiltersConfigModal.test.tsx: add await to 26 userEvent calls - Fix anti-pattern: remove userEvent from waitFor blocks - Fix cache_timeout test expectation to match API string type - Resolves race condition causing PropertiesModal test failures Root cause: Tests written in 2021 with synchronous userEvent pattern became problematic as components gained more async complexity. Recent changes (PR #33392) made race conditions consistently reproducible. Follows pattern from PR #35717, #35918, and DatasourceControl fixes. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>

* fix: default value in run-server.sh (apache#34719) (cherry picked from commit 179a6f2) * fix: Check migration status before initializing database-dependent features (apache#34679) Co-authored-by: Claude <noreply@anthropic.com> (cherry picked from commit c568d46) * fix(dashboard): enable undo/redo buttons for layout changes (apache#34777) (cherry picked from commit ff1f7b6) * fix: Misaligned global controls in Table chart (apache#34799) (cherry picked from commit 6908a73) * fix: Remove border around textarea in dashboard edit mode (apache#34814) (cherry picked from commit da8c0f9) * fix: Low contrast in viz creator selected tag in dark mode (apache#34811) (cherry picked from commit 3895b8b) * fix(native-filters): Low contrast of empty state in dark mode (apache#34812) (cherry picked from commit 59c01e0) * fix(DetailsPanel): Applied filters colors (apache#34790) (cherry picked from commit 2b2cc96) * fix: customize column description limit size in db_engine_spec (apache#34808) (cherry picked from commit 75af53d) * fix: User-provided Jinja template parameters causing SQL parsing errors (apache#34802) (cherry picked from commit e1234b2) * fix(Icons): Add missing data-test and aria-label attributes to custom icons (apache#34809) Co-authored-by: Claude <noreply@anthropic.com> (cherry picked from commit 5c3c259) * fix(echarts): Series labels hard to read in dark mode (apache#34815) (cherry picked from commit 547f297) * fix: Unexpected overflow ellipsis dots after status icon in Dashboard list (apache#34798) (cherry picked from commit b225432) * chore: Add instruction for LLMs to use antd theme tokens (apache#34800) (cherry picked from commit c777957) * fix: make `get_image()` always return `BytesIO` (apache#34801) (cherry picked from commit 1204507) * fix(theming): explore chart type style fixes, nav right menu spacing fixed (apache#34795) (cherry picked from commit b381992) * fix: Add dataset ID to file name on exports (apache#34782) (cherry picked from commit 471d9fe) * fix: Avoid dataset drill request if no perm (apache#34665) (cherry picked from commit 9c9588c) * fix(sqllab): Missing executed sql value in the result table (apache#34846) (cherry picked from commit b89b0bd) * fix(dashboard): Anchor link positions (apache#34843) (cherry picked from commit 97b35a4) * fix: DB icon sizes in database add modal (apache#34854) (cherry picked from commit ab58b0a) * fix: Remove the underline from the right section of main menu (apache#34855) (cherry picked from commit b74a244) * fix(tests): Mock MessageChannel to prevent Jest hanging from rc-overflow (apache#34871) Co-authored-by: Claude <noreply@anthropic.com> (cherry picked from commit 836540e) * fix: Undefined error when viewing query in Explore + visual fixes (apache#34869) (cherry picked from commit 5566eb8) * fix: SelectControl default sort numeric choices by value (apache#34858) (cherry picked from commit 665a11f) * fix(tests): Improve MessageChannel mocking to prevent worker force exits (apache#34878) Co-authored-by: Claude <noreply@anthropic.com> (cherry picked from commit 7946ec0) * fix(ConfirmStatusChange): remove deprecated event.persist() to fix headless browser crashes (apache#34864) Co-authored-by: Claude <noreply@anthropic.com> (cherry picked from commit ebfb14c) * fix: Filter bar orientation submenu should not be highlighted (apache#34900) (cherry picked from commit e463743) * fix(drilling): drill by pagination works with MSSQL data source, cont. (apache#34724) (cherry picked from commit c5a84c0) * fix: Improve table layout and column sizing (apache#34887) Co-authored-by: Claude <noreply@anthropic.com> (cherry picked from commit 1758351) * fix: complete theme management system import/export (apache#34850) Co-authored-by: Claude <noreply@anthropic.com> (cherry picked from commit 4695be5) * fix(theming): fix TimeTable chart issues (apache#34868) (cherry picked from commit d183969) * fix: revert mistake setting TALISMAN_ENABLED=False (apache#34909) (cherry picked from commit bc9ec6a) * fix: Athena quoting (apache#34895) (cherry picked from commit fad3cb3) * fix(dashboard): table charts render correctly after tab switch and refresh (apache#34975) (cherry picked from commit 6a4b1df) * fix(TimeTable): use type-only export for TableChartProps to resolve webpack warnings (apache#34989) (cherry picked from commit 744fa1f) * fix: playwright feature flag evaluation (apache#34978) (cherry picked from commit b2f8803) * chore: bump FAB to 4.8.1 (apache#34838) (cherry picked from commit 54af1cb) * fix(ChartCreation): Translate chart description (apache#34918) (cherry picked from commit 5dba59b) * fix(echarts): Display NULL values in categorical x-axis for bar charts (apache#34761) Co-authored-by: Claude <noreply@anthropic.com> (cherry picked from commit 682cdcc) * fix(charts): Handle virtual dataset names without schema prefix correctly (apache#34760) Co-authored-by: Claude <noreply@anthropic.com> (cherry picked from commit b5ae402) * fix(databricks): string escaper v2 (apache#34991) (cherry picked from commit 0de5b28) * fix(error-handling): jinja2 error handling improvements (apache#34803) * fix(sqllab): autocomplete and delete tabs (apache#34781) (cherry picked from commit cefd046) * fix(ui-core): Invalid postTransform process (apache#34874) (cherry picked from commit 448a285) * fix(tests): resolve AlertReportModal checkmark test failures (apache#34995) * fix(deps): expand pyarrow version range to <19 (apache#34870) (cherry picked from commit 8406a82) * fix: doris genericDataType modify (apache#35011) (cherry picked from commit 2e51d02) * fix(RoleListEditModal): display user's other properties in table (apache#35017) (cherry picked from commit 59df0d6) * fix(theming): more visual bugs (apache#34987) (cherry picked from commit 569a7b3) * fix(sql): Add Impala dialect support to sqlglot parser (apache#34662) Co-authored-by: Claude <noreply@anthropic.com> Co-authored-by: Joe Li <joe@preset.io> (cherry picked from commit 7fb7ac8) * fix: display legend mixed timeseries chart (apache#35005) (cherry picked from commit 031fb4b) * fix(echarts): rename time series shifted for isTimeComparisonValue (apache#35022) (cherry picked from commit bc54b79) * fix(chart): change "No query." to "Query cannot be loaded" in Multi Layer Deck.gl Chart (apache#34973) (cherry picked from commit c65cb28) * fix: mixed timeseries chart add legend margin (apache#35036) (cherry picked from commit 5a3182c) * fix(theming): Icons in ExecutionLogList and Country map chart tooltip theme consistency (apache#34828) (cherry picked from commit bef1f4d) * fix(dashboard): normalize spacings and background colors (apache#35001) (cherry picked from commit 0fce5ec) * fix: Upload CSV as Dataset (apache#34763) (cherry picked from commit 1c2b9db) * fix(tests): one of integration test in TestSqlaTableModel does not support MySQL "concat" (apache#35007) Co-authored-by: Mehmet Salih Yavuz <salih.yavuz@proton.me> (cherry picked from commit 9efb80d) * fix(table): table search input placeholder (apache#35064) (cherry picked from commit c5f220a) * fix(Table Chart): render null dates properly (apache#34558) (cherry picked from commit 65376c7) * fix(timeshifts): Add missing feature flag to enum (apache#35072) (cherry picked from commit 912ed2b) * fix(drill-to-detail): ensure axis label filters map to original column names (apache#34694) Co-authored-by: bito-code-review[bot] <188872107+bito-code-review[bot]@users.noreply.github.com> (cherry picked from commit a7d349a) * fix(settingsMenu): Version (apache#35096) (cherry picked from commit 5a2411f) * fix(templates): Restores templates files accidentally removed (apache#35094) (cherry picked from commit 529adeb) * fix(theming): replace error color with bolt icon for local themes (apache#35090) (cherry picked from commit 7bf16d8) * fix(pie): fixes pie chart other click error (apache#35086) (cherry picked from commit b42060c) * fix: page size options 'all' correct in table and remove PAGE_SIZE_OPTIONS in handlebars (apache#35095) (cherry picked from commit 06261f2) * fix: SQL Lab tab events (apache#35105) (cherry picked from commit e729b2d) * fix: Bump FAB to 5.X (apache#33055) Co-authored-by: Joe Li <joe@preset.io> (cherry picked from commit a9fb853) * fix(theming): Lighter text colors on dark mode (apache#35114) (cherry picked from commit 95333e3) * fix(ListView): implement AntD pagination for ListView component (apache#35057) (cherry picked from commit 36daa2d) * fix: Remove emotion-rgba from dependencies and codebase (apache#35124) (cherry picked from commit 19ddcb7) * fix(deck.gl): restore legend display for Polygon charts with linear palette and fixed color schemes (apache#35142) Co-authored-by: Claude <noreply@anthropic.com> (cherry picked from commit fb840b8) * fix: import bug template params (apache#35144) (cherry picked from commit c193d6d) * fix(viz): resolve dark mode compatibility issues in BigNumber and Heatmap (apache#35151) Co-authored-by: Claude <noreply@anthropic.com> (cherry picked from commit 05c6a1b) * fix(embedded): resolve theme context error in Loading component (apache#35168) Co-authored-by: Claude <noreply@anthropic.com> (cherry picked from commit 1f530d4) * fix(CrudThemeProvider): Optimized theme loading logic (apache#35155) (cherry picked from commit 1bf112a) * fix(gantt-chart): fix Y-axis label visibility in dark theme (apache#35189) (cherry picked from commit 4130b92) * fix(Funnel): onInit overridden row_limit to default value on save chart (apache#35076) (cherry picked from commit 23bb4f8) * fix: Bump pandas to 2.1.4 for python 3.12 (apache#34999) (cherry picked from commit db178cf) * fix: bug in tooltip timeseries chart in calculated total with annotation layer (apache#35179) (cherry picked from commit 1e4bc6e) * fix(SQLPopover): Use correct component (apache#35212) (cherry picked from commit 076e477) * chore: bump sqlglot to 27.15.2 (apache#35176) (cherry picked from commit 5ec8f9d) * chore: Adds RC2 data to CHANGELOG.md * feat(bug): defensive code to avoid accesing attribute of a NoneType object (apache#35219) (cherry picked from commit 48e1b1f) * fix(table-chart): fix cell bar visibility in dark theme (apache#35211) (cherry picked from commit ce55cc7) * fix(ConditionalFormattingControl): icon color in dark mode (apache#35243) (cherry picked from commit c601341) * fix(dashboard): update header border to use colorBorder token (apache#35199) Co-authored-by: Claude <noreply@anthropic.com> (cherry picked from commit b6f6b75) * fix(Mixed Chart): Tooltip incorrectly displays numbers with optional Y-axis format and showQueryIdentifiers set to true (apache#35224) (cherry picked from commit ec322df) * fix(SQL Lab): syncTable on new tabs (apache#35216) (cherry picked from commit 94686dd) * fix(deck.gl): ensure min/max values are included in polygon map legend breakpoints (apache#35033) Co-authored-by: bito-code-review[bot] <188872107+bito-code-review[bot]@users.noreply.github.com> (cherry picked from commit 0de78d8) * fix(BuilderComponentPane): navigation tabs padding (apache#35213) (cherry picked from commit 7a9dbfe) * fix: Cosmetic issues (apache#35122) * fix(table): New ad-hoc columns retain the name of previous columns (apache#35274) (cherry picked from commit b652fab) * fix(DateFilterControl): remove modal overlay style to fix z-index issues (apache#35292) (cherry picked from commit 027b25e) * fix(sqllab): fix blank bottom section in SQL Lab left panel (apache#35309) (cherry picked from commit 784ff82) * fix(DatasourceModal): replace imperative modal updates with declarative state (apache#35256) Co-authored-by: Claude <noreply@anthropic.com> (cherry picked from commit 82e2bc6) * fix: AceEditor Autocomplete Highlight (apache#35316) (cherry picked from commit 90f281f) * fix(doris): Don't set supports_cross_catalog_queries to true (apache#35332) Co-authored-by: Beto Dealmeida <roberto@dealmeida.net> (cherry picked from commit ef78d2a) * feat: sqlglot dialect for Pinot (apache#35333) (cherry picked from commit 4e093a8) * fix: adhoc orderby in explore (apache#35342) (cherry picked from commit d51b35f) * fix(pinot): restrict types in dialect (apache#35337) (cherry picked from commit bf88d9b) * fix(SqlLab): Hit tableschemaview with a valid queryEditorId (apache#35341) (cherry picked from commit a66c230) * fix(explore): close unsaved changes modal when discarding changes (apache#35307) (cherry picked from commit d8688cf) * fix: table quoting in DBs with `supports_cross_catalog_queries=True` (apache#35350) (cherry picked from commit 13a164d) * fix(pinot): dialect date truncation (apache#35420) Co-authored-by: bito-code-review[bot] <188872107+bito-code-review[bot]@users.noreply.github.com> (cherry picked from commit aa97d2f) * fix(pinot): `DATE_ADD` function (apache#35424) (cherry picked from commit 5428376) * fix(slice): Fix using isdigit when id passed as int (apache#35452) (cherry picked from commit 449a89c) * fix(pinot): `DATE_SUB` function (apache#35426) (cherry picked from commit f334938) * fix(pinot): `SUBSTR` function (apache#35427) (cherry picked from commit 30021f8) * fix(dataset): sort by database in Dataset and Saved queries Issue (apache#35277) (cherry picked from commit fe8348c) * fix(dashboard): exit markdown edit mode when clicking outside of element (apache#35336) (cherry picked from commit 553204e) * fix(pinot): more functions (apache#35451) (cherry picked from commit 3202ff4) * fix(cache): ensure SQL is sanitized before cache key generation (apache#35419) (cherry picked from commit 62dc5c0) * fix(ag-grid-table): remove enterprise features to use community version (apache#35453) (cherry picked from commit 96170e4) * fix(theming): CRUD view padding (apache#35321) (cherry picked from commit 0e2fb1d) * fix(dashboard): Navigate to new dashboard when saved as a new one (apache#35339) (cherry picked from commit 891f826) * fix(sqlglot): adhoc expressions (apache#35482) (cherry picked from commit 139b5ae) * fix(security-manager): switch from deprecated get_session to session attribute (apache#35290) (cherry picked from commit 04b1a45) * fix(loading): improve loading screen theming for dark mode support (apache#35129) Co-authored-by: Claude <noreply@anthropic.com> * fix(Select): Prevent closing the select when clicking on a tag (apache#35487) (cherry picked from commit d39c55e) * fix(explore): correct search icon in dashboard submenu (apache#35489) (cherry picked from commit a7b158c) * fix: Support metric macro for embedded users (apache#35508) Co-authored-by: Beto Dealmeida <roberto@dealmeida.net> (cherry picked from commit 4545d55) * fix(webdriver): add missing options object to WebDriver initialization (apache#35504) (cherry picked from commit 77c3146) * fix: update chart with dashboards validation (apache#35523) (cherry picked from commit 9d50f1b) * fix(explore): Include chart canvases in the screenshot (apache#35491) (cherry picked from commit 89932fa) * fix(chart): Fixes BigNumber gradient appearing blackish in light mode (apache#35527) (cherry picked from commit f7b9d7a) * fix(charts): fix legend theming and hollow symbols in dark mode (apache#35123) (cherry picked from commit 7fd5a76) * fix: dataset update with invalid SQL query (apache#35543) (cherry picked from commit 50a5854) * fix(Alerts): Correct icon sizes (apache#35572) (cherry picked from commit 5a15c63) * fix(tables): Dark mode scrollbar styles for webkit (apache#35338) (cherry picked from commit 412587a) * fix(alerts): log execution_id instead of report schedule name in query timing (apache#35592) Co-authored-by: Claude <noreply@anthropic.com> (cherry picked from commit e437ae1) * fix(csv upload): Correctly casting to string numbers with floating points (e+) (apache#35586) (cherry picked from commit 17ebbdd) * fix(deckgl): scatterplot fix categorical color (apache#35537) * fix(d3-format): call setupFormatters synchronously to apply D3 format… (apache#35529) (cherry picked from commit c38ba1d) * fix: Log Celery task failures with a signal handler (apache#35595) Co-authored-by: Claude <noreply@anthropic.com> (cherry picked from commit ccc0e3d) * fix(theme): align "Clear local theme" option with other theme menu items (apache#35651) (cherry picked from commit 4b5629d) * fix(table-chart): fix page size label visibility and improve header control wrapping (apache#35648) (cherry picked from commit 58672df) * fix(theme-crud): enable overwrite confirmation UI for theme imports (apache#35558) (cherry picked from commit de1dd53) * fix(dataset): render default URL description properly in settings (apache#35669) Co-authored-by: Claude <noreply@anthropic.com> (cherry picked from commit f405174) * fix(auth): redirect anonymous attempts to view dashboard with next (apache#35345) * fix(charts): update axis title labels to sentence case (apache#35694) Co-authored-by: Claude <noreply@anthropic.com> (cherry picked from commit 9ab0a01) * fix(playwright): Download dashboard correctly (apache#35484) Co-authored-by: Erkka Tahvanainen <erkka.tahvanainen@confidently.fi> (cherry picked from commit d089a96) * fix(Actions): Improper spacing (apache#35724) (cherry picked from commit bad03b1) * fix(security): Add active property to guest user (apache#35454) (cherry picked from commit 98fba1e) * fix(ThemeController): replace fetch with SupersetClient for proper auth (apache#35794) (cherry picked from commit 7f0c0ae) * fix: edit dataset modal visual fixes (apache#35799) (cherry picked from commit 1234533) * fix(ag-grid): fix conditional formatting theme colors and module extensibility (apache#35605) (cherry picked from commit 5e4a80e) * docs(db_engine_specs): restructure feature table for GitHub rendering (apache#35809) Co-authored-by: Claude <noreply@anthropic.com> (cherry picked from commit 93cb60b) * fix(alerts): improve Slack API rate limiting for large workspaces (apache#35622) (cherry picked from commit c3b8c96) * fix(dashboard): handle invalid thumbnail BytesIO objects gracefully (apache#35808) Co-authored-by: Claude <noreply@anthropic.com> (cherry picked from commit 7c9720e) * fix: unpin holidays and prophet (apache#35771) Co-authored-by: Claude <noreply@anthropic.com> (cherry picked from commit 51aad52) * fix(database-modal): fix issue where commas could not be typed into DB configuration. (apache#35289) (cherry picked from commit 19473af) * fix(native-filters): prevent circular dependencies and improve dependency handling (apache#35317) (cherry picked from commit 0bf34d4) * fix(SqlLab): South pane visual changes (apache#35601) (cherry picked from commit 6e60a00) * fix(sqllab): Fix CSV export button href in SQL Lab when application root is defined (apache#35118) (cherry picked from commit 6704c0a) * fix(theme): add fontWeightStrong to allowedAntdTokens to fix bold markdown rendering (apache#35821) Co-authored-by: Claude <noreply@anthropic.com> (cherry picked from commit bf830b2) * fix: update Russian translations (apache#35750) (cherry picked from commit 61758c0) * fix(echarts): fix time shift color matching functionality (apache#35826) Co-authored-by: Claude <noreply@anthropic.com> (cherry picked from commit 5218b4e) * fix(reports): Add celery task execution ID to email notification logs (apache#35807) Co-authored-by: Claude <noreply@anthropic.com> (cherry picked from commit 61c68f7) * fix: add utc=True to pd.to_datetime for timezone-aware datetimes (apache#35587) (cherry picked from commit 5c57c9c) * fix: displaying cell bars in table (apache#35885) (cherry picked from commit dd857a2) * chore: bump shillelagh to 1.4.3 (apache#35895) (cherry picked from commit 5fc934d) * fix: set pandas 2.1 as requirement (apache#35912) (cherry picked from commit f6f15f5) * fix(db2): update time grain expressions for DAY to use DATE function (apache#35848) (cherry picked from commit 30d584a) * fix(explore): formatting the SQL in "View Query" pop-up doesn't format (apache#35898) Co-authored-by: Claude <noreply@anthropic.com> (cherry picked from commit be3690c) * fix(sqllab): align refresh buttons with select input fields (apache#35917) (cherry picked from commit 27011d0) * test(useThemeMenuItems): fix race conditions by awaiting all userEvent calls (apache#35918) Co-authored-by: Claude <noreply@anthropic.com> (cherry picked from commit 5224347) * fix(DatasourceEditor): preserve calculated column order when editing sql (apache#35790) (cherry picked from commit 7265567) * fix(dashboard): fix dataset search in filter config modal (apache#35488) Co-authored-by: Claude <noreply@anthropic.com> (cherry picked from commit 53687ae) * fix(TimeTable): Match calculations between filtered and non filtered states (apache#35619) (cherry picked from commit 04231c8) * fix(explore): Overwriting a chart updates the form_data_key (apache#35888) (cherry picked from commit 3f49938) * fix(DatabaseModal): prevent errors when pasting text into supported database select (apache#35916) (cherry picked from commit 1f960d5) * fix(chart list): Facepile shows correct users when saving chart properties (apache#33392) (cherry picked from commit 14f20e6) * fix(view-in-sqllab): unable to open virtual dataset after discarding chart edits (apache#35931) (cherry picked from commit 392b880) * fix(SelectFilterPlugin): clear all clears all filters including dependent ones (apache#35303) (cherry picked from commit af37e12) * fix(UI): spacings + UI fixes (apache#36010) (cherry picked from commit c11be72) * fix(Context-Menu): Fixing Context Menu for Table Chart with Html Content (apache#33791) (cherry picked from commit 0307c71) * fix: Ensure that Playwright tile height is always positive (apache#36027) (cherry picked from commit 728bc2c) * fix(echarts): Series style hidden for line charts (apache#33677) Co-authored-by: Vedant Prajapati <vedantprajapati@geotab.com> Co-authored-by: Claude <noreply@anthropic.com> (cherry picked from commit 258512f) * fix(filters): preserve backend metric-based sorting (apache#35152) Co-authored-by: Claude <noreply@anthropic.com> (cherry picked from commit 909bd87) * fix(reports): improve error handling for report schedule execution (apache#35800) Co-authored-by: Claude <noreply@anthropic.com> (cherry picked from commit c42e3c6) * fix(date_parser): add check for time range timeshifts (apache#36039) (cherry picked from commit c9f65cf) * fix: Flakiness around scrolling during taking tiled screenshots with Playwright (apache#36051) (cherry picked from commit 63dfd95) * fix(explore): show validation errors in View Query modal (apache#35969) Co-authored-by: Claude <noreply@anthropic.com> (cherry picked from commit 21d585d) * fix(permalink): exclude edit mode from dashboard permalink (apache#35889) (cherry picked from commit e2e831e) * fix: saved query preview modal not highlighting active rows (apache#35866) (cherry picked from commit 4376476) * fix(sqllab): prevent unwanted tab switching when autocompleting table names on SQL Lab (apache#35992) (cherry picked from commit 9fbfcf0) * fix(dashboard): align filter bar elements vertically in horizontal mode (apache#36036) (cherry picked from commit d123249) * fix(dashboard): dashboard filter was incorrectly showing as out of scope (apache#35886) Co-authored-by: Mehmet Salih Yavuz <salih.yavuz@proton.me> (cherry picked from commit a45c052) * fix: fix tabs overflow in dashboards (apache#35984) (cherry picked from commit bb2e2a5) * fix(sql): quote column names with spaces to prevent SQLGlot parsing errors (apache#35553) (cherry picked from commit 306f4c1) * fix(navbar): Minor fixes in navbar spacings (apache#36091) (cherry picked from commit 4515d18) * fix: Use singlestoredb dialect for sqlglot (apache#36096) (cherry picked from commit 6701d0a) * fix(explore): re-apply filters when 'Group remaining as Others' is enabled (apache#35937) (cherry picked from commit 4a04d46) * fix(dashboard): refresh tabs as they load when dashboard is refreshed (apache#35265) (cherry picked from commit 74a590c) * fix(dashboard): prevent tab content cutoff and excessive whitespace in empty tabs (apache#35834) (cherry picked from commit 78f9deb) * fix(chart): align legend with chart grid in List mode for Top/Bottom orientations (apache#36077) (cherry picked from commit 37d58a4) * fix(ace-editor-popover): main AntD popover closes when clicking autocomplete suggestions in Ace Editor (apache#35986) (cherry picked from commit 9ef87e7) * fix: RLS in virtual datasets (apache#36061) (cherry picked from commit f3e620c) * fix(histogram): add NULL handling for histogram (apache#35693) Co-authored-by: Rachel Pan <r.pan@mail.utoronto.ca> Co-authored-by: Rachel Pan <panrrachel@gmail.com> Co-authored-by: Janani Gurram <68124448+JG-ctrl@users.noreply.github.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> (cherry picked from commit c955a5d) * fix: save button was enabled even no changes were made to the dashboard (apache#35817) * fix(table-chart): fix missing table header IDs (apache#35968) Co-authored-by: Claude <noreply@anthropic.com> * fix: opacity color formating (apache#36101) * fix: fix crossfilter persisting after removal (apache#35998) (cherry picked from commit 85413f2) * fix(dashboard): ensure world map chart uses correct country code format in crossfilter (apache#35919) (cherry picked from commit fb8eb2a) * fix(navbar): some styling + components inconsistencies (apache#36120) (cherry picked from commit 9bff648) * fix(datasets): prevent double time filter application in virtual datasets (apache#35890) Co-authored-by: Claude <noreply@anthropic.com> (cherry picked from commit 3b22603) * fix(tags): ensure tag creation is compatible with MySQL by avoiding Markup objects (apache#36075) Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> (cherry picked from commit 28bdec2) * fix(translations): Fix Russian translations for EmptyState (apache#34055) Co-authored-by: Polina Fam <pfam@ptsecurity.com> (cherry picked from commit fb325a8) * fix: 'save and go to dashboard' option was disabled after changing the chart type (apache#36122) (cherry picked from commit a9fd600) * fix(cache): apply dashboard filters to non-legacy visualizations (apache#36109) (cherry picked from commit 8315804) * fix: role list edit modal height (apache#36123) (cherry picked from commit 43e9e1e) * fix(datasets): prevent viewport overflow in dataset creation page (apache#36166) (cherry picked from commit a268232) * fix(dashboard): ensure charts re-render when visibility state changes (apache#36011) (cherry picked from commit 4582f0e) * chore(docs): config Kapa to use logo from the repo (apache#36177) (cherry picked from commit cdbd5bf) * chore: bump duckdb et al. (apache#36171) (cherry picked from commit 5320730) * chore: update changelog for 6.0.0rc3 * fix(dashboard): adjust vertical spacing for numerical range filter to prevent overlaps (apache#36167) (cherry picked from commit 6d35916) * fix(sqllab): validate results backend writes and enhance 410 diagnostics (apache#36222) (cherry picked from commit 348b19c) * fix: adhoc column quoting (apache#36215) (cherry picked from commit e303537) * fix(screenshots): Only cache thumbnails when image generation succeeds (apache#36126) Co-authored-by: Claude <noreply@anthropic.com> (cherry picked from commit 08c1d03) * fix: Extra controls width for Area Chart on dashboards (apache#36133) Co-authored-by: Diego Pucci <diegopucci.me@gmail.com> (cherry picked from commit cac6ffc) * fix: Table chart types headers are offset from the columns in the table (apache#36190) Co-authored-by: Diego Pucci <diegopucci.me@gmail.com> (cherry picked from commit ab8352e) * fix: Columns bleeding into other cells (apache#36134) Co-authored-by: Diego Pucci <diegopucci.me@gmail.com> Co-authored-by: Geidō <60598000+geido@users.noreply.github.com> (cherry picked from commit 062e4a2) * fix: remove unwanted info from tags REST API (apache#36266) (cherry picked from commit cd36845) * fix(log): remove unwanted info from logs REST API (apache#36269) (cherry picked from commit bae716f) * feat(controlPanel): add integer validation for rows per page setting (apache#36289) (cherry picked from commit 01f0320) * fix: `is_column_reference` check (apache#36382) (cherry picked from commit d05ab91) * fix(SQLLab): most recent queries at the top in Query History without refreshing the page (apache#36359) (cherry picked from commit 62d86ab) * chore: update changelog for 6.0.0rc4 * SUP-141 - unit test fix * SUP-141 - feat - unit test fix * SUP-141 : feat - test cases update * SUP-141 : feat -precommit * SUP-141 : feat - build fix * SUP-141 - : feat - dockerfile update * SUP-141 : feat - build update * SUP-141 - Trigger build * SUP-141 - Trigger build * SUP-141: feat - localise disabled * SUP-141 : feat - disabled ForkTsCheckerWebpackPlugin * SUP-141 : feat - title translation fix * SUP-141 : v6 : granularity fix * SUP-141 : feat - titles * SUP-141 : chore - build trigger * SUP-141 : feat - workflow update * SUP-142 : v6 - translation changes (#118) * SUP-142 : feat - translation changes * SUP-142 : feat - translation fixes * SUP-142 : feat - test * SUP-142 : feat - label revert * SUP-142 : feat - translations * SUP-142 : feat - translation check * SUP-142 : feat - workflow fix * SUP-142 : feat - workflow fix * SUP-142 : feat - workflow update * SUP-142 : feat - pr comments * SUP-142 : feat - dependency workflow * UI-142 : feat - dependency review * SUP-142 : feat - cursor comment * SUP-142 : feat - pr comments * SUP-142 : feat - Hardcoded translation fix * SUP-142 : feat - translation fix --------- Co-authored-by: Tomáš Karela Procházka <tomas.prochazka5d@gmail.com> Co-authored-by: Maxime Beauchemin <maximebeauchemin@gmail.com> Co-authored-by: Claude <noreply@anthropic.com> Co-authored-by: Gabriel Torres Ruiz <gabo2595@gmail.com> Co-authored-by: Kamil Gabryjelski <kamil.gabryjelski@gmail.com> Co-authored-by: Mehmet Salih Yavuz <salih.yavuz@proton.me> Co-authored-by: JUST.in DO IT <justin.park@airbnb.com> Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com> Co-authored-by: Joe Li <joe@preset.io> Co-authored-by: Beto Dealmeida <roberto@dealmeida.net> Co-authored-by: Rafael Benitez <rebenitez1802@gmail.com> Co-authored-by: Vitor Avila <96086495+Vitor-Avila@users.noreply.github.com> Co-authored-by: Sam Firke <sfirke@users.noreply.github.com> Co-authored-by: Daniel Vaz Gaspar <danielvazgaspar@gmail.com> Co-authored-by: Evan Rusackas <evan@preset.io> Co-authored-by: sha174n <105581038+sha174n@users.noreply.github.com> Co-authored-by: catpineapple <catpineapple1122@gmail.com> Co-authored-by: SBIN2010 <132096459+SBIN2010@users.noreply.github.com> Co-authored-by: Damian Pendrak <dpendrak@gmail.com> Co-authored-by: Luiz Otavio <45200344+luizotavio32@users.noreply.github.com> Co-authored-by: Nicolas <48596976+nicob3y@users.noreply.github.com> Co-authored-by: LisaHusband <100658244+LisaHusband@users.noreply.github.com> Co-authored-by: bito-code-review[bot] <188872107+bito-code-review[bot]@users.noreply.github.com> Co-authored-by: Priyanshu Kumar <110410015+cbum-dev@users.noreply.github.com> Co-authored-by: Elizabeth Thompson <eschutho@gmail.com> Co-authored-by: marun <marunrun@163.com> Co-authored-by: Levis Mbote <111055098+LevisNgigi@users.noreply.github.com> Co-authored-by: Pat Buxton <45275736+rad-pat@users.noreply.github.com> Co-authored-by: SBIN2010 <Sbin2010@mail.ru> Co-authored-by: Giulio Piccolo <gpiccolo@suitsupply.com> Co-authored-by: Geidō <60598000+geido@users.noreply.github.com> Co-authored-by: Antonio Rivero <38889534+Antonio-RiveroMartnez@users.noreply.github.com> Co-authored-by: amaannawab923 <amaannawab923@gmail.com> Co-authored-by: Tran Ngoc Tuan <94174684+tuantran0910@users.noreply.github.com> Co-authored-by: Amin Ghadersohi <amin.ghadersohi@gmail.com> Co-authored-by: innovark <eric.graham@mailfence.com> Co-authored-by: yousoph <sophieyou12@gmail.com> Co-authored-by: Erkka Tahvanainen <59445256+tahvane1@users.noreply.github.com> Co-authored-by: Erkka Tahvanainen <erkka.tahvanainen@confidently.fi> Co-authored-by: Richard Fogaca Nienkotter <63572350+richardfogaca@users.noreply.github.com> Co-authored-by: Marcos Amorim <marcosmamorim@gmail.com> Co-authored-by: ngokturkkarli <95430378+ngokturkkarli@users.noreply.github.com> Co-authored-by: Martyn Gigg <martyn.gigg@gmail.com> Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com> Co-authored-by: Yuvraj Singh Chauhan <133221941+ysinghc@users.noreply.github.com> Co-authored-by: Enzo Martellucci <52219496+EnxDev@users.noreply.github.com> Co-authored-by: ethan-l-geotab <165913720+ethan-l-geotab@users.noreply.github.com> Co-authored-by: Vedant Prajapati <40185967+vedantprajapati@users.noreply.github.com> Co-authored-by: Vedant Prajapati <vedantprajapati@geotab.com> Co-authored-by: Janani Gurram <68124448+janani-gurram@users.noreply.github.com> Co-authored-by: Rachel Pan <r.pan@mail.utoronto.ca> Co-authored-by: Rachel Pan <panrrachel@gmail.com> Co-authored-by: Janani Gurram <68124448+JG-ctrl@users.noreply.github.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Yong Le He <76537485+yong1le@users.noreply.github.com> Co-authored-by: PolinaFam <45046398+PolinaFam@users.noreply.github.com> Co-authored-by: Polina Fam <pfam@ptsecurity.com> Co-authored-by: Diego Pucci <diegopucci.me@gmail.com> Co-authored-by: om pharate <72200400+ompharate@users.noreply.github.com> Co-authored-by: Felipe López <felipe.lopezf@ucu.edu.uy>

pull-request-size bot added the size/S label May 8, 2025

korbit-ai bot reviewed May 8, 2025

View reviewed changes

ethan-l-geotab marked this pull request as ready for review May 8, 2025 18:03

dosubot bot added the explore:save Related to saving changes in Explore label May 8, 2025

korbit-ai bot reviewed May 8, 2025

View reviewed changes

ethan-l-geotab force-pushed the facepile-fix branch from 46bc195 to b71c413 Compare May 8, 2025 18:22

rusackas added the review:checkpoint Last PR reviewed during the daily review standup label May 9, 2025

rusackas requested review from EnxDev and kgabryje May 9, 2025 17:29

michael-s-molina removed the review:checkpoint Last PR reviewed during the daily review standup label May 12, 2025

ethan-l-geotab commented Jun 5, 2025

View reviewed changes

pull-request-size bot added size/L and removed size/S labels Jun 19, 2025

rusackas requested a review from Copilot August 8, 2025 19:14

Copilot AI reviewed Aug 8, 2025

View reviewed changes

ethan-l-geotab added 4 commits August 8, 2025 15:23

flipping back to original redux state for update

f500bd6

korbit suggestions

7d55d6e

new solution

19b3173

return new data

d736c35

ethan-l-geotab force-pushed the facepile-fix branch from 5968bb7 to d736c35 Compare August 8, 2025 19:47

pull-request-size bot added size/S and removed size/L labels Aug 8, 2025

mistercrunch reviewed Aug 22, 2025

View reviewed changes

superset-frontend/src/explore/components/PropertiesModal/index.tsx Outdated Show resolved Hide resolved

Refactor chart endpoint usage in PropertiesModal

cf40188

legal-s mentioned this pull request Nov 3, 2025

feat(owners): owners of charts and datasets can now see the resources they own MGDIS/superset#10

Merged

rusackas approved these changes Nov 6, 2025

View reviewed changes

rusackas merged commit 14f20e6 into apache:master Nov 6, 2025
59 checks passed

sadpandajoe added the v6.0 Label added by the release manager to track PRs to be included in the 6.0 branch label Nov 7, 2025

sadpandajoe pushed a commit that referenced this pull request Nov 7, 2025

fix(chart list): Facepile shows correct users when saving chart prope…

33e5314

…rties (#33392) (cherry picked from commit 14f20e6)

github-actions bot added 🍒 6.0.0 Cherry-picked to 6.0.0 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels labels Dec 18, 2025

Comments

Conversation

ethan-l-geotab commented May 8, 2025

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

Uh oh!

korbit-ai bot commented May 8, 2025

Uh oh!

ethan-l-geotab commented May 8, 2025

Uh oh!

korbit-ai bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Review by Korbit AI

Korbit automatically attempts to detect when you fix issues in new commits.

Uh oh!

This comment was marked as resolved.

Uh oh!

This comment was marked as resolved.

Uh oh!

korbit-ai bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Review by Korbit AI

Korbit automatically attempts to detect when you fix issues in new commits.

Uh oh!

This comment was marked as resolved.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

korbit-ai bot May 8, 2025

Choose a reason for hiding this comment

Uh oh!

This comment was marked as resolved.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

korbit-ai bot May 8, 2025

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ethan-l-geotab commented May 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mistercrunch Aug 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ethan-l-geotab Aug 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mistercrunch Aug 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mistercrunch Aug 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ethan-l-geotab commented Jul 3, 2025

Uh oh!

JZ6 commented Aug 8, 2025

korbit-ai bot left a comment •

edited

Loading

korbit-ai bot left a comment •

edited

Loading

ethan-l-geotab commented May 20, 2025 •

edited

Loading

mistercrunch Aug 14, 2025 •

edited

Loading

ethan-l-geotab Aug 22, 2025 •

edited

Loading

mistercrunch Aug 23, 2025 •

edited

Loading

mistercrunch Aug 23, 2025 •

edited

Loading