fix(DatabaseModal): prevent errors when pasting text into supported database select

[EnxDev]

SUMMARY

Problem
When creating a new database connection, users must select the database engine/type from a dropdown.
Currently, pasting a value into this dropdown causes an error.

Solution
This PR fixes the issue by filtering pasted text against the supported database values, preventing errors and
adds a test to ensure that pasting text into the supported database select field correctly filters the available options, preventing the regression of the previous paste-related error.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

• Before
  https://github.com/user-attachments/assets/12822da7-fdde-4577-997e-db3dc248c23e

• After
  https://github.com/user-attachments/assets/d6f75a6c-7ba5-42e0-956f-6c6bb56b2a77

TESTING INSTRUCTIONS

1. All tests should pass
2. Navigate to Settings > Database Connections.
3. Paste a value in the Supported Databases dropdown.

ADDITIONAL INFORMATION

• Has associated issue:
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[bito-code-review]

Code Review Agent Run #af3f5d

Actionable Suggestions - 0

Review Details

• Files reviewed - 1 · Commit Range: d987d1f..d987d1f

  • superset-frontend/src/features/databases/DatabaseModal/index.tsx
• Files skipped - 0
• Tools

  • Whispers (Secret Scanner) - ✔︎ Successful
  • Detect-secrets (Secret Scanner) - ✔︎ Successful

---

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

• /review - Manually triggers a full AI review.

• /pause - Pauses automatic reviews on this pull request.

• /resume - Resumes automatic reviews.

• /resolve - Marks all Bito-posted review comments as resolved.

• /abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Default Agent You can customize the agent settings here or contact your Bito workspace admin at evan@preset.io.

Documentation & Help

• Customize agent settings
• Review rules
• General documentation
• FAQ

AI Code Review powered by

[korbit-ai]

I've completed my review and didn't find any issues.

Files scanned

​

File Path	Reviewed
superset-frontend/src/features/databases/DatabaseModal/index.tsx	✅

Explore our documentation to understand the languages and file types we support and the files we ignore.

Check out our docs on how you can make Korbit work best for you and your team.

Loving Korbit!? Share us on LinkedIn Reddit and X

[github-actions]

🎪 Showtime is building environment on GHA for d987d1f

[bito-code-review]

Interaction Diagram by Bito

sequenceDiagram
participant User as User/Component
participant Modal as DatabaseModal<br/>🔄 Updated | ●●○ Medium
participant Select as Select Component
participant SetDb as setDatabaseModel<br/>🔄 Updated | ●●○ Medium
participant Reducer as dbReducer
participant State as Database State
User->>Modal: Render DatabaseModal
User->>Select: Select database from dropdown
Select->>SetDb: onChange(database_name)
SetDb->>SetDb: Filter availableDbs for match
Note over SetDb: Added null check:<br/>if (!selectedDbModel) return
SetDb->>Reducer: setDB(DbSelected action)
Reducer->>State: Update database state
State-->>Modal: Re-render with config

Loading

Critical path: User/Component -> DatabaseModal -> Select Component -> setDatabaseModel (MODIFIED) -> dbReducer -> Database State

Note: Added null check in setDatabaseModel function to prevent undefined reference errors when database lookup fails. This defensive guard returns early if no matching database is found, protecting downstream property access.

[github-actions]

🎪 Showtime deployed environment on GHA for d987d1f

• Environment: http://35.161.248.34:8080 (admin/admin)
• Lifetime: 48h auto-cleanup
• Updates: New commits create fresh environments automatically

[msyavuz]

Looks good! Can we have some tests?

[github-actions]

🎪 Showtime deployed environment on GHA for f00802a

• Environment: http://34.221.22.254:8080 (admin/admin)
• Lifetime: 48h auto-cleanup
• Updates: New commits create fresh environments automatically

[msyavuz]

Is this correct? Do we not just trigger onChange with a setup like this?

Suggested change

	fireEvent.paste(selectInput, {
	clipboardData: {
	getData: () => 'post',
	},
	});
	fireEvent.change(selectInput, { target: { value: 'post' } });
	fireEvent.paste(selectInput, {
	clipboardData: {
	getData: () => 'post',
	},
	});

[EnxDev]

I simplified the test, when text is pasted into the select, it verifies that no exceptions are thrown

[msyavuz]

LGTM!