-
Notifications
You must be signed in to change notification settings - Fork 16.5k
fix(ag-grid-table): remove enterprise features to use community version #35453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've completed my review and didn't find any issues.
Files scanned
| File Path | Reviewed |
|---|---|
| superset-frontend/plugins/plugin-chart-ag-grid-table/src/AgGridTable/index.tsx | ✅ |
Explore our documentation to understand the languages and file types we support and the files we ignore.
Check out our docs on how you can make Korbit work best for you and your team.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review Agent Run #d4eefe
Actionable Suggestions - 1
-
superset-frontend/plugins/plugin-chart-ag-grid-table/src/AgGridTable/index.tsx - 1
- Missing AG Grid properties · Line 134-137
Review Details
-
Files reviewed - 1 · Commit Range:
53c9eba..53c9eba- superset-frontend/plugins/plugin-chart-ag-grid-table/src/AgGridTable/index.tsx
-
Files skipped - 0
-
Tools
- Whispers (Secret Scanner) - ✔︎ Successful
- Detect-secrets (Secret Scanner) - ✔︎ Successful
Bito Usage Guide
Commands
Type the following command in the pull request comment and save the comment.
-
/review- Manually triggers a full AI review. -
/pause- Pauses automatic reviews on this pull request. -
/resume- Resumes automatic reviews. -
/resolve- Marks all Bito-posted review comments as resolved. -
/abort- Cancels all in-progress reviews.
Refer to the documentation for additional commands.
Configuration
This repository uses Default Agent You can customize the agent settings here or contact your Bito workspace admin at [email protected].
Documentation & Help
superset-frontend/plugins/plugin-chart-ag-grid-table/src/AgGridTable/index.tsx
Show resolved
Hide resolved
superset-frontend/plugins/plugin-chart-ag-grid-table/src/AgGridTable/index.tsx
Show resolved
Hide resolved
alexandrusoare
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - there is one CI failing but seems unrelated
e1a4f11 to
224216f
Compare
|
A rebase would fix the ci failures |
|
The ci is green now @msyavuz |
SUMMARY
🔧 Remove AG Grid Enterprise features to use community version only. AG Grid has strict enforcement where using any enterprise-only
options without the corresponding enterprise modules registered will cause the table to render blank. This PR fixes those issues by
removing all enterprise features.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before: ❌
After: ✅
TESTING INSTRUCTIONS