fix(sqllab): autocomplete and delete tabs #34781
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
change:frontend
![korbit-ai[bot]](https://avatars.githubusercontent.com/in/322216?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review by Korbit AI
Korbit automatically attempts to detect when you fix issues in new commits.
| Category | Issue | Status |
|---|---|---|
 |
Unsafe Active Tab Assignment ▹ view | 🧠 Not in scope |
Files scanned
| File Path | Reviewed |
|---|---|
| superset-frontend/src/SqlLab/reducers/getInitialState.ts | ✅ |
| superset-frontend/src/SqlLab/reducers/sqlLab.js | ✅ |
| superset-frontend/src/SqlLab/components/SqlEditor/index.tsx | ✅ |
Explore our documentation to understand the languages and file types we support and the files we ignore.
Check out our docs on how you can make Korbit work best for you and your team.
| } | ||
| }); | ||
| } | ||
| lastUpdatedActiveTab = tabHistory.slice(tabHistory.length - 1)[0] || ''; |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Member
Author
|
cc: @rebenitez1802 |
justinpark
force-pushed
the
fix--sqllab-autocomplete-and-remove-tabs
branch
from
daf84d8 to
9a900c7
Compare
michael-s-molina
added
the
v6.0
michael-s-molina
approved these changes
Sep 3, 2025
sadpandajoe
pushed a commit
that referenced
this pull request
Sep 4, 2025
(cherry picked from commit cefd046)
github-actions
bot
added
🍒 6.0.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
In the previous #33522, the autocomplete function was set to be skipped before it was synced. In this commit, following the fix for the SQL editor flushing issue in #34720, this behavior has been reverted so that the autocomplete function works correctly. Additionally, an issue where deleted tabs were not removed upon refresh before they were synced to the server has been fixed.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
before:
before--autocomplete.mov
after:
after--autocomplete.mov
before:
before--clear-tabs.mov
after:
after--clear-tabs.mov
TESTING INSTRUCTIONS
Open a new tab and type some keyword to check autocomplete and then close the tab and then refresh the page for deletion
ADDITIONAL INFORMATION