Skip to content

fix: Misaligned global controls in Table chart#34799

Merged
kgabryje merged 1 commit intoapache:masterfrom
kgabryje:fix/table-chart-controls-misalign
Aug 22, 2025
Merged

fix: Misaligned global controls in Table chart#34799
kgabryje merged 1 commit intoapache:masterfrom
kgabryje:fix/table-chart-controls-misalign

Conversation

@kgabryje
Copy link
Member

SUMMARY

Pagination, search and time comparison controls in Table chart were misaligned and had weird spacings.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:

image

After:

image

TESTING INSTRUCTIONS

  1. Open a table chart in Explore
  2. Enable server pagination, search and time comparison
  3. Verify that the controls in the chart are well aligned

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes misaligned global controls in the Table chart by restructuring the layout and removing inconsistent sizing properties. The changes improve visual alignment of pagination, search, and time comparison controls.

  • Simplified layout structure by removing Bootstrap grid classes and replacing with consistent spacing components
  • Removed hardcoded size attributes that caused inconsistent control sizing
  • Reorganized the time comparison dropdown positioning within the main control flow

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
TableChart.tsx Removes size="small" attribute from search input to maintain consistent sizing
DataTable.tsx Restructures global controls layout by removing Bootstrap grid classes and reorganizing component positioning

renderTimeComparisonDropdown ? 'col-sm-7' : 'col-sm-8'
}
>
<StyledSpace size="middle">
Copy link

Copilot AI Aug 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The conditional rendering structure creates asymmetric layout. When searchInput is falsy, pagination controls won't be rendered at all since they're now nested inside the searchInput condition. Consider restructuring to ensure pagination controls are always available when hasPagination is true, regardless of search input state.

Copilot uses AI. Check for mistakes.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@dosubot dosubot bot added change:frontend Requires changing the frontend viz:charts:table Related to the Table chart labels Aug 21, 2025
Copy link

@korbit-ai korbit-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've completed my review and didn't find any issues.

Files scanned
File Path Reviewed
superset-frontend/plugins/plugin-chart-table/src/DataTable/DataTable.tsx
superset-frontend/plugins/plugin-chart-table/src/TableChart.tsx

Explore our documentation to understand the languages and file types we support and the files we ignore.

Check out our docs on how you can make Korbit work best for you and your team.

Loving Korbit!? Share us on LinkedIn Reddit and X

@kgabryje kgabryje force-pushed the fix/table-chart-controls-misalign branch from 766cb9d to d513847 Compare August 21, 2025 16:16
Copy link
Member

@msyavuz msyavuz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Needs a ci run though

@kgabryje kgabryje merged commit 6908a73 into apache:master Aug 22, 2025
75 of 84 checks passed
sadpandajoe pushed a commit that referenced this pull request Aug 23, 2025
@sadpandajoe sadpandajoe added v6.0 Label added by the release manager to track PRs to be included in the 6.0 branch and removed 6.0 labels Aug 26, 2025
@github-actions github-actions bot added 🍒 6.0.0 Cherry-picked to 6.0.0 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels labels Dec 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels change:frontend Requires changing the frontend plugins size/M v6.0 Label added by the release manager to track PRs to be included in the 6.0 branch viz:charts:table Related to the Table chart 🍒 6.0.0 Cherry-picked to 6.0.0

Projects

Development

Successfully merging this pull request may close these issues.

3 participants