Skip to content

fix: DB icon sizes in database add modal#34854

Merged
kgabryje merged 1 commit intoapache:masterfrom
kgabryje:fix/database-modal-icons
Aug 27, 2025
Merged

fix: DB icon sizes in database add modal#34854
kgabryje merged 1 commit intoapache:masterfrom
kgabryje:fix/database-modal-icons

Conversation

@kgabryje
Copy link
Member

SUMMARY

In database add modal, the database add images are very big, while the placeholder icons are small. This PR adjusts the sizes so that it looks more consistent

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:

image

After:

image

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@dosubot dosubot bot added the change:frontend Requires changing the frontend label Aug 26, 2025
Copy link

@korbit-ai korbit-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've completed my review and didn't find any issues.

Files scanned
File Path Reviewed
superset-frontend/packages/superset-ui-core/src/components/IconButton/index.tsx

Explore our documentation to understand the languages and file types we support and the files we ignore.

Check out our docs on how you can make Korbit work best for you and your team.

Loving Korbit!? Share us on LinkedIn Reddit and X

@kgabryje kgabryje merged commit ab58b0a into apache:master Aug 27, 2025
77 of 84 checks passed
sadpandajoe pushed a commit that referenced this pull request Aug 27, 2025
@sadpandajoe sadpandajoe added the v6.0 Label added by the release manager to track PRs to be included in the 6.0 branch label Aug 27, 2025
@github-actions github-actions bot added 🍒 6.0.0 Cherry-picked to 6.0.0 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels labels Dec 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels change:frontend Requires changing the frontend packages size/M v6.0 Label added by the release manager to track PRs to be included in the 6.0 branch 🍒 6.0.0 Cherry-picked to 6.0.0

Projects

Development

Successfully merging this pull request may close these issues.

3 participants