Skip to content

fix(chart list): Facepile shows correct users when saving chart properties #33392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rusackas merged 5 commits into from
Nov 6, 2025
Merged

fix(chart list): Facepile shows correct users when saving chart properties #33392

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f500bd6
flipping back to original redux state for update
ethan-l-geotab May 8, 2025
7d55d6e
korbit suggestions
ethan-l-geotab May 8, 2025
19b3173
new solution
ethan-l-geotab May 20, 2025
d736c35
return new data
ethan-l-geotab Aug 8, 2025
cf40188
Refactor chart endpoint usage in PropertiesModal
ethan-l-geotab Aug 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions superset-frontend/src/explore/components/PropertiesModal/PropertiesModal.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,12 @@ fetchMock.get('glob:*/api/v1/chart/318*', {
type: 1,
},
],
show_title: 'Show Slice',
certification_details: 'Test certification details',
certified_by: 'Test certified by',
description: 'Test description',
cache_timeout: '1000',
slice_name: 'Test chart new name',
},
show_columns: [
'owners.id',
Expand Down
18 changes: 7 additions & 11 deletions superset-frontend/src/explore/components/PropertiesModal/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,20 +192,16 @@ function PropertiesModal({
}

try {
const res = await SupersetClient.put({
endpoint: `/api/v1/chart/${slice.slice_id}`,
const chartEndpoint = `/api/v1/chart/${slice.slice_id}`;
let res = await SupersetClient.put({
endpoint: chartEndpoint,
headers: { 'Content-Type': 'application/json' },
body: JSON.stringify(payload),
});
// update the redux state
const updatedChart = {
...payload,
...res.json.result,
tags,
id: slice.slice_id,
owners: selectedOwners,
};
onSave(updatedChart);
res = await SupersetClient.get({
endpoint: chartEndpoint,
});
onSave(res.json.result);
addSuccessToast(t('Chart properties updated'));
onHide();
} catch (res) {
Expand Down
Loading