fix(d3-format): call setupFormatters synchronously to apply D3 format…

[innovark37]

… when a non‑English language is selected

SUMMARY

Call setupFormatters synchronously so that the custom D3_FORMAT is applied when a non‑English language is selected. See related issue #35524 for more details.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

BEFORE

AFTER

TESTING INSTRUCTIONS

1. In config.py set the LANGUAGES and D3_FORMAT variables, for example:

LANGUAGES = {
    "en": {"flag": "us", "name": "English"},
    "es": {"flag": "es", "name": "Spanish"},
    "it": {"flag": "it", "name": "Italian"},
    "fr": {"flag": "fr", "name": "French"},
    "zh": {"flag": "cn", "name": "Chinese"},
    "zh_TW": {"flag": "tw", "name": "Traditional Chinese"},
    "ja": {"flag": "jp", "name": "Japanese"},
    "de": {"flag": "de", "name": "German"},
    "pl": {"flag": "pl", "name": "Polish"},
    "pt": {"flag": "pt", "name": "Portuguese"},
    "pt_BR": {"flag": "br", "name": "Brazilian Portuguese"},
    "ru": {"flag": "ru", "name": "Russian"},
    "ko": {"flag": "kr", "name": "Korean"},
    "sk": {"flag": "sk", "name": "Slovak"},
    "sl": {"flag": "si", "name": "Slovenian"},
    "nl": {"flag": "nl", "name": "Dutch"},
    "uk": {"flag": "uk", "name": "Ukranian"},
}

class D3Format(TypedDict, total=False):
    decimal: str
    thousands: str
    grouping: list[int]
    currency: list[str]

D3_FORMAT: D3Format = {
  "decimal": ",",
  "thousands": "\u00a0",
  "grouping": [3],
  "currency": ["", "\u00a0\u20bd"]
}

2. Open Superset, switch the UI language to any language other than English (e.g., Spanish, French, etc.).
3. Observe the number formatting on charts and tables. The formatting should match the custom D3_FORMAT.

ADDITIONAL INFORMATION

• Has associated issue: Fixes [6.0.0‑RC2] Custom D3_FORMAT is applied only when the UI language is English #35524
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[bito-code-review]

Code Review Agent Run #df2b36

Actionable Suggestions - 0

Review Details

• Files reviewed - 1 · Commit Range: 3a51c43..3a51c43

  • superset-frontend/src/preamble.ts
• Files skipped - 0
• Tools

  • Eslint (Linter) - ✔︎ Successful
  • Whispers (Secret Scanner) - ✔︎ Successful
  • Detect-secrets (Secret Scanner) - ✔︎ Successful

---

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

• /review - Manually triggers a full AI review.

• /pause - Pauses automatic reviews on this pull request.

• /resume - Resumes automatic reviews.

• /resolve - Marks all Bito-posted review comments as resolved.

• /abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Default Agent You can customize the agent settings here or contact your Bito workspace admin at [email protected].

Documentation & Help

• Customize agent settings
• Review rules
• General documentation
• FAQ

AI Code Review powered by

[korbit-ai]

I've completed my review and didn't find any issues.

Files scanned

​

File Path	Reviewed
superset-frontend/src/preamble.ts	✅

Explore our documentation to understand the languages and file types we support and the files we ignore.

Check out our docs on how you can make Korbit work best for you and your team.

Loving Korbit!? Share us on LinkedIn Reddit and X

[mistercrunch]

Claude's analysis:

PR #35529 Review - D3 Format Fix

What Changed

The PR moves the setupFormatters() call outside the async IIFE (immediately invoked function
expression) to execute it synchronously right after getBootstrapData(), instead of inside the async
block where it runs after the language pack is fetched.

Location: superset-frontend/src/preamble.ts:58-93

Why It Matters

This is a regression fix for a bug introduced in PR #34119. Here's the sequence of events:

1. Before PR #34119: Everything ran synchronously, D3 formatters worked correctly for all languages
2. PR #34119 introduced: Language pack async loading - moved setupFormatters() inside the async
   block
3. Regression: When non-English languages are selected, the language pack loading triggers a second
   call to configure() (line 70), which resets D3 formatters to language-specific defaults, overwriting
   the custom D3_FORMAT from config.py
4. This PR fixes: By calling setupFormatters() synchronously first, then again after language pack
   loads, the custom formats are properly applied

Behavioral Impact

Without this fix:

• English users: ✅ Custom D3_FORMAT works (no language pack fetch, no configure() reset)
• Non-English users: ❌ Custom D3_FORMAT ignored, reverts to D3 defaults

With this fix:

• All users: ✅ Custom D3_FORMAT respected for number/currency formatting

Is It Safe to Merge?

YES, this is super-safe. Here's why:

1. No breaking changes: Only moves existing code, doesn't modify logic
2. Small scope: 10-line change (5 additions, 5 deletions) in a single file
3. Idempotent operation: setupFormatters() can safely be called multiple times - the second call
   (inside async block) simply reinforces the settings
4. Fixes documented regression: Addresses issue #35524 with clear before/after screenshots
5. No dependencies: The function only needs bootstrapData which is already available synchronously
6. Tested pattern: This restores the original synchronous behavior that worked in v5.0.0

Technical Details

The setupFormatters() function from superset-frontend/src/setup/setupFormatters.ts configures D3's
number/time formatting globally. It needs to run:

1. Early - before any charts/visualizations render
2. After configure() calls - to ensure custom formats aren't overwritten

The fix satisfies both requirements by calling it synchronously, then again inside the async block
(defensive redundancy).

Recommendation

✅ SAFE TO MERGE - This is a clean regression fix with no risk and clear user benefit for
internationalization.